From: Leo Izen <leo.izen@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Leo Izen <leo.izen@gmail.com>
Subject: [FFmpeg-devel] [PATCH v2 0/1] [WIP] avutil/csp changes
Date: Sun, 22 May 2022 01:31:43 -0400
Message-ID: <20220522053144.3707803-1-leo.izen@gmail.com> (raw)
Changes in v2:
- increase precision for AVR() macro to 100k, at haasn's request
- add #define AVUTIL_CSP_DENOM 100000
- add 0.5 to the AVR macro definition to get exact values from truncation
This patch is a work in progress example for swapping these
structs from doubles to AVRationals.
There's two main discussions here to be had
- Is this API to be exposed as avpriv_ or av_?
- Should these structs use AVRational or double values?
I don't believe a consensus has been reached on this yet, but I've attached
an AVRational version of it so we can see the pros/cons.
Leo Izen (1):
avutil/csp: create public API for colorspace structs
libavfilter/colorspace.c | 143 ++++++++----------------------------
libavfilter/colorspace.h | 31 +-------
libavfilter/fflcms2.c | 25 ++++---
libavfilter/fflcms2.h | 4 +-
libavfilter/vf_colorspace.c | 37 +++++-----
libavfilter/vf_iccdetect.c | 5 +-
libavfilter/vf_tonemap.c | 17 +----
libavutil/Makefile | 2 +
libavutil/csp.c | 121 ++++++++++++++++++++++++++++++
libavutil/csp.h | 51 +++++++++++++
libavutil/version.h | 4 +-
11 files changed, 252 insertions(+), 188 deletions(-)
create mode 100644 libavutil/csp.c
create mode 100644 libavutil/csp.h
--
2.36.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2022-05-22 5:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 5:31 Leo Izen [this message]
2022-05-22 5:31 ` [FFmpeg-devel] [PATCH v2 1/1] avutil/csp: create public API for colorspace structs Leo Izen
2022-05-22 5:47 ` [FFmpeg-devel] [PATCH v3] " Leo Izen
2022-05-22 11:48 ` [FFmpeg-devel] [PATCH v2 0/1] [WIP] avutil/csp changes Niklas Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220522053144.3707803-1-leo.izen@gmail.com \
--to=leo.izen@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git