From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 537F741213 for ; Thu, 19 May 2022 12:31:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1AF8E68B493; Thu, 19 May 2022 15:31:53 +0300 (EEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A2EDF68B2F6 for ; Thu, 19 May 2022 15:31:46 +0300 (EEST) Received: by mail-pl1-f172.google.com with SMTP id s14so4651466plk.8 for ; Thu, 19 May 2022 05:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=+twY8A8yhfDdbux55fpS/h0ISkTVpk+06qFmS1fB2og=; b=a1b1XnEPNrF0sUYmnN9zZ7hhMCildbyuUxBbsMu76RnL+erfy2ZhHjhiT1EPnJTQPH WgAgOCCLaP7isY9aThG9Vd+H2feib5s9f3CBmhhQivir1f7/S7EMLTFNQYxinjiuI/7z wrRBjogj5sia+syMxZgveMzEOLTtgV2XmOG6S4spTWHc6G5ZVcmqnW7GTzdQQhalS6JH YZMcTfArKMaN2K+kW8sm9J0EhJccK7qdwo3qzx2g12pMNwZWW+m6dlxuA95YDAfbwGL4 rNtabYZnm2gmO0WfbjFqOOiVhf7usIec41izdCYrrgmL3WYMGoQnC0eKhx2y//74I/fb bh8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=+twY8A8yhfDdbux55fpS/h0ISkTVpk+06qFmS1fB2og=; b=ZJ5sCW4lxspDRYNb7GFVELwUXG6n2kAp7E3+YY/2Qa/sqKwiat8L9qd3B1hDegAdeU S1rZ6+xUHp6L9yuhvwpLezTJIJQYGFgEQbo2bZgQX6Y70bwJVSwbtoq5E0KtHG0rB962 8mZOG9LYn7FhUd+yeMlcaKnpmGNgUmEheWZpM6b1O+2n4XFQxBAB0uX5aIBupg1VCfpk jht38Ami31gIbE3obnrs3JIYMLKBf/HOPK2ysHVUBt+DPm9RTXEB8o7jEYnse59pcPB/ umWY2bwCIC9tYfijgEJwRReWQhtAYfn4wTY9MGCXqqBw23Y4/fSAcnpu5cI7sRvM7vDy WzZA== X-Gm-Message-State: AOAM530liNY/lZ3CSVbXDnOLzROxVB9GfTQnitVvzQ1yfHxdiJclubhw FNxBBgo9iT0ntca+LO2hFLgtnHIMnG0= X-Google-Smtp-Source: ABdhPJzCKWIxSbx+VRoAlpqX/aMHTswkFKznaF/u54uwBM1ZjU7HzvXvKxV2+8eNh7/G9YPA5Y1Yzw== X-Received: by 2002:a17:902:74c5:b0:161:5061:9d93 with SMTP id f5-20020a17090274c500b0016150619d93mr4467913plt.171.1652963504506; Thu, 19 May 2022 05:31:44 -0700 (PDT) Received: from gmail.com ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id fs24-20020a17090af29800b001deb92de665sm5512694pjb.46.2022.05.19.05.31.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 May 2022 05:31:44 -0700 (PDT) Date: Thu, 19 May 2022 20:31:40 +0800 From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Message-ID: <20220519123140.GA7493@gmail.com> Mail-Followup-To: ffmpeg-devel@ffmpeg.org References: <1651994221-11660-1-git-send-email-lance.lmwang@gmail.com> <1651994221-11660-2-git-send-email-lance.lmwang@gmail.com> <165227041068.13099.13911768827478787708@lain> <20220511133037.GA897@gmail.com> <165295157862.13099.2165079091588914645@lain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <165295157862.13099.2165079091588914645@lain> Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec: add an AVCodecContext flag to export A53/SCTE20/DVD CC side data on demand X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, May 19, 2022 at 11:12:58AM +0200, Anton Khirnov wrote: > Quoting lance.lmwang@gmail.com (2022-05-11 15:30:37) > > On Wed, May 11, 2022 at 02:00:10PM +0200, Anton Khirnov wrote: > > > Quoting lance.lmwang@gmail.com (2022-05-08 09:17:01) > > > > From: Limin Wang > > > > > > > > some samples include both A53 and SCTE20 data. Before the commit, both > > > > of the will be exported, so the CC data will be repeated or garbarge > > > > > > Why would it be garbage? That sounds like a bug. > > > Why can't we just export both? > > for A53/SCTE20/DVDCC are exprted by A53_CC side data and they're sharing > > the same a53_buf_ref to store the data, so if stream contains CC wrapped > > as ATSC A53 packets + the same data wrapped as SCTE-20 packets, the CC > > data will repeated. We can consider to add a new side data type if necessary, > > but it's preferable to export A53_CC even it's SCTE20, so we can't export > > both by A53_CC still. > > Does this apply to anything other than mpeg2? If not, it should be a > codec-private option rather than a new global flag. Yes, it's for mpeg2 only. At first, I think export_side_data option is proper place to use. But if export_side_data are considered to use for global, then I'll consider to add a mpeg2-private option for it. > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".