From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 75F9D43045 for ; Wed, 18 May 2022 18:28:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3445868B48C; Wed, 18 May 2022 21:27:58 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AEF3D68B3AD for ; Wed, 18 May 2022 21:27:50 +0300 (EEST) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id D933D1BF205 for ; Wed, 18 May 2022 18:27:49 +0000 (UTC) Date: Wed, 18 May 2022 20:27:48 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220518182748.GS396728@pb2> References: <20220518151817.21270-1-leo.izen@gmail.com> <20220518182338.GR396728@pb2> MIME-Version: 1.0 In-Reply-To: <20220518182338.GR396728@pb2> Subject: Re: [FFmpeg-devel] [PATCH v4] avutil/csp: create avpriv API for colorspace structs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7131137211265945883==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7131137211265945883== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aTHdXM4WpLndGb15" Content-Disposition: inline --aTHdXM4WpLndGb15 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 18, 2022 at 08:23:38PM +0200, Michael Niedermayer wrote: > On Wed, May 18, 2022 at 11:18:17AM -0400, Leo Izen wrote: > > This commit moves some of the functionality from avfilter/colorspace > > into avutil/csp and exposes it as an avpriv API so it can be used by > > libavcodec and/or libavformat. > [...] > > +#ifndef AVUTIL_CSP_H > > +#define AVUTIL_CSP_H > > + > > +#include "libavutil/pixfmt.h" > > + > > +typedef struct AVLumaCoefficients { > > + double cr, cg, cb; > > +} AVLumaCoefficients; > > + > > +typedef struct AVPrimaryCoefficients { > > + double xr, yr, xg, yg, xb, yb; > > +} AVPrimaryCoefficients; > > + > > +typedef struct AVWhitepointCoefficients { > > + double xw, yw; > > +} AVWhitepointCoefficients; >=20 > As said, these should not be floating point. > Adding a new public API and changing it later is messy, this > should be changed before its made public i now see you replaced some public by avpriv in the latest patch but still i think this should be changed to fixed point or AVRational first. Even as API between the libs its messy to change it later it would require us to keep the double API when its changed until the next major bump thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Take away the freedom of one citizen and you will be jailed, take away the freedom of all citizens and you will be congratulated by your peers in Parliament. --aTHdXM4WpLndGb15 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYoU6pAAKCRBhHseHBAsP q2MfAJsHnK3j8bvrIXwlhPV+CquInlDdTACfXGs9bA587M9Aam2aGPLQ137AMuk= =kLzF -----END PGP SIGNATURE----- --aTHdXM4WpLndGb15-- --===============7131137211265945883== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7131137211265945883==--