Re: [FFmpeg-devel] [PATCH v4] avutil/csp: create avpriv API for colorspace structs

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1477 bytes --]

On Wed, May 18, 2022 at 08:23:38PM +0200, Michael Niedermayer wrote:
> On Wed, May 18, 2022 at 11:18:17AM -0400, Leo Izen wrote:
> > This commit moves some of the functionality from avfilter/colorspace
> > into avutil/csp and exposes it as an avpriv API so it can be used by
> > libavcodec and/or libavformat.
> [...]
> > +#ifndef AVUTIL_CSP_H
> > +#define AVUTIL_CSP_H
> > +
> > +#include "libavutil/pixfmt.h"
> > +
> > +typedef struct AVLumaCoefficients {
> > +    double cr, cg, cb;
> > +} AVLumaCoefficients;
> > +
> > +typedef struct AVPrimaryCoefficients {
> > +    double xr, yr, xg, yg, xb, yb;
> > +} AVPrimaryCoefficients;
> > +
> > +typedef struct AVWhitepointCoefficients {
> > +    double xw, yw;
> > +} AVWhitepointCoefficients;
> 
> As said, these should not be floating point.
> Adding a new public API and changing it later is messy, this
> should be changed before its made public

i now see you replaced some public by avpriv in the latest patch
but still i think this should be changed to fixed point or AVRational
first. Even as API between the libs its messy to change it later
it would require us to keep the double API when its changed until
the next major bump

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Take away the freedom of one citizen and you will be jailed, take away
the freedom of all citizens and you will be congratulated by your peers
in Parliament.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".