From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 90C0F43041 for ; Wed, 18 May 2022 18:23:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B4E6668B46E; Wed, 18 May 2022 21:23:46 +0300 (EEST) Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1182068B2EC for ; Wed, 18 May 2022 21:23:40 +0300 (EEST) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 31CE9240005 for ; Wed, 18 May 2022 18:23:38 +0000 (UTC) Date: Wed, 18 May 2022 20:23:38 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220518182338.GR396728@pb2> References: <20220518151817.21270-1-leo.izen@gmail.com> MIME-Version: 1.0 In-Reply-To: <20220518151817.21270-1-leo.izen@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v4] avutil/csp: create avpriv API for colorspace structs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5849197453101774867==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5849197453101774867== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="y/XsGip80ttrIE8G" Content-Disposition: inline --y/XsGip80ttrIE8G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 18, 2022 at 11:18:17AM -0400, Leo Izen wrote: > This commit moves some of the functionality from avfilter/colorspace > into avutil/csp and exposes it as an avpriv API so it can be used by > libavcodec and/or libavformat. [...] > +#ifndef AVUTIL_CSP_H > +#define AVUTIL_CSP_H > + > +#include "libavutil/pixfmt.h" > + > +typedef struct AVLumaCoefficients { > + double cr, cg, cb; > +} AVLumaCoefficients; > + > +typedef struct AVPrimaryCoefficients { > + double xr, yr, xg, yg, xb, yb; > +} AVPrimaryCoefficients; > + > +typedef struct AVWhitepointCoefficients { > + double xw, yw; > +} AVWhitepointCoefficients; As said, these should not be floating point. Adding a new public API and changing it later is messy, this should be changed before its made public thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is what and why we do it that matters, not just one of them. --y/XsGip80ttrIE8G Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYoU5pgAKCRBhHseHBAsP q8+WAJ9QRG1ycDdGo2Y68R8nVoZNWTU3tQCfViRZ3pUKwS1VfSeuFKpmKb8whS4= =DNVw -----END PGP SIGNATURE----- --y/XsGip80ttrIE8G-- --===============5849197453101774867== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5849197453101774867==--