From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BE2EC43028 for ; Wed, 18 May 2022 15:55:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A68A768B490; Wed, 18 May 2022 18:55:19 +0300 (EEST) Received: from vie01a-dmta-at03-1.mx.upcmail.net (vie01a-dmta-at03-1.mx.upcmail.net [62.179.121.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8C98D68A987 for ; Wed, 18 May 2022 18:55:13 +0300 (EEST) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-at03.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1nrM0w-0000LK-D0 for ffmpeg-devel@ffmpeg.org; Wed, 18 May 2022 17:55:06 +0200 Received: from ren-mail-psmtp-mg01. ([80.109.253.241]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id rM0rnSf6v8s8UrM0vn3Uz9; Wed, 18 May 2022 17:55:06 +0200 Received: from localhost ([213.47.68.29]) by ren-mail-psmtp-mg01. with ESMTP id rM0vnQ2xjOPqFrM0vnHco4; Wed, 18 May 2022 17:55:05 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.4 cv=OcX7sjfY c=1 sm=1 tr=0 ts=628516d9 a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=haC7fBEpKYnKb-WzXFQA:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Wed, 18 May 2022 17:55:04 +0200 Message-Id: <20220518155505.4912-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 X-CMAE-Envelope: MS4wfMSp87ljiYJD5RfgbFfdocKlfqvkAiU/rYdWB2U9WSwjJEi9MgZA5YATkmXUXkKl/LgLTllzKa+zDiO3RyVeDYywd2wdqqIqjmGXaVpr13fv1p/P345s QOM6yp/8edYF2PSdP+E+8ZYnNSWmFm9Xw+PN1eIHPUK6GXjj45ZaYDaYmTDx7Pc6h1ralrRDjUncFA== Subject: [FFmpeg-devel] [PATCH 1/2] avformat/http: Remove always true non NULL check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Coverity uses the logic of "Comparing options to null implies that options might be null." But ffurl_connect() checks for NULL already and uses &tmp_opts Helps: CID1374122 Signed-off-by: Michael Niedermayer --- libavformat/http.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index c8f3f4b6a3..81c3048934 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -692,8 +692,7 @@ static int http_open(URLContext *h, const char *uri, int flags, if (!s->uri) return AVERROR(ENOMEM); - if (options) - av_dict_copy(&s->chained_options, *options, 0); + av_dict_copy(&s->chained_options, *options, 0); if (s->headers) { int len = strlen(s->headers); -- 2.17.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".