From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 77B8E43010 for ; Wed, 18 May 2022 12:30:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EFB3168B46E; Wed, 18 May 2022 15:30:06 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 13A0C68B226 for ; Wed, 18 May 2022 15:30:00 +0300 (EEST) Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id C722741F9A for ; Wed, 18 May 2022 14:29:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1652876999; bh=pXgUWPymn1nCwdAr21NJtaCpGH+AF6+LNr8ENyklAPI=; h=Date:From:To:Subject:In-Reply-To:References:From; b=I7qMFYYHvyTMqqHSNrp+wuMik6N3QVvxbJOVyXaHsbTZRR/pciVwoqPJkLFhNTlGy WBoOX5Q1Op5g6DpFUSUEOUABx+0gXU8SFVnuwhFqRr7l/uwLrUIuohTK9q25jPLonD WNK6s3w9zneBKRz2fRFZHKJAZwGAQy+fM3jSNF4Q= Date: Wed, 18 May 2022 14:29:59 +0200 Message-ID: <20220518142959.GB49527@haasn.xyz> From: Niklas Haas To: ffmpeg-devel@ffmpeg.org In-Reply-To: <20220518142141.GB31879@haasn.xyz> References: <20220513154208.17941-1-leo.izen@gmail.com> <20220518142141.GB31879@haasn.xyz> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH] avutil/csp: create public API for colorspace structs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 18 May 2022 14:21:41 +0200 Niklas Haas wrote: > On Sun, 15 May 2022 18:32:36 +0200 Andreas Rheinhardt wrote: > > Is there any scenario in which these structs might need to be extended? > > This is something that we could no longer easily do if these structs > > were public. > > This struct has existed in essentially this exact form for decades > (before FFmpeg) and is derived from fundamentals of the human visual > system. I could not begin to dream of a reason it would need to be > suddenly extended - even if we add support for, say, CMYK color spaces > and libavprinter, it would be a new struct. That said, I think that it might make more sense, for reasons of polish, to group the x/y coordinates into their own struct CIExy or something along those lines. Then you can also have helper functions accepting individual CIExy struct elements. But YMMV. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".