From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avutil/csp: create public API for colorspace structs
Date: Wed, 18 May 2022 14:29:59 +0200
Message-ID: <20220518142959.GB49527@haasn.xyz> (raw)
In-Reply-To: <20220518142141.GB31879@haasn.xyz>
On Wed, 18 May 2022 14:21:41 +0200 Niklas Haas <ffmpeg@haasn.xyz> wrote:
> On Sun, 15 May 2022 18:32:36 +0200 Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
> > Is there any scenario in which these structs might need to be extended?
> > This is something that we could no longer easily do if these structs
> > were public.
>
> This struct has existed in essentially this exact form for decades
> (before FFmpeg) and is derived from fundamentals of the human visual
> system. I could not begin to dream of a reason it would need to be
> suddenly extended - even if we add support for, say, CMYK color spaces
> and libavprinter, it would be a new struct.
That said, I think that it might make more sense, for reasons of polish,
to group the x/y coordinates into their own struct CIExy or something
along those lines.
Then you can also have helper functions accepting individual CIExy
struct elements. But YMMV.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-05-18 12:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 15:42 Leo Izen
2022-05-13 19:14 ` Ronald S. Bultje
2022-05-13 19:18 ` James Almer
2022-05-14 2:43 ` Leo Izen
2022-05-13 21:22 ` Michael Niedermayer
2022-05-14 2:41 ` Leo Izen
2022-05-14 12:15 ` Niklas Haas
2022-05-15 16:49 ` Ronald S. Bultje
2022-05-15 18:10 ` Niklas Haas
2022-05-15 18:55 ` Michael Niedermayer
2022-05-15 19:19 ` Michael Niedermayer
2022-05-15 16:32 ` Andreas Rheinhardt
2022-05-16 14:45 ` Leo Izen
2022-05-18 12:21 ` Niklas Haas
2022-05-18 12:29 ` Niklas Haas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518142959.GB49527@haasn.xyz \
--to=ffmpeg@haasn.xyz \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git