From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DED1142F2B for ; Mon, 16 May 2022 01:17:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 41BB968B500; Mon, 16 May 2022 04:17:20 +0300 (EEST) Received: from vie01a-dmta-at03-1.mx.upcmail.net (vie01a-dmta-at03-1.mx.upcmail.net [62.179.121.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A58AC68B4F7 for ; Mon, 16 May 2022 04:17:13 +0300 (EEST) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-at03.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1nqPMA-0003wo-1q for ffmpeg-devel@ffmpeg.org; Mon, 16 May 2022 03:17:06 +0200 Received: from ren-mail-psmtp-mg02. ([80.109.253.241]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id qPL8nCu4S8s8UqPMAntbHp; Mon, 16 May 2022 03:17:06 +0200 Received: from localhost ([213.47.68.29]) by ren-mail-psmtp-mg02. with ESMTP id qPLCnOEXk8eSWqPLCnsHAy; Mon, 16 May 2022 03:16:06 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.4 cv=KKE5sHJo c=1 sm=1 tr=0 ts=6281a5d6 a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=_fnZI6VXZRqDDjkLB6gA:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Mon, 16 May 2022 03:16:05 +0200 Message-Id: <20220516011605.18792-3-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220516011605.18792-1-michael@niedermayer.cc> References: <20220516011605.18792-1-michael@niedermayer.cc> X-CMAE-Envelope: MS4wfCFHxJWtBlrFa4J7m3UHG7Wqr7K+cwwt3w9JcSwtSlMcATKElVvpNQcfmV9zoszZx8h3XRTbmsrErFd1ijGjmMTSHMqiD4MVIrbKZS5jMttbCN1A5l3z /WOLcoukKnypVTNGGAgpxrx6mLf4ABFoVCofABbQGTeq7ruCXg3SbF+aVddnCi34QLU9xOqGiIPT2w== Subject: [FFmpeg-devel] [PATCH 3/3] avcodec/mpeg4videodec: Replace always true check by assert X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Maybe helps coverity Helps: CID1433771 Signed-off-by: Michael Niedermayer --- libavcodec/mpeg4videodec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index e2bde73639..715cb606c9 100644 --- a/libavcodec/mpeg4videodec.c +++ b/libavcodec/mpeg4videodec.c @@ -1981,7 +1981,8 @@ static int mpeg4_decode_studio_block(MpegEncContext *s, int32_t block[64], int n return AVERROR_INVALIDDATA; j = scantable[idx++]; block[j] = get_xbits(&s->gb, additional_code_len); - } else if (group == 21) { + } else { + av_assert2(group == 21); /* Escape */ if (idx > 63) return AVERROR_INVALIDDATA; -- 2.17.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".