[FFmpeg-devel] [PATCH] avfilter/avf_showfreqs: fix memleak in plot_freqs

[FFmpeg-devel] [PATCH] avfilter/avf_showfreqs: fix memleak in plot_freqs

[Steven Liu]

plot_freqs should free colors before return error when
ff_get_video_buffer failed

Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
---
 libavfilter/avf_showfreqs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libavfilter/avf_showfreqs.c b/libavfilter/avf_showfreqs.c
index 6dcff686b6..86a67c7328 100644
--- a/libavfilter/avf_showfreqs.c
+++ b/libavfilter/avf_showfreqs.c
@@ -421,8 +421,10 @@ static int plot_freqs(AVFilterLink *inlink, int64_t pts)
         return AVERROR(ENOMEM);
 
     out = ff_get_video_buffer(outlink, outlink->w, outlink->h);
-    if (!out)
+    if (!out) {
+        av_free(colors);
         return AVERROR(ENOMEM);
+    }
 
     for (n = 0; n < outlink->h; n++)
         memset(out->data[0] + out->linesize[0] * n, 0, outlink->w * 4);
-- 
2.25.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".