From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4BF5E42A9E for ; Fri, 13 May 2022 02:20:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6096B68B44B; Fri, 13 May 2022 05:20:48 +0300 (EEST) Received: from smtpbg.qq.com (smtpbg138.qq.com [106.55.201.18]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4338268B2F6 for ; Fri, 13 May 2022 05:20:42 +0300 (EEST) X-QQ-mid: bizesmtp82t1652408368t9p7w7yo Received: from localhost ( [103.107.216.227]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 13 May 2022 10:19:27 +0800 (CST) X-QQ-SSF: 01100000002000Z0Z000B00A0000000 X-QQ-FEAT: QadFjRvMUN3SuFQw3fuJgDoV2l2EOLqSfLmOoKVcy1OiegfC4zCaWXUJeUtz5 APRJD9sZXBnRw2s772fLawJaWY9We4ykcM8fWGAgi5zIeq3tV3+bd0ioTiApLfSLjuF7n37 mg7WktrNZqmadUgk4FyKHn3+XwGw7rt9GH2giR5GoqEUAewVnWTLn2k6wgjCaPmqyeGCTCO 2sxkC1IPY+bdm8x7zQdsXaBSwJ4rBPVqTnSfalc+tHQAaPKzAbTyp45Ysn/eUSfS14ZmtWo wZC6aPOr3Hzpw2xj3xEbTmS+HvkKbFEEXOgTqBJkE745jn1s+m6vNOEY8= X-QQ-GoodBg: 0 From: Steven Liu To: ffmpeg-devel@ffmpeg.org Date: Fri, 13 May 2022 10:19:24 +0800 Message-Id: <20220513021924.64854-1-lq@chinaffmpeg.org> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:chinaffmpeg.org:qybgspam:qybgspam10 Subject: [FFmpeg-devel] [PATCH] avfilter/avf_showfreqs: fix memleak in plot_freqs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Steven Liu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: plot_freqs should free colors before return error when ff_get_video_buffer failed Signed-off-by: Steven Liu --- libavfilter/avf_showfreqs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/avf_showfreqs.c b/libavfilter/avf_showfreqs.c index 6dcff686b6..86a67c7328 100644 --- a/libavfilter/avf_showfreqs.c +++ b/libavfilter/avf_showfreqs.c @@ -421,8 +421,10 @@ static int plot_freqs(AVFilterLink *inlink, int64_t pts) return AVERROR(ENOMEM); out = ff_get_video_buffer(outlink, outlink->w, outlink->h); - if (!out) + if (!out) { + av_free(colors); return AVERROR(ENOMEM); + } for (n = 0; n < outlink->h; n++) memset(out->data[0] + out->linesize[0] * n, 0, outlink->w * 4); -- 2.25.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".