From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3276F429D3 for ; Wed, 11 May 2022 13:30:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 78BBF68B3ED; Wed, 11 May 2022 16:30:48 +0300 (EEST) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0FEA068B2EF for ; Wed, 11 May 2022 16:30:43 +0300 (EEST) Received: by mail-pj1-f52.google.com with SMTP id fv2so2227187pjb.4 for ; Wed, 11 May 2022 06:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=QLFrHhJrlTNIDDRLsT2zaALKekElSxJX4JSOHYvASN0=; b=mQfzQnG0/XQpLfzuNWWksOQ2v/+M6Hz+3riBahrLrGqQEA4WrVWs1yZzJyaJn/a9+y gGO22BPfAiqNujYJAkvMXpYBmF+MDlVmdnudplnuOd/sjckdHqaOWuTUYcF4aj7DBrC4 Vu6r0OUJsZmj7LTkfpm2NrXqfM3bI0hHNizhRInas7mPJxu23uzJwzIvstsGUrzge3ks wH23CJc9g25ZfIMSVkr1iF0cU5hWHNUZWR9NK5EhvvxJgqC1wcYIDwKTzRDVRkaoWY8+ hDQQ4rnNWCy9+VDaSQKY/vi2uM8doMOSsxB9MonBmlrX/MbKPKGu3eBeQV/O1PvbgkoB sUAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=QLFrHhJrlTNIDDRLsT2zaALKekElSxJX4JSOHYvASN0=; b=AFZXtjg9VqUX323+Ax3haeKbn+IjluwjSZlCqrzhxmUPCa5JQ3xyngwKupTdFw/oTY cHBqDmcWJKwup6lQjixrnUmDAjNfm7Oq5cyFapjt0SE7oV+oa5Ik/j9V5Ydjt689zBQk Q7MBTv5ETN13pleASHABUFntTJIUqEbmAta/HkJNmU5B0lZ5wJZno5sWhJ3VaEBAj8+x 2nFtzn2cfa1+/QUnLIjKBfqRmF10uohx1tK8EudfkSauIudVyoY55ORut5waHdiCOo21 LnY1QZsJ+4X5NM8Rhdz67NR4y1R5Jv2V7sSxROFGH57s6ezJ7etq0TP4pKMdAf4ui3CM kpGw== X-Gm-Message-State: AOAM5327h6KS61xVs7eUFNuX9x3H/zoA7O9ggddrYkfxKp1x5ucPADYX IOBkob4g8rVU+gwjR+EaocNw9+hYHHQ= X-Google-Smtp-Source: ABdhPJyZgJTtWcCM49YTc53wkfPab+rAynbqNPzIK8g5Nd6jC+Ajx6vUgBdBwF4IkNLzwcfpaKXQ1w== X-Received: by 2002:a17:903:240f:b0:156:8e81:a0a3 with SMTP id e15-20020a170903240f00b001568e81a0a3mr25080852plo.13.1652275841152; Wed, 11 May 2022 06:30:41 -0700 (PDT) Received: from gmail.com ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id d11-20020a170902728b00b0015e8d4eb1b8sm1904452pll.2.2022.05.11.06.30.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 May 2022 06:30:40 -0700 (PDT) Date: Wed, 11 May 2022 21:30:37 +0800 From: lance.lmwang@gmail.com To: FFmpeg development discussions and patches Message-ID: <20220511133037.GA897@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches References: <1651994221-11660-1-git-send-email-lance.lmwang@gmail.com> <1651994221-11660-2-git-send-email-lance.lmwang@gmail.com> <165227041068.13099.13911768827478787708@lain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <165227041068.13099.13911768827478787708@lain> Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec: add an AVCodecContext flag to export A53/SCTE20/DVD CC side data on demand X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, May 11, 2022 at 02:00:10PM +0200, Anton Khirnov wrote: > Quoting lance.lmwang@gmail.com (2022-05-08 09:17:01) > > From: Limin Wang > > > > some samples include both A53 and SCTE20 data. Before the commit, both > > of the will be exported, so the CC data will be repeated or garbarge > > Why would it be garbage? That sounds like a bug. > Why can't we just export both? for A53/SCTE20/DVDCC are exprted by A53_CC side data and they're sharing the same a53_buf_ref to store the data, so if stream contains CC wrapped as ATSC A53 packets + the same data wrapped as SCTE-20 packets, the CC data will repeated. We can consider to add a new side data type if necessary, but it's preferable to export A53_CC even it's SCTE20, so we can't export both by A53_CC still. related topic for it: https://trac.ffmpeg.org/ticket/9724 https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220427084949.73931-1-4rusxg@gmail.com/ https://patchwork.ffmpeg.org/project/ffmpeg/patch/20180306222512.20124-1-ffmpeg@tmm1.net/ > > -- > Anton Khirnov -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".