[FFmpeg-devel] [PATCH] avfilter/geq: unbreak alpha processing

[FFmpeg-devel] [PATCH] avfilter/geq: unbreak alpha processing

[Gyan Doshi]

d607af50fd broke alpha processing by always overwriting any supplied
alpha expression.
---
 libavfilter/vf_geq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/vf_geq.c b/libavfilter/vf_geq.c
index fd9e0fd80b..2b53980278 100644
--- a/libavfilter/vf_geq.c
+++ b/libavfilter/vf_geq.c
@@ -275,7 +275,7 @@ static av_cold int geq_init(AVFilterContext *ctx)
 
     if (!geq->expr_str[A] && geq->bps != 32) {
         geq->expr_str[A] = av_asprintf("%d", (1<<geq->bps) - 1);
-    } else {
+    } else if (!geq->expr_str[A]) {
         geq->expr_str[A] = av_asprintf("%f", 1.f);
     }
     if (!geq->expr_str[G])
-- 
2.35.3

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/geq: unbreak alpha processing

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 412 bytes --]

On Sat, May 07, 2022 at 05:34:39PM +0530, Gyan Doshi wrote:
> d607af50fd broke alpha processing by always overwriting any supplied
> alpha expression.
> ---
>  libavfilter/vf_geq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What does censorship reveal? It reveals fear. -- Julian Assange

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/geq: unbreak alpha processing

[Gyan Doshi]

On 2022-05-08 12:40 am, Michael Niedermayer wrote:
> On Sat, May 07, 2022 at 05:34:39PM +0530, Gyan Doshi wrote:
>> d607af50fd broke alpha processing by always overwriting any supplied
>> alpha expression.
>> ---
>>   libavfilter/vf_geq.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> LGTM

Pushed as b980d9e8ecf5d4bc5e39a74bdad98c7cc400da84

Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".