Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH 1/3] lavc/libuavs3d: fix incorrect comments
@ 2022-05-02  3:36 Jun Zhao
  2022-05-02  3:36 ` [FFmpeg-devel] [PATCH 2/3] lavc/cavsdec: Add profile check Jun Zhao
  2022-05-02  3:36 ` [FFmpeg-devel] [PATCH 3/3] lavf/cavsvideodec: Add GuangDian profile support Jun Zhao
  0 siblings, 2 replies; 5+ messages in thread
From: Jun Zhao @ 2022-05-02  3:36 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Jun Zhao

From: Jun Zhao <barryjzhao@tencent.com>

fix incorrect comments

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 libavcodec/libuavs3d.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/libuavs3d.c b/libavcodec/libuavs3d.c
index 48333f17d1..6966e00b62 100644
--- a/libavcodec/libuavs3d.c
+++ b/libavcodec/libuavs3d.c
@@ -1,5 +1,5 @@
 /*
- * RAW AVS3-P2/IEEE1857.10 video demuxer
+ * AVS3-P2/IEEE1857.10 video decoder (using the uavs3d library)
  * Copyright (c) 2020 Zhenyu Wang <wangzhenyu@pkusz.edu.cn>
  *                    Bingjie Han <hanbj@pkusz.edu.cn>
  *                    Huiwen Ren  <hwrenx@gmail.com>
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [FFmpeg-devel] [PATCH 2/3] lavc/cavsdec: Add profile check
  2022-05-02  3:36 [FFmpeg-devel] [PATCH 1/3] lavc/libuavs3d: fix incorrect comments Jun Zhao
@ 2022-05-02  3:36 ` Jun Zhao
  2022-05-02  3:36 ` [FFmpeg-devel] [PATCH 3/3] lavf/cavsvideodec: Add GuangDian profile support Jun Zhao
  1 sibling, 0 replies; 5+ messages in thread
From: Jun Zhao @ 2022-05-02  3:36 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Jun Zhao

From: Jun Zhao <barryjzhao@tencent.com>

Add profile check for cavs decoder, now cavs decoder only support
JiZhun(0x20) profile

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 libavcodec/cavsdec.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/libavcodec/cavsdec.c b/libavcodec/cavsdec.c
index 7aaf3f2bcf..6c69c2c94e 100644
--- a/libavcodec/cavsdec.c
+++ b/libavcodec/cavsdec.c
@@ -1177,6 +1177,11 @@ static int decode_seq_header(AVSContext *h)
     int ret;
 
     h->profile = get_bits(&h->gb, 8);
+    if (h->profile != 0x20) {
+        avpriv_report_missing_feature(h->avctx,
+                                      "only supprt JiZhun profile");
+        return AVERROR_PATCHWELCOME;
+    }
     h->level   = get_bits(&h->gb, 8);
     skip_bits1(&h->gb); //progressive sequence
 
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [FFmpeg-devel] [PATCH 3/3] lavf/cavsvideodec: Add GuangDian profile support
  2022-05-02  3:36 [FFmpeg-devel] [PATCH 1/3] lavc/libuavs3d: fix incorrect comments Jun Zhao
  2022-05-02  3:36 ` [FFmpeg-devel] [PATCH 2/3] lavc/cavsdec: Add profile check Jun Zhao
@ 2022-05-02  3:36 ` Jun Zhao
  2022-05-02  5:15   ` "zhilizhao(赵志立)"
  1 sibling, 1 reply; 5+ messages in thread
From: Jun Zhao @ 2022-05-02  3:36 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Jun Zhao

From: Jun Zhao <barryjzhao@tencent.com>

Enable the Guangdian profile support

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 libavformat/cavsvideodec.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/libavformat/cavsvideodec.c b/libavformat/cavsvideodec.c
index 1fa3aa5e92..437ad544d3 100644
--- a/libavformat/cavsvideodec.c
+++ b/libavformat/cavsvideodec.c
@@ -29,6 +29,7 @@
 #define CAVS_PIC_PB_START_CODE    0x000001b6
 #define CAVS_VIDEO_EDIT_CODE      0x000001b7
 #define CAVS_PROFILE_JIZHUN       0x20
+#define CAVS_PROFILE_GUANGDIAN    0x48
 
 static int cavsvideo_probe(const AVProbeData *p)
 {
@@ -50,7 +51,7 @@ static int cavsvideo_probe(const AVProbeData *p)
             if (code == CAVS_SEQ_START_CODE) {
                 seq++;
                 /* check for the only currently supported profile */
-                if (*ptr != CAVS_PROFILE_JIZHUN)
+                if (*ptr != CAVS_PROFILE_JIZHUN && *ptr != CAVS_PROFILE_GUANGDIAN)
                     return 0;
             } else if ((code == CAVS_PIC_I_START_CODE) ||
                        (code == CAVS_PIC_PB_START_CODE)) {
@@ -66,4 +67,4 @@ static int cavsvideo_probe(const AVProbeData *p)
     return 0;
 }
 
-FF_DEF_RAWVIDEO_DEMUXER(cavsvideo, "raw Chinese AVS (Audio Video Standard)", cavsvideo_probe, NULL, AV_CODEC_ID_CAVS)
+FF_DEF_RAWVIDEO_DEMUXER(cavsvideo, "raw Chinese AVS (Audio Video Standard)", cavsvideo_probe, "avs", AV_CODEC_ID_CAVS)
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [FFmpeg-devel] [PATCH 3/3] lavf/cavsvideodec: Add GuangDian profile support
  2022-05-02  3:36 ` [FFmpeg-devel] [PATCH 3/3] lavf/cavsvideodec: Add GuangDian profile support Jun Zhao
@ 2022-05-02  5:15   ` "zhilizhao(赵志立)"
  2022-05-08  2:53     ` mypopy
  0 siblings, 1 reply; 5+ messages in thread
From: "zhilizhao(赵志立)" @ 2022-05-02  5:15 UTC (permalink / raw)
  To: FFmpeg development discussions and patches



> On May 2, 2022, at 11:36 AM, Jun Zhao <mypopydev@gmail.com> wrote:
> 
> From: Jun Zhao <barryjzhao@tencent.com>
> 
> Enable the Guangdian profile support
> 
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
> libavformat/cavsvideodec.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/libavformat/cavsvideodec.c b/libavformat/cavsvideodec.c
> index 1fa3aa5e92..437ad544d3 100644
> --- a/libavformat/cavsvideodec.c
> +++ b/libavformat/cavsvideodec.c
> @@ -29,6 +29,7 @@
> #define CAVS_PIC_PB_START_CODE    0x000001b6
> #define CAVS_VIDEO_EDIT_CODE      0x000001b7
> #define CAVS_PROFILE_JIZHUN       0x20
> +#define CAVS_PROFILE_GUANGDIAN    0x48

Maybe add a comment here that ‘GUANGDIAN' is broadcasting profile.

> 
> static int cavsvideo_probe(const AVProbeData *p)
> {
> @@ -50,7 +51,7 @@ static int cavsvideo_probe(const AVProbeData *p)
>             if (code == CAVS_SEQ_START_CODE) {
>                 seq++;
>                 /* check for the only currently supported profile */
> -                if (*ptr != CAVS_PROFILE_JIZHUN)
> +                if (*ptr != CAVS_PROFILE_JIZHUN && *ptr != CAVS_PROFILE_GUANGDIAN)
>                     return 0;
>             } else if ((code == CAVS_PIC_I_START_CODE) ||
>                        (code == CAVS_PIC_PB_START_CODE)) {
> @@ -66,4 +67,4 @@ static int cavsvideo_probe(const AVProbeData *p)
>     return 0;
> }
> 
> -FF_DEF_RAWVIDEO_DEMUXER(cavsvideo, "raw Chinese AVS (Audio Video Standard)", cavsvideo_probe, NULL, AV_CODEC_ID_CAVS)
> +FF_DEF_RAWVIDEO_DEMUXER(cavsvideo, "raw Chinese AVS (Audio Video Standard)", cavsvideo_probe, "avs", AV_CODEC_ID_CAVS)
> -- 
> 2.25.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [FFmpeg-devel] [PATCH 3/3] lavf/cavsvideodec: Add GuangDian profile support
  2022-05-02  5:15   ` "zhilizhao(赵志立)"
@ 2022-05-08  2:53     ` mypopy
  0 siblings, 0 replies; 5+ messages in thread
From: mypopy @ 2022-05-08  2:53 UTC (permalink / raw)
  To: FFmpeg development discussions and patches

On Mon, May 2, 2022 at 1:15 PM "zhilizhao(赵志立)" <quinkblack@foxmail.com> wrote:
>
>
>
> > On May 2, 2022, at 11:36 AM, Jun Zhao <mypopydev@gmail.com> wrote:
> >
> > From: Jun Zhao <barryjzhao@tencent.com>
> >
> > Enable the Guangdian profile support
> >
> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> > ---
> > libavformat/cavsvideodec.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavformat/cavsvideodec.c b/libavformat/cavsvideodec.c
> > index 1fa3aa5e92..437ad544d3 100644
> > --- a/libavformat/cavsvideodec.c
> > +++ b/libavformat/cavsvideodec.c
> > @@ -29,6 +29,7 @@
> > #define CAVS_PIC_PB_START_CODE    0x000001b6
> > #define CAVS_VIDEO_EDIT_CODE      0x000001b7
> > #define CAVS_PROFILE_JIZHUN       0x20
> > +#define CAVS_PROFILE_GUANGDIAN    0x48
>
> Maybe add a comment here that ‘GUANGDIAN' is broadcasting profile.
>
Applied the patchset and add the comment, thx
> >
> > static int cavsvideo_probe(const AVProbeData *p)
> > {
> > @@ -50,7 +51,7 @@ static int cavsvideo_probe(const AVProbeData *p)
> >             if (code == CAVS_SEQ_START_CODE) {
> >                 seq++;
> >                 /* check for the only currently supported profile */
> > -                if (*ptr != CAVS_PROFILE_JIZHUN)
> > +                if (*ptr != CAVS_PROFILE_JIZHUN && *ptr != CAVS_PROFILE_GUANGDIAN)
> >                     return 0;
> >             } else if ((code == CAVS_PIC_I_START_CODE) ||
> >                        (code == CAVS_PIC_PB_START_CODE)) {
> > @@ -66,4 +67,4 @@ static int cavsvideo_probe(const AVProbeData *p)
> >     return 0;
> > }
> >
> > -FF_DEF_RAWVIDEO_DEMUXER(cavsvideo, "raw Chinese AVS (Audio Video Standard)", cavsvideo_probe, NULL, AV_CODEC_ID_CAVS)
> > +FF_DEF_RAWVIDEO_DEMUXER(cavsvideo, "raw Chinese AVS (Audio Video Standard)", cavsvideo_probe, "avs", AV_CODEC_ID_CAVS)
> > --
> > 2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-05-08  2:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-02  3:36 [FFmpeg-devel] [PATCH 1/3] lavc/libuavs3d: fix incorrect comments Jun Zhao
2022-05-02  3:36 ` [FFmpeg-devel] [PATCH 2/3] lavc/cavsdec: Add profile check Jun Zhao
2022-05-02  3:36 ` [FFmpeg-devel] [PATCH 3/3] lavf/cavsvideodec: Add GuangDian profile support Jun Zhao
2022-05-02  5:15   ` "zhilizhao(赵志立)"
2022-05-08  2:53     ` mypopy

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git