From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/nut: add float pixel formats support
Date: Sun, 17 Apr 2022 14:54:58 +0200
Message-ID: <20220417125458.GP2829255@pb2> (raw)
In-Reply-To: <20220415095719.158785-1-onemda@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 2098 bytes --]
On Fri, Apr 15, 2022 at 11:57:19AM +0200, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
> libavcodec/raw.c | 9 +++++++++
> libavformat/nut.c | 9 +++++++++
> tests/ref/fate/filter-pixdesc-gbrapf32be | 2 +-
> tests/ref/fate/filter-pixdesc-gbrapf32le | 2 +-
> tests/ref/fate/filter-pixdesc-gbrpf32be | 2 +-
> tests/ref/fate/filter-pixdesc-gbrpf32le | 2 +-
> tests/ref/fate/filter-pixdesc-grayf32be | 2 +-
> tests/ref/fate/filter-pixdesc-grayf32le | 2 +-
> tests/ref/fate/filter-pixfmts-copy | 12 ++++++------
> tests/ref/fate/filter-pixfmts-crop | 12 ++++++------
> tests/ref/fate/filter-pixfmts-field | 12 ++++++------
> tests/ref/fate/filter-pixfmts-fieldorder | 12 ++++++------
> tests/ref/fate/filter-pixfmts-hflip | 12 ++++++------
> tests/ref/fate/filter-pixfmts-il | 12 ++++++------
> tests/ref/fate/filter-pixfmts-null | 12 ++++++------
> tests/ref/fate/filter-pixfmts-scale | 12 ++++++------
> tests/ref/fate/filter-pixfmts-transpose | 12 ++++++------
> tests/ref/fate/filter-pixfmts-vflip | 12 ++++++------
> 18 files changed, 84 insertions(+), 66 deletions(-)
>
> diff --git a/libavcodec/raw.c b/libavcodec/raw.c
> index a371bb36c4..2f23e8632d 100644
> --- a/libavcodec/raw.c
> +++ b/libavcodec/raw.c
> @@ -165,6 +165,9 @@ static const PixelFormatTag raw_pix_fmt_tags[] = {
> { AV_PIX_FMT_YA8, MKTAG('Y', '2', 0 , 8 ) },
> { AV_PIX_FMT_PAL8, MKTAG('P', 'A', 'L', 8 ) },
>
> + { AV_PIX_FMT_GRAYF32LE, MKTAG('Y', '1', 0 , 32 ) },
> + { AV_PIX_FMT_GRAYF32BE, MKTAG(32 , 0 , '1', 'Y') },
I think it should be 33
from nut4cc.txt
"The fourth byte is the number of bits used (8, 16, ...).
33 implies 32bit IEEE floats (33 is used to leave 32 for integers)"
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
It is a danger to trust the dream we wish for rather than
the science we have, -- Dr. Kenneth Brown
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-04-17 12:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 9:57 Paul B Mahol
2022-04-17 12:54 ` Michael Niedermayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220417125458.GP2829255@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git