From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8C37341145 for ; Fri, 15 Apr 2022 22:15:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A482468B4F3; Sat, 16 Apr 2022 01:15:43 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 77D4268B2C8 for ; Sat, 16 Apr 2022 01:15:37 +0300 (EEST) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 97B791BF204 for ; Fri, 15 Apr 2022 22:15:36 +0000 (UTC) Date: Sat, 16 Apr 2022 00:15:35 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220415221535.GO2829255@pb2> References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/5] avcodec/mjpegdec: Always reset got_picture at the beginnig of decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0342730904842884988==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0342730904842884988== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mDQW/dpKlcCZZ96v" Content-Disposition: inline --mDQW/dpKlcCZZ96v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 14, 2022 at 05:56:30PM +0200, Andreas Rheinhardt wrote: > Said field is set when parsing a SOF; yet a picture is only allocated > if skip_frame is !=3D AVDISCARD_ALL. This leads to a crash in the > following case: If a jpeg is split into two parts, the first containing > everything before the scans including the SOF and the second part > containing the rest, and the first part is sent to the decoder with > skip_frame set to AVDISCARD_ALL, got_picture is set, yet no picture > is allocated. If the next part is sent with skip_frame set to > AVDISCARD_NONE, the code presumes that a picture has been allocated, > although it hasn't leading to segfaults. >=20 > Fix this by resetting got_picture at the beginning of decoding. >=20 > Signed-off-by: Andreas Rheinhardt > --- > This patch presumes that there is not use-case for partitioning > the data corresponding to a single AVFrame accross multiple packets. > I am not certain whether this is actually true, in particular > wrt interlaced input where it might be common to put the data for > one field into one packet. > Anyway, no such use is covered by FATE. This changes timestamps slightly for: =2E/ffmpeg -an -i ~/tickets/1915/m_noint.avi -an -bitexact -f framecrc -t 1= - not sure thats intended thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote themselves to the Knowledge alone. -- Isha Upanishad --mDQW/dpKlcCZZ96v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYlnugwAKCRBhHseHBAsP q+uuAJ9k2PgVXFJboEnJ2yuvOEbWOLYTnACgjOL6QS8rv5LT3hLi0ECmimcFuL0= =fXf1 -----END PGP SIGNATURE----- --mDQW/dpKlcCZZ96v-- --===============0342730904842884988== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0342730904842884988==--