From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D6DAE40BC7 for ; Thu, 7 Apr 2022 22:38:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D91E068B36F; Fri, 8 Apr 2022 01:38:07 +0300 (EEST) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C550E68AE81 for ; Fri, 8 Apr 2022 01:38:00 +0300 (EEST) Received: by mail-ed1-f45.google.com with SMTP id q26so8066938edc.7 for ; Thu, 07 Apr 2022 15:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sDCSRDeCRutbrrvAGKX17Ctt7Xz6VAdSciy7zc4BTvY=; b=LwUWrfYDiXKzXGbPfKqiqqnuWTUDILi8LFok4P9N7fVIqoMT4LC9PFFweMags3FH2R Thmd9TKS7kbEv/yj7qp8KRTS6cLEAhYW6rZvHsIWYvxfhuNr7JAXhF+LfzhxJBN1AA92 7KHr5OIidllE777CHGrDtJjNCVLDsa9f33ao55XkDlmxvwzkx08gduywxjHUw0uOsJYx bz7aHDVqv2QI3tS1h4gN8BeYQ9NDudWjALXIJelxEuhHo+vY/qgR+UNFG62LCZDIpPpY 2yIFfiwYYObrdFgZn7ow2AAVXPHUH8tTok9v92/9PK05V3GId7Hgch8AiFsnr1uKkhsF Oh5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=sDCSRDeCRutbrrvAGKX17Ctt7Xz6VAdSciy7zc4BTvY=; b=oIZ9HZo9eoIiR40+VbEj9f2Amy+K//aPTejhQuDs3/RIqccP83OGHCXTx9IBNgDrO4 IOxEBDF1IMy9K9pJLe60Ac90zgncK5dM6JpTzSnv5j2mobElYTPLiK0iTddymuEuwLbu 6Df6hCjpl+68z2zsbAyhr07k0Ca4x3AToQaJo7F2Y3kdGQ9ZtH9aBvBnXZO1f2DQivdg lH+f1AKl47Ju+tdaBekxx7jdWX4MXPJzVMX+xcAYzrDfZbxociUEOq83iNhCwtqFu7P9 zYBH+UNzucjjY1rjHIxvvK4nLQ/uuw/HZW/xfJxUbAJn/cwl7SmqAvUwm9OG/1IBCIiw OjAw== X-Gm-Message-State: AOAM5323zTM7nKDlNr1Rcx4N/NQZz5sNjvIXnaQhPHErdX/eeNpXZGc1 2wtSzl9Srv0j6DV/nX0f4pmsyUMoVPnQYA== X-Google-Smtp-Source: ABdhPJyiOgrihDbPRGBV0rCQc5Y8ggfMGpjFWNdaMAZVYXotPLvpNJjDcxrU1+RJASI6WbBU0CGKLg== X-Received: by 2002:a05:6402:2945:b0:41d:aad:c824 with SMTP id ed5-20020a056402294500b0041d0aadc824mr4744619edb.364.1649371079979; Thu, 07 Apr 2022 15:37:59 -0700 (PDT) Received: from mariano (dynamic-adsl-78-14-80-42.clienti.tiscali.it. [78.14.80.42]) by smtp.gmail.com with ESMTPSA id c11-20020a056402120b00b004196059efd1sm10030174edw.75.2022.04.07.15.37.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 15:37:59 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 71462BFA57; Fri, 8 Apr 2022 00:37:58 +0200 (CEST) Date: Fri, 8 Apr 2022 00:37:58 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: <20220407223758.GH304643@mariano> Mail-Followup-To: FFmpeg development discussions and patches References: <20220403152706.311651-1-stefasab@gmail.com> <164913620786.6085.5082263757974980213@lain.red.khirnov.net> <20220405212708.GD304643@mariano> <20220406144302.GZ2829255@pb2> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="GID0FwUMdk1T2AWN" Content-Disposition: inline In-Reply-To: <20220406144302.GZ2829255@pb2> User-Agent: Mutt/1.13.2 (2019-12-18) Subject: Re: [FFmpeg-devel] [PATCH] ffmpeg: document -d option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --GID0FwUMdk1T2AWN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On date Wednesday 2022-04-06 16:43:02 +0200, Michael Niedermayer wrote: > On Tue, Apr 05, 2022 at 11:27:08PM +0200, Stefano Sabatini wrote: > > On date Tuesday 2022-04-05 07:23:27 +0200, Anton Khirnov wrote: > > > Quoting Stefano Sabatini (2022-04-03 17:27:06) > > > > Option was added in commit 39aafa5ee90e10382e. > > > > > > > > Fix trac issue: http://trac.ffmpeg.org/ticket/1698 > > > > --- > > > > doc/ffmpeg.texi | 12 ++++++++++++ > > > > fftools/ffmpeg_opt.c | 3 +++ > > > > 2 files changed, 15 insertions(+) > > > > > > Does this option do anything useful? Shouldn't it rather be removed? > > > > Works for me. > > > > Do we have a use case for this? This basically disables logs and > > detaches ffmpeg from the terminal. > > > > @Michael, can you comment about this (this was added by you)? > > i have a few udp&tcp tests that used it but i tried now and they work fine > if i remove it so iam not aware of a current use case Updated. --GID0FwUMdk1T2AWN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-ffmpeg-drop-undocumented-d-option.patch" >From d5a8c745a7d82f424cc013d9d4b4429aa8fa20e6 Mon Sep 17 00:00:00 2001 From: Stefano Sabatini Date: Sun, 3 Apr 2022 17:24:40 +0200 Subject: [PATCH] ffmpeg: drop undocumented -d option Option was added in commit 39aafa5ee90e10382e but was never documented. Also does not seem there are current use cases for it, tests for which it was introduced are still working therefore we drop it altogether. Indirectly fix trac issue: http://trac.ffmpeg.org/ticket/1698 --- Changelog | 1 + fftools/ffmpeg.c | 12 ++---------- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/Changelog b/Changelog index e173d43229..5bae61bad5 100644 --- a/Changelog +++ b/Changelog @@ -7,6 +7,7 @@ version 5.1: - pcm-bluray encoder - DFPWM audio encoder/decoder and raw muxer/demuxer - SITI filter +- drop ffmpeg -d option version 5.0: diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 6d62bdc7b0..f82ba8a175 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -132,7 +132,6 @@ static BenchmarkTimeStamps get_benchmark_time_stamps(void); static int64_t getmaxrss(void); static int ifilter_has_all_input_formats(FilterGraph *fg); -static int run_as_daemon = 0; static int nb_frames_dup = 0; static unsigned dup_warning = 1000; static int nb_frames_drop = 0; @@ -420,7 +419,7 @@ void term_init(void) #endif #if HAVE_TERMIOS_H - if (!run_as_daemon && stdin_interaction) { + if (stdin_interaction) { struct termios tty; if (tcgetattr (0, &tty) == 0) { oldtty = tty; @@ -3854,7 +3853,7 @@ static int check_keyboard_interaction(int64_t cur_time) if (received_nb_signals) return AVERROR_EXIT; /* read_key() returns 0 on EOF */ - if(cur_time - last_time >= 100000 && !run_as_daemon){ + if (cur_time - last_time >= 100000) { key = read_key(); last_time = cur_time; }else @@ -4864,13 +4863,6 @@ int main(int argc, char **argv) av_log_set_flags(AV_LOG_SKIP_REPEATED); parse_loglevel(argc, argv, options); - if(argc>1 && !strcmp(argv[1], "-d")){ - run_as_daemon=1; - av_log_set_callback(log_callback_null); - argc--; - argv++; - } - #if CONFIG_AVDEVICE avdevice_register_all(); #endif -- 2.25.1 --GID0FwUMdk1T2AWN Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --GID0FwUMdk1T2AWN--