Re: [FFmpeg-devel] [PATCH] ffmpeg: document -d option

[Stefano Sabatini <stefasab@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

On date Wednesday 2022-04-06 16:43:02 +0200, Michael Niedermayer wrote:
> On Tue, Apr 05, 2022 at 11:27:08PM +0200, Stefano Sabatini wrote:
> > On date Tuesday 2022-04-05 07:23:27 +0200, Anton Khirnov wrote:
> > > Quoting Stefano Sabatini (2022-04-03 17:27:06)
> > > > Option was added in commit 39aafa5ee90e10382e.
> > > > 
> > > > Fix trac issue: http://trac.ffmpeg.org/ticket/1698
> > > > ---
> > > >  doc/ffmpeg.texi      | 12 ++++++++++++
> > > >  fftools/ffmpeg_opt.c |  3 +++
> > > >  2 files changed, 15 insertions(+)
> > > 
> > > Does this option do anything useful? Shouldn't it rather be removed?
> > 
> > Works for me.
> > 
> > Do we have a use case for this? This basically disables logs and
> > detaches ffmpeg from the terminal.
> > 
> > @Michael, can you comment about this (this was added by you)?
> 
> i have a few udp&tcp tests that used it but i tried now and they work fine
> if i remove it so iam not aware of a current use case

Updated.

[-- Attachment #2: 0001-ffmpeg-drop-undocumented-d-option.patch --]
[-- Type: text/x-diff, Size: 2273 bytes --]

From d5a8c745a7d82f424cc013d9d4b4429aa8fa20e6 Mon Sep 17 00:00:00 2001
From: Stefano Sabatini <stefasab@gmail.com>
Date: Sun, 3 Apr 2022 17:24:40 +0200
Subject: [PATCH] ffmpeg: drop undocumented -d option

Option was added in commit 39aafa5ee90e10382e but was never documented.

Also does not seem there are current use cases for it,
tests for which it was introduced are still working therefore we drop
it altogether.

Indirectly fix trac issue: http://trac.ffmpeg.org/ticket/1698
---
 Changelog        |  1 +
 fftools/ffmpeg.c | 12 ++----------
 2 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/Changelog b/Changelog
index e173d43229..5bae61bad5 100644
--- a/Changelog
+++ b/Changelog
@@ -7,6 +7,7 @@ version 5.1:
 - pcm-bluray encoder
 - DFPWM audio encoder/decoder and raw muxer/demuxer
 - SITI filter
+- drop ffmpeg -d option
 
 
 version 5.0:
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 6d62bdc7b0..f82ba8a175 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -132,7 +132,6 @@ static BenchmarkTimeStamps get_benchmark_time_stamps(void);
 static int64_t getmaxrss(void);
 static int ifilter_has_all_input_formats(FilterGraph *fg);
 
-static int run_as_daemon  = 0;
 static int nb_frames_dup = 0;
 static unsigned dup_warning = 1000;
 static int nb_frames_drop = 0;
@@ -420,7 +419,7 @@ void term_init(void)
 #endif
 
 #if HAVE_TERMIOS_H
-    if (!run_as_daemon && stdin_interaction) {
+    if (stdin_interaction) {
         struct termios tty;
         if (tcgetattr (0, &tty) == 0) {
             oldtty = tty;
@@ -3854,7 +3853,7 @@ static int check_keyboard_interaction(int64_t cur_time)
     if (received_nb_signals)
         return AVERROR_EXIT;
     /* read_key() returns 0 on EOF */
-    if(cur_time - last_time >= 100000 && !run_as_daemon){
+    if (cur_time - last_time >= 100000) {
         key =  read_key();
         last_time = cur_time;
     }else
@@ -4864,13 +4863,6 @@ int main(int argc, char **argv)
     av_log_set_flags(AV_LOG_SKIP_REPEATED);
     parse_loglevel(argc, argv, options);
 
-    if(argc>1 && !strcmp(argv[1], "-d")){
-        run_as_daemon=1;
-        av_log_set_callback(log_callback_null);
-        argc--;
-        argv++;
-    }
-
 #if CONFIG_AVDEVICE
     avdevice_register_all();
 #endif
-- 
2.25.1


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".