From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0509C42983 for ; Wed, 6 Apr 2022 15:04:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6870768B1B2; Wed, 6 Apr 2022 18:03:58 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D314168B0E4 for ; Wed, 6 Apr 2022 18:03:51 +0300 (EEST) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id A240640004 for ; Wed, 6 Apr 2022 15:03:50 +0000 (UTC) Date: Wed, 6 Apr 2022 17:03:49 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220406150349.GB2829255@pb2> References: <20220403223825.26764-1-markg85@gmail.com> <20220403223825.26764-2-markg85@gmail.com> <20220405210105.GY2829255@pb2> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v12 1/1] avformat: Add IPFS protocol support. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1460966277647374021==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1460966277647374021== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+nQG/yWoq2g3LXDD" Content-Disposition: inline --+nQG/yWoq2g3LXDD Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 05, 2022 at 11:27:12PM +0200, Mark Gaiser wrote: [...] > > > > > > [...] > > > + // Populate c->gateway_buffer with whatever is in c->gateway > > > + if (c->gateway !=3D NULL) { > > > + if (snprintf(c->gateway_buffer, sizeof(c->gateway_buffer), "= %s", > > > + c->gateway) >=3D sizeof(c->gateway_buffer)) { > > > + av_log(h, AV_LOG_WARNING, "The -gateway parameter is too > > long. " > > > + "We allow a max of %zu > > characters\n", > > > + sizeof(c->gateway_buffer)); > > > + ret =3D AVERROR(EINVAL); > > > + goto err; > > > + } > > > + } else { > > > + // Populate the IPFS gateway if we have any. > > > + // If not, inform the user how to properly set one. > > > + ret =3D populate_ipfs_gateway(h); > > > + > > > + if (ret < 1) { > > > + // We fallback on dweb.link (managed by Protocol Labs). > > > + snprintf(c->gateway_buffer, sizeof(c->gateway_buffer), " > > https://dweb.link"); > > > + > > > + av_log(h, AV_LOG_WARNING, "IPFS does not appear to be > > running. " > > > + "You=E2=80=99re now using the = public > > gateway at dweb.link.\n"); > > > + av_log(h, AV_LOG_INFO, "Installing IPFS locally is > > recommended to " > > > + "improve performance and > > reliability, " > > > + "and not share all your activity > > with a single IPFS gateway.\n" > > > + "There are multiple options to define this > > gateway.\n" > > > + "1. Call ffmpeg with a gateway param, " > > > + "without a trailing slash: -gatew= ay > > .\n" > > > + "2. Define an $IPFS_GATEWAY environment variable > > with the " > > > + "full HTTP URL to the gateway " > > > + "without trailing forward slash.\= n" > > > + "3. Define an $IPFS_PATH environment variable " > > > + "and point it to the IPFS data pa= th " > > > + "- this is typically ~/.ipfs\n"); > > > + } > > > + } > > > > This will print the warning every time a ipfs url is opened. Not just o= nce > > is that intended ? > > >=20 > Yes. >=20 > Or rather, I don't see how to make it persistent in a nice intuitive way. > By nice intuitive I mean showing it for, lets say, 10 times you use ffmpeg > to be "sure" you've seen it before it can stop annoying the user about it. >=20 > Adding complexity for that doesn't seem to be worth it to me. my concern was a use case like image2 formats which open a protocol connect= ion per image. So a ipfs://.../image%d.jpeg would produce a warning per image iam not sure this use case makes sense though.=20 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in capitalist society always remains about the same as it was in ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin --+nQG/yWoq2g3LXDD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYk2r1QAKCRBhHseHBAsP q/avAJ4yVUGl27du0wu+zj0g5tfk1mYg1QCePNvh3GDQDzA0bdcUlElMEXBylcA= =oVwa -----END PGP SIGNATURE----- --+nQG/yWoq2g3LXDD-- --===============1460966277647374021== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1460966277647374021==--