Re: [FFmpeg-devel] [PATCH v12 1/1] avformat: Add IPFS protocol support.

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 3237 bytes --]

On Tue, Apr 05, 2022 at 11:27:12PM +0200, Mark Gaiser wrote:
[...]
> >
> >
> > [...]
> > > +    // Populate c->gateway_buffer with whatever is in c->gateway
> > > +    if (c->gateway != NULL) {
> > > +        if (snprintf(c->gateway_buffer, sizeof(c->gateway_buffer), "%s",
> > > +                     c->gateway) >= sizeof(c->gateway_buffer)) {
> > > +            av_log(h, AV_LOG_WARNING, "The -gateway parameter is too
> > long. "
> > > +                                      "We allow a max of %zu
> > characters\n",
> > > +                   sizeof(c->gateway_buffer));
> > > +            ret = AVERROR(EINVAL);
> > > +            goto err;
> > > +        }
> > > +    } else {
> > > +        // Populate the IPFS gateway if we have any.
> > > +        // If not, inform the user how to properly set one.
> > > +        ret = populate_ipfs_gateway(h);
> > > +
> > > +        if (ret < 1) {
> > > +            // We fallback on dweb.link (managed by Protocol Labs).
> > > +            snprintf(c->gateway_buffer, sizeof(c->gateway_buffer), "
> > https://dweb.link");
> > > +
> > > +            av_log(h, AV_LOG_WARNING, "IPFS does not appear to be
> > running. "
> > > +                                      "You’re now using the public
> > gateway at dweb.link.\n");
> > > +            av_log(h, AV_LOG_INFO, "Installing IPFS locally is
> > recommended to "
> > > +                                   "improve performance and
> > reliability, "
> > > +                                   "and not share all your activity
> > with a single IPFS gateway.\n"
> > > +                   "There are multiple options to define this
> > gateway.\n"
> > > +                   "1. Call ffmpeg with a gateway param, "
> > > +                                   "without a trailing slash: -gateway
> > <url>.\n"
> > > +                   "2. Define an $IPFS_GATEWAY environment variable
> > with the "
> > > +                                   "full HTTP URL to the gateway "
> > > +                                   "without trailing forward slash.\n"
> > > +                   "3. Define an $IPFS_PATH environment variable "
> > > +                                   "and point it to the IPFS data path "
> > > +                                   "- this is typically ~/.ipfs\n");
> > > +        }
> > > +    }
> >
> > This will print the warning every time a ipfs url is opened. Not just once
> > is that intended ?
> >
> 
> Yes.
> 
> Or rather, I don't see how to make it persistent in a nice intuitive way.
> By nice intuitive I mean showing it for, lets say, 10 times you use ffmpeg
> to be "sure" you've seen it before it can stop annoying the user about it.
> 
> Adding complexity for that doesn't seem to be worth it to me.

my concern was a use case like image2 formats which open a protocol connection
per image. So a ipfs://.../image%d.jpeg would produce a warning per image
iam not sure this use case makes sense though. 

thx


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".