From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B695842980 for ; Wed, 6 Apr 2022 14:55:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7AE1768B107; Wed, 6 Apr 2022 17:55:46 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AB25A6806E8 for ; Wed, 6 Apr 2022 17:55:40 +0300 (EEST) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id E557D1C0002 for ; Wed, 6 Apr 2022 14:55:39 +0000 (UTC) Date: Wed, 6 Apr 2022 16:55:39 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220406145539.GA2829255@pb2> References: <20220403214337.4090-1-michael@niedermayer.cc> <20220405203658.GX2829255@pb2> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/ituh263enc: Add AV_CODEC_CAP_SLICE_THREADS to old H.263 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6131788221708935221==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6131788221708935221== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="L2UF3afpZZ7d4TWX" Content-Disposition: inline --L2UF3afpZZ7d4TWX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 06, 2022 at 03:05:07AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Tue, Apr 05, 2022 at 05:07:22PM +0200, Andreas Rheinhardt wrote: > >> Michael Niedermayer: > >>> It is supported by the H.263+ AVCodec already > >>> > >>> Is there any case where this does not work ? > >>> > >>> Fixes regression of some command lines > >>> > >>> Signed-off-by: Michael Niedermayer > >>> --- > >>> libavcodec/ituh263enc.c | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/libavcodec/ituh263enc.c b/libavcodec/ituh263enc.c > >>> index db7cdf1fcb..82dce05e36 100644 > >>> --- a/libavcodec/ituh263enc.c > >>> +++ b/libavcodec/ituh263enc.c > >>> @@ -908,6 +908,7 @@ const FFCodec ff_h263_encoder =3D { > >>> .p.id =3D AV_CODEC_ID_H263, > >>> .p.pix_fmts =3D (const enum AVPixelFormat[]){AV_PIX_FMT_YUV420P,= AV_PIX_FMT_NONE}, > >>> .p.priv_class =3D &h263_class, > >>> + .p.capabilities =3D AV_CODEC_CAP_SLICE_THREADS, > >>> .caps_internal =3D FF_CODEC_CAP_INIT_THREADSAFE | FF_CODEC_CAP_= INIT_CLEANUP, > >>> .priv_data_size =3D sizeof(MpegEncContext), > >>> .init =3D ff_mpv_encode_init, > >> > >> 1. If you claim that there is a regression, you should mention the > >> commit that introduced them in the commit message (it's obviously > >> 8ca4b515e73079cda068e253853654db394b8171 in this case). > >> 2. What command lines regressed exactly? The only command lines that > >> should be affected by said commit are command lines that set the slices > >> option to a value > 1. > >> 3. As the commit message of 8ca4b515e73079cda068e253853654db394b8171 > >> explains, this was intentional, as the H.263 encoder produces broken > >> files with multiple slices (whether with slice-threading or not). One > >> gets all kinds of error messages when decoding such a file: "I cbpy > >> damaged at 1 7", "Error at MB: 316", "illegal ac vlc code at 0x29", > >> "slice end not reached but screenspace end (7 left 800000, score=3D > >> -125)", "run overflow at 0x7 i:1". Of course, there are visual > >> artifacts, too. > >> 4. With this patch, this encoder will by default (at least, by the > >> defaults of the ffmpeg command line tool) produce broken files. > >> 5. "Is there any case where this does not work ?": Is there any where = it > >> works? > >=20 > > The testcases i had where these: > > ./ffmpeg -threads 1 -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t= 1 -bitexact -qscale 2 -slices 1 -y -threads 1 -vcodec h263 -s 352x288 -an = /tmp/file-h263-s1t1.h263 > > ./ffmpeg -threads 1 -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t= 1 -bitexact -qscale 2 -slices 2 -y -threads 1 -vcodec h263 -s 352x288 -an = /tmp/file-h263-s2t1.h263 > > ./ffmpeg -threads 1 -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t= 1 -bitexact -qscale 2 -slices 1 -y -threads 2 -vcodec h263 -s 352x288 -an = /tmp/file-h263-s1t2.h263 > > ./ffmpeg -threads 1 -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t= 1 -bitexact -qscale 2 -slices 2 -y -threads 2 -vcodec h263 -s 352x288 -an = /tmp/file-h263-s2t2.h263 > >=20 > > The files seem to play fine > > i did not try to find a case that fails > >=20 >=20 > ./ffmpeg -threads 1 -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t > 1 -bitexact -qscale 2 -slices 4 -y -threads 4 -vcodec h263 -s 1408x1152 > -an /tmp/file-h263-s2t2.h263 >=20 > produces garbage; also with -s 704x576. slices < 4 seem fine. If one > uses too many slices with smaller resolutions, the file is no longer > correctly probed, but can be correctly decoded with -f h263. > I don't know what is wrong with the bigger resolutions and too many > slices; I don't know H.263 at all. My first (and admittedly only) test > for whether using multiple slices with a single thread works produced > garbage, so I put this codec in the "multiple slices not supported" box. Its a while ago but H263+ has a nice slice structired mode H263 lacks that and uses a more restricted mode see ff_h263_encode_gob_header() I would wildly guess these restrictions are what causes some cases not to work but i didnt check thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Does the universe only have a finite lifespan? No, its going to go on forever, its just that you wont like living in it. -- Hiranya Peiri --L2UF3afpZZ7d4TWX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYk2p5wAKCRBhHseHBAsP qwSnAKCIo0i0ExlZVAN/b2yVqds90/1KnwCcDQFumNWD6/NJaPI1E5AZaN77fsE= =tCu1 -----END PGP SIGNATURE----- --L2UF3afpZZ7d4TWX-- --===============6131788221708935221== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6131788221708935221==--