From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C68CB428E4 for ; Tue, 5 Apr 2022 20:37:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B177B68B167; Tue, 5 Apr 2022 23:37:07 +0300 (EEST) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3ED2E68B0DB for ; Tue, 5 Apr 2022 23:37:00 +0300 (EEST) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 1ED34100002 for ; Tue, 5 Apr 2022 20:36:59 +0000 (UTC) Date: Tue, 5 Apr 2022 22:36:58 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220405203658.GX2829255@pb2> References: <20220403214337.4090-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/ituh263enc: Add AV_CODEC_CAP_SLICE_THREADS to old H.263 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6801818577174627262==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6801818577174627262== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OBHkZxkC9ycDuXbS" Content-Disposition: inline --OBHkZxkC9ycDuXbS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 05, 2022 at 05:07:22PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > It is supported by the H.263+ AVCodec already > >=20 > > Is there any case where this does not work ? > >=20 > > Fixes regression of some command lines > >=20 > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/ituh263enc.c | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/libavcodec/ituh263enc.c b/libavcodec/ituh263enc.c > > index db7cdf1fcb..82dce05e36 100644 > > --- a/libavcodec/ituh263enc.c > > +++ b/libavcodec/ituh263enc.c > > @@ -908,6 +908,7 @@ const FFCodec ff_h263_encoder =3D { > > .p.id =3D AV_CODEC_ID_H263, > > .p.pix_fmts =3D (const enum AVPixelFormat[]){AV_PIX_FMT_YUV420P, A= V_PIX_FMT_NONE}, > > .p.priv_class =3D &h263_class, > > + .p.capabilities =3D AV_CODEC_CAP_SLICE_THREADS, > > .caps_internal =3D FF_CODEC_CAP_INIT_THREADSAFE | FF_CODEC_CAP_IN= IT_CLEANUP, > > .priv_data_size =3D sizeof(MpegEncContext), > > .init =3D ff_mpv_encode_init, >=20 > 1. If you claim that there is a regression, you should mention the > commit that introduced them in the commit message (it's obviously > 8ca4b515e73079cda068e253853654db394b8171 in this case). > 2. What command lines regressed exactly? The only command lines that > should be affected by said commit are command lines that set the slices > option to a value > 1. > 3. As the commit message of 8ca4b515e73079cda068e253853654db394b8171 > explains, this was intentional, as the H.263 encoder produces broken > files with multiple slices (whether with slice-threading or not). One > gets all kinds of error messages when decoding such a file: "I cbpy > damaged at 1 7", "Error at MB: 316", "illegal ac vlc code at 0x29", > "slice end not reached but screenspace end (7 left 800000, score=3D > -125)", "run overflow at 0x7 i:1". Of course, there are visual > artifacts, too. > 4. With this patch, this encoder will by default (at least, by the > defaults of the ffmpeg command line tool) produce broken files. > 5. "Is there any case where this does not work ?": Is there any where it > works? The testcases i had where these: =2E/ffmpeg -threads 1 -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t 1= -bitexact -qscale 2 -slices 1 -y -threads 1 -vcodec h263 -s 352x288 -an /t= mp/file-h263-s1t1.h263 =2E/ffmpeg -threads 1 -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t 1= -bitexact -qscale 2 -slices 2 -y -threads 1 -vcodec h263 -s 352x288 -an /t= mp/file-h263-s2t1.h263 =2E/ffmpeg -threads 1 -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t 1= -bitexact -qscale 2 -slices 1 -y -threads 2 -vcodec h263 -s 352x288 -an /t= mp/file-h263-s1t2.h263 =2E/ffmpeg -threads 1 -i fate-suite/svq3/Vertical400kbit.sorenson3.mov -t 1= -bitexact -qscale 2 -slices 2 -y -threads 2 -vcodec h263 -s 352x288 -an /t= mp/file-h263-s2t2.h263 The files seem to play fine i did not try to find a case that fails thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship: All citizens are under surveillance, all their steps and actions recorded, for the politicians to enforce control. Democracy: All politicians are under surveillance, all their steps and actions recorded, for the citizens to enforce control. --OBHkZxkC9ycDuXbS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYkyoZwAKCRBhHseHBAsP q8rzAJ4pm/EylVt9TaI5R8E7+BdGUExPyQCdG1s30Xv+nsaNY6deftcnt2oEAsM= =uO+S -----END PGP SIGNATURE----- --OBHkZxkC9ycDuXbS-- --===============6801818577174627262== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6801818577174627262==--