From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EBA6342861 for ; Tue, 5 Apr 2022 09:24:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8BF0668B0B9; Tue, 5 Apr 2022 12:24:15 +0300 (EEST) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1504868AF13 for ; Tue, 5 Apr 2022 12:24:09 +0300 (EEST) Received: by mail-pj1-f44.google.com with SMTP id kw18so5048179pjb.5 for ; Tue, 05 Apr 2022 02:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=tnrZrgI9laRK7Jluqts3ILvu8/C89w/pqV080SZjHaE=; b=a3v2N/XtWJYC92btcpuuvUawYaeOBqQuRxCIVI9zMtIxcaHVgvxvOI5NVZS+wM1vP0 u4i3KWKThe2cWSMtub8vfiRlo+/ncC62PqpDhFMWuTCRSAa64g5kj8cACJ0mpY6rHUW1 6au81XYjBsIAEibvolh1qbDP48+Il2gY5KprXp2LSITDl2UJByDswQ7yXi6Lr2HOfl08 1VCp4Fr8e2tctNr/m+d6Kwe1YF4Hkh5UM5Xz+yGErjJRkI2CELFtnkgmlQUv7cczQyDn sojj+serx+mfpwTykxAEpr5vfOtcIiJqH0sjIh4IU5nANbGC4GGQN7231yr5k3DkI/Ca wyhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=tnrZrgI9laRK7Jluqts3ILvu8/C89w/pqV080SZjHaE=; b=XS3iiI1jXWf6dH+7DucLDp9wV84Uvd8HqbdX2NFb3lQ+hyaRMNZfqnFrbtzV5PteCU I7Wq49HkoJsu+1nAkyhrKxqBCqmCwsbykbng+qJKLdI8P494zO0vMnGu4b4xWiM89ATR sz0oAJYUYLweO88/gGgigvnNDJun2UCrYvTqh4BIAnteX/C334CSB6D7nZROw3NCuSon zo3kwNPj+2tAcHulTyp2hiAFk+/nG7qyAdXiuS8mMGLt3SlOXTgdEj9R1nU41LZ4rN0t 1pmXVP+3sPfGrNuWkwmrtcezodwkovJgHeVOZXCGm+7xfRDR+Q5qFHzEK3e5L8uATGYL Vazg== X-Gm-Message-State: AOAM533cgl3t/7ntMyL7BTmmnnKNez+Ox/ODynkBt7xoLxrZ38xG/vJD XifZugUrP/kc3uydT1seAhwaHngJFG0A5g== X-Google-Smtp-Source: ABdhPJzySWQJXSWnXlqFhl/hjw5VZ/oAPML8VuR28bBLd/HoHlXx9dQXYuahS3WiCSQk1p5flRja3Q== X-Received: by 2002:a17:90a:8996:b0:1ca:be37:1d3f with SMTP id v22-20020a17090a899600b001cabe371d3fmr2999546pjn.194.1649150646910; Tue, 05 Apr 2022 02:24:06 -0700 (PDT) Received: from gmail.com ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id z15-20020a056a001d8f00b004fda37855ddsm13841789pfw.168.2022.04.05.02.24.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Apr 2022 02:24:06 -0700 (PDT) Date: Tue, 5 Apr 2022 17:24:03 +0800 From: lance.lmwang@gmail.com To: FFmpeg development discussions and patches Message-ID: <20220405092403.GA10717@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches References: <1648423513-21261-1-git-send-email-lance.lmwang@gmail.com> <1648471271-22016-1-git-send-email-lance.lmwang@gmail.com> <164914999208.19727.18136196180078319403@lain.red.khirnov.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <164914999208.19727.18136196180078319403@lain.red.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH v2 1/4] avutil: add ambient viewing environment metadata side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Apr 05, 2022 at 11:13:12AM +0200, Anton Khirnov wrote: > Quoting lance.lmwang@gmail.com (2022-03-28 14:41:08) > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavutil/frame.c | 1 + > > libavutil/frame.h | 6 +++++ > > libavutil/mastering_display_metadata.c | 23 +++++++++++++++++ > > libavutil/mastering_display_metadata.h | 45 ++++++++++++++++++++++++++++++++++ > > 4 files changed, 75 insertions(+) > > > > diff --git a/libavutil/frame.c b/libavutil/frame.c > > index fbb869f..8882da2 100644 > > --- a/libavutil/frame.c > > +++ b/libavutil/frame.c > > @@ -815,6 +815,7 @@ const char *av_frame_side_data_name(enum AVFrameSideDataType type) > > case AV_FRAME_DATA_DETECTION_BBOXES: return "Bounding boxes for object detection and classification"; > > case AV_FRAME_DATA_DOVI_RPU_BUFFER: return "Dolby Vision RPU Data"; > > case AV_FRAME_DATA_DOVI_METADATA: return "Dolby Vision Metadata"; > > + case AV_FRAME_DATA_AMBIENT_VIEWING_ENV: return "Ambient Viewing Environment"; > > } > > return NULL; > > } > > diff --git a/libavutil/frame.h b/libavutil/frame.h > > index 33fac20..f7b1d4e 100644 > > --- a/libavutil/frame.h > > +++ b/libavutil/frame.h > > @@ -209,6 +209,12 @@ enum AVFrameSideDataType { > > * volume transform - CUVA 005.1-2021. > > */ > > AV_FRAME_DATA_DYNAMIC_HDR_VIVID, > > + > > + /** > > + * ambient viewing environment for a video frame, as described by > > + * the AVAmbientViewingEnvMetadata. > > + */ > > + AV_FRAME_DATA_AMBIENT_VIEWING_ENV, > > }; > > > > enum AVActiveFormatDescription { > > diff --git a/libavutil/mastering_display_metadata.c b/libavutil/mastering_display_metadata.c > > index 6069347..ba1c80f 100644 > > --- a/libavutil/mastering_display_metadata.c > > +++ b/libavutil/mastering_display_metadata.c > > @@ -64,3 +64,26 @@ AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *fram > > > > return (AVContentLightMetadata *)side_data->data; > > } > > + > > +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_alloc(size_t *size) > > +{ > > + AVAmbientViewingEnvMetadata *metadata = av_mallocz(sizeof(*metadata)); > > + > > + if (size) > > + *size = sizeof(*metadata); > > + > > + return metadata; > > +} > > + > > +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_create_side_data(AVFrame *frame) > > +{ > > + AVFrameSideData *side_data = av_frame_new_side_data(frame, > > + AV_FRAME_DATA_AMBIENT_VIEWING_ENV, > > + sizeof(AVAmbientViewingEnvMetadata)); > > + if (!side_data) > > + return NULL; > > + > > + memset(side_data->data, 0, sizeof(AVAmbientViewingEnvMetadata)); > > + > > + return (AVAmbientViewingEnvMetadata *)side_data->data; > > +} > > diff --git a/libavutil/mastering_display_metadata.h b/libavutil/mastering_display_metadata.h > > index c23b07c..d7598c1 100644 > > --- a/libavutil/mastering_display_metadata.h > > +++ b/libavutil/mastering_display_metadata.h > > @@ -125,4 +125,49 @@ AVContentLightMetadata *av_content_light_metadata_alloc(size_t *size); > > */ > > AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *frame); > > The names are horribly long. I would suggest dropping 'metadata' from > the struct and function names, they'd be shorter and no information is > really lost. I'm OK with the suggestion, will update the patch, thanks. > > -- > Anton Khirnov -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".