From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E917040A8A for ; Tue, 5 Apr 2022 06:41:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2E36968B183; Tue, 5 Apr 2022 09:41:07 +0300 (EEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3832B68B002 for ; Tue, 5 Apr 2022 09:41:00 +0300 (EEST) Received: by mail-pl1-f181.google.com with SMTP id d15so4762459pll.10 for ; Mon, 04 Apr 2022 23:41:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=j26Xr2GeNVd+2SdJidvlg8Im7q4z3+V87nzGYm+IFTE=; b=BNO/otc/b+gvCiR0aEZfrrx3ax/HAHN1COaIZ5SMrJU838K+jSONAdK8T8dECt4o8m mlANP5LIydjmGAangnUuoaSEmuvb3Y05nmcMAqAbtr78flDvUGepatm4jtsE/p7XelIt zKWGcgRXPz2WG23dTYYLRoq0Lh+T9nz3d6cJEOttVaMH/oMRNw+RJc5yL2mFHOUh81St 1z14aP0uHGhTI9pDTjwaSIsU6tDTBYxfb1A9Klp10vAXNbegZ1iuDNt2go5shcsqLx1p Lvu4cLAQbeRCB9rS8jmgZlH9ZjUDjIjaK+4hXATbFO08svu2w5vuiEcLjesmCB15hGRQ Pvyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=j26Xr2GeNVd+2SdJidvlg8Im7q4z3+V87nzGYm+IFTE=; b=yNYQcEuBqhWg09NgXTDZEO5F6ZcTrYo3EPCFy3Km9yi6nyFvFh3sHJSGg8q18nNt6A lPDMHabMNkJPV4rDgWhYOY3Yjlg9p1gM3VYETVVOYaWkn0ua5j/iwlwcNBkrGBHGYrwJ gINIJHu5sXjF6gcrc0LdWsslTE7Mj4HBapVIN9Md6gRH4cTRX8+9H8mlFmfsqnnki3On zcI5DvM8O88Pp/6dyo8QKfOTeH7keWptlfK9gAxBXsVk1Jf/5p/Hsb4PmanF9SuWa7kE WiWnKgZZnMO130K4QvqgAvoMtYf5PAcWTFpV9yJ8WK005AWuQZqh6ppiS/HYWaukByhb fGGw== X-Gm-Message-State: AOAM533J/0SFs7m7Rv5rw9vYupQdN7eTqQ+hj0ZN9Tdreb2RXnjqrzX8 LJ925qxSmMc0lZ2pwNShYhZLv2M1s/iH4w== X-Google-Smtp-Source: ABdhPJyW6wUdppU9gphXT0rreLyJSNsK2JQBKlCIO7ekoerrYiEzEdYs7ek03YOMTXjEAoR1Egw/ng== X-Received: by 2002:a17:903:1210:b0:151:fa59:95ef with SMTP id l16-20020a170903121000b00151fa5995efmr2072859plh.57.1649140857877; Mon, 04 Apr 2022 23:40:57 -0700 (PDT) Received: from gmail.com ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id l2-20020a056a0016c200b004f7e3181a41sm14991218pfc.98.2022.04.04.23.40.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Apr 2022 23:40:57 -0700 (PDT) Date: Tue, 5 Apr 2022 14:40:54 +0800 From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Message-ID: <20220405064054.GA18948@gmail.com> Mail-Followup-To: ffmpeg-devel@ffmpeg.org References: <1648423513-21261-1-git-send-email-lance.lmwang@gmail.com> <1648471271-22016-1-git-send-email-lance.lmwang@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1648471271-22016-1-git-send-email-lance.lmwang@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v2 1/4] avutil: add ambient viewing environment metadata side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Mar 28, 2022 at 08:41:08PM +0800, lance.lmwang@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavutil/frame.c | 1 + > libavutil/frame.h | 6 +++++ > libavutil/mastering_display_metadata.c | 23 +++++++++++++++++ > libavutil/mastering_display_metadata.h | 45 ++++++++++++++++++++++++++++++++++ > 4 files changed, 75 insertions(+) > > diff --git a/libavutil/frame.c b/libavutil/frame.c > index fbb869f..8882da2 100644 > --- a/libavutil/frame.c > +++ b/libavutil/frame.c > @@ -815,6 +815,7 @@ const char *av_frame_side_data_name(enum AVFrameSideDataType type) > case AV_FRAME_DATA_DETECTION_BBOXES: return "Bounding boxes for object detection and classification"; > case AV_FRAME_DATA_DOVI_RPU_BUFFER: return "Dolby Vision RPU Data"; > case AV_FRAME_DATA_DOVI_METADATA: return "Dolby Vision Metadata"; > + case AV_FRAME_DATA_AMBIENT_VIEWING_ENV: return "Ambient Viewing Environment"; > } > return NULL; > } > diff --git a/libavutil/frame.h b/libavutil/frame.h > index 33fac20..f7b1d4e 100644 > --- a/libavutil/frame.h > +++ b/libavutil/frame.h > @@ -209,6 +209,12 @@ enum AVFrameSideDataType { > * volume transform - CUVA 005.1-2021. > */ > AV_FRAME_DATA_DYNAMIC_HDR_VIVID, > + > + /** > + * ambient viewing environment for a video frame, as described by > + * the AVAmbientViewingEnvMetadata. > + */ > + AV_FRAME_DATA_AMBIENT_VIEWING_ENV, > }; > > enum AVActiveFormatDescription { > diff --git a/libavutil/mastering_display_metadata.c b/libavutil/mastering_display_metadata.c > index 6069347..ba1c80f 100644 > --- a/libavutil/mastering_display_metadata.c > +++ b/libavutil/mastering_display_metadata.c > @@ -64,3 +64,26 @@ AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *fram > > return (AVContentLightMetadata *)side_data->data; > } > + > +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_alloc(size_t *size) > +{ > + AVAmbientViewingEnvMetadata *metadata = av_mallocz(sizeof(*metadata)); > + > + if (size) > + *size = sizeof(*metadata); > + > + return metadata; > +} > + > +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_create_side_data(AVFrame *frame) > +{ > + AVFrameSideData *side_data = av_frame_new_side_data(frame, > + AV_FRAME_DATA_AMBIENT_VIEWING_ENV, > + sizeof(AVAmbientViewingEnvMetadata)); > + if (!side_data) > + return NULL; > + > + memset(side_data->data, 0, sizeof(AVAmbientViewingEnvMetadata)); > + > + return (AVAmbientViewingEnvMetadata *)side_data->data; > +} > diff --git a/libavutil/mastering_display_metadata.h b/libavutil/mastering_display_metadata.h > index c23b07c..d7598c1 100644 > --- a/libavutil/mastering_display_metadata.h > +++ b/libavutil/mastering_display_metadata.h > @@ -125,4 +125,49 @@ AVContentLightMetadata *av_content_light_metadata_alloc(size_t *size); > */ > AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *frame); > > +/** > + * The characteristics of the nominal ambient viewing environment for > + * the display of the associated video content. > + * To be used as payload of a AVFrameSideData the appropriate type. > + * > + * @note The struct should be allocated with av_ambient_viewing_env_metadata_alloc() > + * and its size is not a part of the public ABI. > + */ > +typedef struct AVAmbientViewingEnvMetadata { > + /** > + * specifies the environmental illuminance of the ambient viewing > + * environment in units of 0.0001 lux. > + * ambient_illuminance shall not be equal to 0. > + */ > + uint32_t ambient_illuminance; > + /** > + * specify the normalized x and y chromaticity coordinates, respectively, > + * of the environmental ambient light in the nominal viewing environment, > + * according to the CIE 1931 definition of x and y as specified in ISO > + * 11664-1 (see also ISO 11664-3 and CIE 15), in normalized increments of > + * 0.00002. The values of ambient_light_x and ambient_light_y shall be in > + * the range of 0 to 50000 > + */ > + uint16_t ambient_light_x; > + uint16_t ambient_light_y; > +} AVAmbientViewingEnvMetadata; > + > +/** > + * Allocate an AVAmbientViewingEnvMetadata structure and set its fields to > + * default values. The resulting struct can be freed using av_freep(). > + * > + * @return An AVAmbientViewingEnvMetadata filled with default values or NULL > + * on failure. > + */ > +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_alloc(size_t *size); > + > +/** > + * Allocate a complete AVAmbientViewingEnvMetadata and add it to the frame. > + * > + * @param frame The frame which side data is added to. > + * > + * @return The AVAmbientViewingEnvMetadata structure to be filled by caller. > + */ > +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_create_side_data(AVFrame *frame); > + > #endif /* AVUTIL_MASTERING_DISPLAY_METADATA_H */ > -- > 1.8.3.1 > will apply the patch set(with bump version and one local fixed for get_bits_long) tomorrow if no more comments. -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".