From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 92522422B9 for ; Fri, 1 Apr 2022 09:25:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 61EAE68B231; Fri, 1 Apr 2022 12:25:16 +0300 (EEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4CD9768B07F for ; Fri, 1 Apr 2022 12:25:10 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648805115; x=1680341115; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=n3Hy4Q6vrTtSzZg9zl4UbmuHFD6OAR4tCLOJWr+8O4s=; b=Kqid6OU1yXUfq5Eq5u0oI08wBepLxiVk7aIW39ehDKUpOH6kA3Kxvo3T RRkHpNl2cjY8iQeDTbtwbWhpn3HqyEQzT6iC09S4A9fnWFsSW/cu6OLS3 tXKdvBSUSTngbqrnXo/1wAyczcABo8PAGDxXGKxfUBDGPn5kl68tTI3Hc 1hO4+Ix8eVdq8hqlQq3mtQ5PhY7QL8M1hk5qxukz9vo2x0JJVsW8K4UA8 b+vI7xFdmODsb2lE4BQDIEvBkIR/HCtCC34l2/OQZTI7I4jlqtasGgEK0 2DtNzX+Id3AwQYzQKwhoP5Iw91XCJBeuq58RkwXcpRUYiLUxbaGG/SgRB w==; X-IronPort-AV: E=McAfee;i="6200,9189,10303"; a="323261240" X-IronPort-AV: E=Sophos;i="5.90,226,1643702400"; d="scan'208";a="323261240" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2022 02:25:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,226,1643702400"; d="scan'208";a="567328726" Received: from desktop-qn7n0nf.sh.intel.com (HELO localhost.localdomain) ([10.239.160.39]) by orsmga008.jf.intel.com with ESMTP; 01 Apr 2022 02:25:07 -0700 From: Tong Wu To: ffmpeg-devel@ffmpeg.org Date: Fri, 1 Apr 2022 17:24:14 +0800 Message-Id: <20220401092416.1018-1-tong1.wu@intel.com> X-Mailer: git-send-email 2.35.1.windows.2 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/3] avutil/hwcontext_d3d11va: add a format check for staging texture X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Tong Wu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: The texDesc.Format needs to be filled in with a corresponding format. I add a format check to initialize the format in case sometimes the ctx->internal->priv is not initialized, such as during the hwmap process. For example, for sample command line: ffmpeg.exe -hwaccel qsv -c:v h264_qsv -i input.264 -vf "hwmap=derive_device=d3d11va:extra_hw_frames=16,format=d3d11,hwdownload,format=nv12" -f rawvideo -y ./output.yuv When deriving from qsv, the ctx->internal->priv remains uninitialized, causing CreateTexture2D failure. Note: this fix only solves this particular issue and does not make the sample command line work immediately. See the other patches in the patchset which fix this qsv->d3d11va command line. Signed-off-by: Tong Wu --- libavutil/hwcontext_d3d11va.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c index 8ab96bad25..f69fb3fc9c 100644 --- a/libavutil/hwcontext_d3d11va.c +++ b/libavutil/hwcontext_d3d11va.c @@ -344,6 +344,8 @@ static int d3d11va_create_staging_texture(AVHWFramesContext *ctx) AVD3D11VADeviceContext *device_hwctx = ctx->device_ctx->hwctx; D3D11VAFramesContext *s = ctx->internal->priv; HRESULT hr; + int i; + D3D11_TEXTURE2D_DESC texDesc = { .Width = ctx->width, .Height = ctx->height, @@ -355,6 +357,20 @@ static int d3d11va_create_staging_texture(AVHWFramesContext *ctx) .CPUAccessFlags = D3D11_CPU_ACCESS_READ | D3D11_CPU_ACCESS_WRITE, }; + if (!texDesc.Format) { + for (i = 0; i < FF_ARRAY_ELEMS(supported_formats); i++) { + if (ctx->sw_format == supported_formats[i].pix_fmt) { + texDesc.Format = supported_formats[i].d3d_format; + break; + } + } + if (i == FF_ARRAY_ELEMS(supported_formats)) { + av_log(ctx, AV_LOG_ERROR, "Unsupported pixel format: %s\n", + av_get_pix_fmt_name(ctx->sw_format)); + return AVERROR(EINVAL); + } + } + hr = ID3D11Device_CreateTexture2D(device_hwctx->device, &texDesc, NULL, &s->staging_texture); if (FAILED(hr)) { av_log(ctx, AV_LOG_ERROR, "Could not create the staging texture (%lx)\n", (long)hr); -- 2.35.1.windows.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".