From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 258EC4211F for ; Mon, 28 Mar 2022 23:09:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EEA1A68B2B5; Tue, 29 Mar 2022 02:09:50 +0300 (EEST) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 16EB868B2AC for ; Tue, 29 Mar 2022 02:09:44 +0300 (EEST) Received: by mail-pj1-f43.google.com with SMTP id c15-20020a17090a8d0f00b001c9c81d9648so947510pjo.2 for ; Mon, 28 Mar 2022 16:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=hP+sZxIkvdd+vuB9oi2Z/HyYhKm11QCCqsHZf0u9QA8=; b=JX7Uuf9CTM9WaOKU0y1dsiZNRoCE69rWZ5VYt+PfiG/Qmilt4BCYMZ0q//YEGn6sqJ 6Y25vZ3s9wjglZJQDVinu/ICr+BWVrNtEieUsE5xt0b3P9pakBLz/zvrZrv8f3hLBWOv 3jYod1BvIQtc5ihf0Tv+JFh1pY1bSTdLxboAYnq65usgsflMty8r32qzuowgaj1e2i4A SEsvOy/IxNHaJcrX/BLFptmuR4uOjlk/ScrPjwSeSyra40Y7sLje8a5Q6clitsbyVMZU hlwR77m0cKHV7L1NfPkC49Id1JfLBYTiuJoXImXW8WTpjkyep3f9522uTxivVNGcOYki 9mWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=hP+sZxIkvdd+vuB9oi2Z/HyYhKm11QCCqsHZf0u9QA8=; b=Kk5YKXcDkE91xIpwBY8mK2vx/c7DVv2ZWJAbWO4il8w5kW0wOjXORSnJ38Vuc0Kxyz kJkabHOs51Qu9E3UI46ZO8P7I3x9OjlQ2RCTdNcsFpdpA1wDUo2AgTPB5cMZP14mtg3T d1BQRpuC0GzP71maDIsV9e94OdRHU6FQXX2vNraDexd8oR8M/1PS+fOvtBa3unmJcgab 6LRQnO7Y5y0MZNUxjKlGv3we7X9cN5zlm8sWwJBq9KQeDKc/n7KxdS0AfVXrTeUIhk7n zKVUmEnVtTVHiyOx3Z1+L7HKmewsfHkWy1J0jqEOB0nPDTHqqWwfDP+bedWgm0K035xY hWwQ== X-Gm-Message-State: AOAM531f5Nkcb+zIDeIZS+56NUrDeIFoGT7SZkNSdM3R8IfsTnAdKYdM IQa4m02zXmcH1SS5izoPOoGJDRJjZlrauA== X-Google-Smtp-Source: ABdhPJymEUb21xJzWGHtc4tQ7CH/mj4aPq0YBWD7NCgSIcDnQEhxq7Q9TI5vGoVpQxO+LWiAHW/APA== X-Received: by 2002:a17:902:8497:b0:154:9282:bc01 with SMTP id c23-20020a170902849700b001549282bc01mr28232104plo.33.1648508981679; Mon, 28 Mar 2022 16:09:41 -0700 (PDT) Received: from gmail.com ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id oo16-20020a17090b1c9000b001b89e05e2b2sm546059pjb.34.2022.03.28.16.09.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Mar 2022 16:09:41 -0700 (PDT) Date: Tue, 29 Mar 2022 07:09:38 +0800 From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Message-ID: <20220328230938.GA31723@gmail.com> Mail-Followup-To: ffmpeg-devel@ffmpeg.org References: <1648423513-21261-1-git-send-email-lance.lmwang@gmail.com> <1648471271-22016-1-git-send-email-lance.lmwang@gmail.com> <1648471271-22016-2-git-send-email-lance.lmwang@gmail.com> <20220328143049.GF2829255@pb2> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220328143049.GF2829255@pb2> Subject: Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec: add support for hevc ambient viewing environment SEI message X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Mar 28, 2022 at 04:30:49PM +0200, Michael Niedermayer wrote: > On Mon, Mar 28, 2022 at 08:41:09PM +0800, lance.lmwang@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/hevc_sei.c | 19 +++++++++++++++++++ > > libavcodec/hevc_sei.h | 8 ++++++++ > > libavcodec/hevcdec.c | 10 ++++++++++ > > tests/ref/fate/hevc-dv-rpu | 6 ++++++ > > 4 files changed, 43 insertions(+) > > > > diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c > > index ec3036f..d94df4e 100644 > > --- a/libavcodec/hevc_sei.c > > +++ b/libavcodec/hevc_sei.c > > @@ -497,6 +497,23 @@ static int decode_film_grain_characteristics(HEVCSEIFilmGrainCharacteristics *h, > > return 0; > > } > > > > +static int decode_ambient_viewing_env(HEVCSEIAmbientViewingEnvironment *s, GetBitContext *gb, int size) > > +{ > > + if (size < 8) > > + return AVERROR_INVALIDDATA; > > + > > + s->ambient_illuminance = get_bits(gb, 32); > > get_bits_long thanks, fixed it locally. > > thx > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Its not that you shouldnt use gotos but rather that you should write > readable code and code with gotos often but not always is less readable > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".