From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D2D0541254 for ; Mon, 28 Mar 2022 14:31:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CB46F68B1FE; Mon, 28 Mar 2022 17:30:57 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9016068AE51 for ; Mon, 28 Mar 2022 17:30:51 +0300 (EEST) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 6DECB20015 for ; Mon, 28 Mar 2022 14:30:50 +0000 (UTC) Date: Mon, 28 Mar 2022 16:30:49 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220328143049.GF2829255@pb2> References: <1648423513-21261-1-git-send-email-lance.lmwang@gmail.com> <1648471271-22016-1-git-send-email-lance.lmwang@gmail.com> <1648471271-22016-2-git-send-email-lance.lmwang@gmail.com> MIME-Version: 1.0 In-Reply-To: <1648471271-22016-2-git-send-email-lance.lmwang@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec: add support for hevc ambient viewing environment SEI message X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1204090463787144990==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1204090463787144990== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GJhTDqz/QYEEJ0ly" Content-Disposition: inline --GJhTDqz/QYEEJ0ly Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 28, 2022 at 08:41:09PM +0800, lance.lmwang@gmail.com wrote: > From: Limin Wang >=20 > Signed-off-by: Limin Wang > --- > libavcodec/hevc_sei.c | 19 +++++++++++++++++++ > libavcodec/hevc_sei.h | 8 ++++++++ > libavcodec/hevcdec.c | 10 ++++++++++ > tests/ref/fate/hevc-dv-rpu | 6 ++++++ > 4 files changed, 43 insertions(+) >=20 > diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c > index ec3036f..d94df4e 100644 > --- a/libavcodec/hevc_sei.c > +++ b/libavcodec/hevc_sei.c > @@ -497,6 +497,23 @@ static int decode_film_grain_characteristics(HEVCSEI= FilmGrainCharacteristics *h, > return 0; > } > =20 > +static int decode_ambient_viewing_env(HEVCSEIAmbientViewingEnvironment *= s, GetBitContext *gb, int size) > +{ > + if (size < 8) > + return AVERROR_INVALIDDATA; > + > + s->ambient_illuminance =3D get_bits(gb, 32); get_bits_long thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable --GJhTDqz/QYEEJ0ly Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYkHGlgAKCRBhHseHBAsP q3nHAKCCkoCEn/XT2FoIZAhFVg+jkd6O3QCgjnl9qwNfl/p8RB2sSoA8N5HEi1c= =YLWc -----END PGP SIGNATURE----- --GJhTDqz/QYEEJ0ly-- --===============1204090463787144990== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1204090463787144990==--