Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec: add support for hevc ambient viewing environment SEI message

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec: add support for hevc ambient viewing environment SEI message
Date: Mon, 28 Mar 2022 16:30:49 +0200
Message-ID: <20220328143049.GF2829255@pb2> (raw)
In-Reply-To: <1648471271-22016-2-git-send-email-lance.lmwang@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1198 bytes --]

On Mon, Mar 28, 2022 at 08:41:09PM +0800, lance.lmwang@gmail.com wrote:
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>  libavcodec/hevc_sei.c      | 19 +++++++++++++++++++
>  libavcodec/hevc_sei.h      |  8 ++++++++
>  libavcodec/hevcdec.c       | 10 ++++++++++
>  tests/ref/fate/hevc-dv-rpu |  6 ++++++
>  4 files changed, 43 insertions(+)
> 
> diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c
> index ec3036f..d94df4e 100644
> --- a/libavcodec/hevc_sei.c
> +++ b/libavcodec/hevc_sei.c
> @@ -497,6 +497,23 @@ static int decode_film_grain_characteristics(HEVCSEIFilmGrainCharacteristics *h,
>      return 0;
>  }
>  
> +static int decode_ambient_viewing_env(HEVCSEIAmbientViewingEnvironment *s, GetBitContext *gb, int size)
> +{
> +    if (size < 8)
> +        return AVERROR_INVALIDDATA;
> +
> +    s->ambient_illuminance  = get_bits(gb, 32);

get_bits_long

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".