From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EE4F14054C for ; Sun, 27 Mar 2022 06:08:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B944468B204; Sun, 27 Mar 2022 09:08:24 +0300 (EEST) Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A639168A320 for ; Sun, 27 Mar 2022 09:08:18 +0300 (EEST) Received: by mail-yb1-f201.google.com with SMTP id w1-20020a5b08c1000000b00633be107f28so9047490ybq.4 for ; Sat, 26 Mar 2022 23:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=wlxIflX2A/2CmvGvcJpdEXPTWxEO5wohfTQoAuUBk58=; b=nVSFCwKBqJhQ52mBZMEiqaDBKc2cQQ9Gfk+03bB5iWRl8e2eTlJoSyc2ToCbr8jOKz Pp8iWuoQD00gMK4F1QwSH7FIG87tA8weJE+hvwP948fCJp8K5Tt//tMCmUqjkF9rtc9t HdkQQI8a+B3PBLaCToxAEJ4vPQwF/iirPu/MkNE0lbQpXm5ZyMEaNNAscsl36Zj9LT0x hwSMD5aCRBFFZj31zrjOADwIoRoPWvRUkRHULkEx4tjqT8YVA7s6Otz4GVowyRxdoAd3 2Uv9maoaBrgm2reXTtzSwAQJkf9O5/crBA2MvLVrwWqv+n8HyV+b3Dr4b1F8hou/Ylj6 pn3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=wlxIflX2A/2CmvGvcJpdEXPTWxEO5wohfTQoAuUBk58=; b=0i7up4dN09fq5NuORf4MefPwcyiB7ucZssto1YOKlkbbl0En4+hZCI1NXlq8HAVYZw styCQRUyfZ/sHv1V8S6KhumxVb1Soq/SbUfkKXOF+5wQ8nkoQ6OrCQ6MfnrNtNbas6Fy 87udAuE2xcgrf1q6oDWz8mgVcKyJcBjAc18Q5EFVm3sIYVgQopLlVLjIe+Nqs0nzI03E nM3wgZxJp5YsNVeNqpkvH3/yBtLg4BoNayfW76woND+7oYgDu/He5JAb5s/JbIk4lyVT TsRrEV5Sz5YaAEqBbo2Y6RuA3x9z4uUJjKebojjHpW3VIwzIscOMNNwjaOEAnZXFnZ9D xxhA== X-Gm-Message-State: AOAM531f2YyK5cY0ZKKA2rKKFIixf94U3WoO3KZVPaJgbF5LL6i4xqgH oV/Q6GDKXND773rpygZYBYL2tKHAUuy0Zjen5EJStSXZg8T7WTaGalEIhnmZoHVgvl6t9Q25P3V LX2arPtEX9djU2XSk6GufMKzLlCl0oypaXn2BrOcaJH2qd/R4ONBZ+0kqbyJCVblbiA== X-Google-Smtp-Source: ABdhPJw94rdUE6dR9oMVYMQLR7dPx/n7r1Wkjp6D2cWfe/PaciAH3AxONpIpW9Dcgn6P0WBgsnL9LprA+kqD X-Received: from wangcao.mtv.corp.google.com ([2620:0:1000:4011:8e1b:338b:a60c:e834]) (user=wangcao job=sendgmr) by 2002:a0d:ebc4:0:b0:2e5:c810:f0e0 with SMTP id u187-20020a0debc4000000b002e5c810f0e0mr19261913ywe.155.1648361296432; Sat, 26 Mar 2022 23:08:16 -0700 (PDT) Date: Sat, 26 Mar 2022 23:08:01 -0700 Message-Id: <20220327060800.3732289-1-wangcao@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.35.1.1021.g381101b075-goog From: Wang Cao To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] avfilter/alimiter: Add "flush_buffer" option to flush the remaining valid data to the output X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Wang Cao Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: The change in the commit will add some samples to the end of the audio stream. The intention is to add a "zero_delay" option eventually to not have the delay in the begining the output from alimiter due to lookahead. Signed-off-by: Wang Cao --- doc/filters.texi | 5 ++++ libavfilter/af_alimiter.c | 57 ++++++++++++++++++++++++++++++++------- 2 files changed, 53 insertions(+), 9 deletions(-) If the intention is clear to you, do you prefer us add the "zero_delay" option to the same patch or it needs to go in a separate patch? Thanks! diff --git a/doc/filters.texi b/doc/filters.texi index d70ac3e237..bb8f7c1a0b 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -1978,6 +1978,11 @@ in release time while 1 produces higher release times. @item level Auto level output signal. Default is enabled. This normalizes audio back to 0dB if enabled. + +@item flush_buffer +Flushes the internal buffer so that all the input audio samples to the limiter +will appear to the output. Currently due to lookahead buffer, the total number +of output samples will be larger than the input. @end table Depending on picked setting it is recommended to upsample input 2x or 4x times diff --git a/libavfilter/af_alimiter.c b/libavfilter/af_alimiter.c index 133f98f165..ba0a1361ac 100644 --- a/libavfilter/af_alimiter.c +++ b/libavfilter/af_alimiter.c @@ -55,6 +55,9 @@ typedef struct AudioLimiterContext { int *nextpos; double *nextdelta; + int flush_buffer; + int total_samples_to_flush; + double delta; int nextiter; int nextlen; @@ -65,14 +68,15 @@ typedef struct AudioLimiterContext { #define AF AV_OPT_FLAG_AUDIO_PARAM | AV_OPT_FLAG_FILTERING_PARAM | AV_OPT_FLAG_RUNTIME_PARAM static const AVOption alimiter_options[] = { - { "level_in", "set input level", OFFSET(level_in), AV_OPT_TYPE_DOUBLE, {.dbl=1},.015625, 64, AF }, - { "level_out", "set output level", OFFSET(level_out), AV_OPT_TYPE_DOUBLE, {.dbl=1},.015625, 64, AF }, - { "limit", "set limit", OFFSET(limit), AV_OPT_TYPE_DOUBLE, {.dbl=1}, 0.0625, 1, AF }, - { "attack", "set attack", OFFSET(attack), AV_OPT_TYPE_DOUBLE, {.dbl=5}, 0.1, 80, AF }, - { "release", "set release", OFFSET(release), AV_OPT_TYPE_DOUBLE, {.dbl=50}, 1, 8000, AF }, - { "asc", "enable asc", OFFSET(auto_release), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, AF }, - { "asc_level", "set asc level", OFFSET(asc_coeff), AV_OPT_TYPE_DOUBLE, {.dbl=0.5}, 0, 1, AF }, - { "level", "auto level", OFFSET(auto_level), AV_OPT_TYPE_BOOL, {.i64=1}, 0, 1, AF }, + { "level_in", "set input level", OFFSET(level_in), AV_OPT_TYPE_DOUBLE, {.dbl=1},.015625, 64, AF }, + { "level_out", "set output level", OFFSET(level_out), AV_OPT_TYPE_DOUBLE, {.dbl=1},.015625, 64, AF }, + { "limit", "set limit", OFFSET(limit), AV_OPT_TYPE_DOUBLE, {.dbl=1}, 0.0625, 1, AF }, + { "attack", "set attack", OFFSET(attack), AV_OPT_TYPE_DOUBLE, {.dbl=5}, 0.1, 80, AF }, + { "release", "set release", OFFSET(release), AV_OPT_TYPE_DOUBLE, {.dbl=50}, 1, 8000, AF }, + { "asc", "enable asc", OFFSET(auto_release), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, AF }, + { "asc_level", "set asc level", OFFSET(asc_coeff), AV_OPT_TYPE_DOUBLE, {.dbl=0.5}, 0, 1, AF }, + { "level", "auto level", OFFSET(auto_level), AV_OPT_TYPE_BOOL, {.i64=1}, 0, 1, AF }, + { "flush_buffer","flush the samples in the lookahead buffer", OFFSET(flush_buffer), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, AF }, { NULL } }; @@ -275,6 +279,39 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in) return ff_filter_frame(outlink, out); } + +static int request_frame(AVFilterLink* outlink) { + AVFilterContext* ctx = outlink->src; + AudioLimiterContext* s = (AudioLimiterContext*)ctx->priv; + int ret; + AVFilterLink *inlink; + AVFrame *silence_frame; + + ret = ff_request_frame(ctx->inputs[0]); + + if (!s->flush_buffer) { + return 0; + } + + if (ret != AVERROR_EOF || s->total_samples_to_flush) { + // Not necessarily an error, just not EOF.s + return ret; + } + + // We reach here when input filters have finished producing data (i.e. EOF), + // but because of the attac param, s->buffer still has meaningful + // audio content that needs flushing. The amount of remaining audio to flush + // is the same as the amount of lookahead that was trimmed from the beginning. + inlink = ctx->inputs[0]; + // Pushes silence frame to flush valid audio in the s->buffer + silence_frame = ff_get_audio_buffer(inlink, s->total_samples_to_flush); + ret = filter_frame(inlink, silence_frame); + if (ret < 0) { + return ret; + } + return AVERROR_EOF; +} + static int config_input(AVFilterLink *inlink) { AVFilterContext *ctx = inlink->dst; @@ -292,7 +329,8 @@ static int config_input(AVFilterLink *inlink) return AVERROR(ENOMEM); memset(s->nextpos, -1, obuffer_size * sizeof(*s->nextpos)); - s->buffer_size = inlink->sample_rate * s->attack * inlink->ch_layout.nb_channels; + s->total_samples_to_flush = inlink->sample_rate * s->attack; + s->buffer_size = s->total_samples_to_flush * inlink->ch_layout.nb_channels; s->buffer_size -= s->buffer_size % inlink->ch_layout.nb_channels; if (s->buffer_size <= 0) { @@ -325,6 +363,7 @@ static const AVFilterPad alimiter_outputs[] = { { .name = "default", .type = AVMEDIA_TYPE_AUDIO, + .request_frame = request_frame, }, }; -- 2.35.1.1021.g381101b075-goog _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".