From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5F72440523 for ; Sat, 26 Mar 2022 15:20:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6F12768B1E1; Sat, 26 Mar 2022 17:20:50 +0200 (EET) Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9F84268ADF6 for ; Sat, 26 Mar 2022 17:20:44 +0200 (EET) Received: by mail-qt1-f181.google.com with SMTP id i4so8852262qti.7 for ; Sat, 26 Mar 2022 08:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=c8jXB3idSXiEPN2ka9AtvE1uSTRyZ6eZuTqR+y4dnso=; b=jY787ClhjBbloDRK5k/iGOZBWZfKJWi7Xy6z4H8jR8L/9Inw1S3Kq7IDEybyYLTvJV oWPncogc0/V8LGhd6vZU7/eIyz4iZKnYZz9d0/mhr1j/mclmpEPdDao+rynsiARFBk8y Xb3l2gOWKP3DqzOAmxD0Hmc77KUIj+hw6hgNJLRC5N4vV813h5mtPncnZp4ZEtU8QsOy ksACMi9JTj3ZK2m0PpupDLexX02SyXwxtNcfSPkMD3hp0qoV4qMzSoHlczxVbDITiS3o ysv1Ozk4jzchsWh//rn2cYBMV9Z7R7BWPXpcgkWyOYIFReFYvzcPsproKM5OOaLhHHcZ 6zxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=c8jXB3idSXiEPN2ka9AtvE1uSTRyZ6eZuTqR+y4dnso=; b=Tt8Pze1Vt0y0sAAag7bvdHIFg5F/M7nIR+hPFzDuyy4bQQT0O4q1KiJ4Rrn+/12vy1 UMwdLDrik+yVwyyJhIMyo5aF4mHfvicx1m89MP+C4LCV5ANtaLvmx1mJni9KPZs7yoYY BuQr6XUr4DJWe8znWFVikfwDb5OBeAsYS9tVoi//H3eopTj9Twd/ZRwSd30phdKaFcq/ kLkaz7PXvkwCrPNmZG3xH/uCTZgmg9HVnFngcjabnJ+FkF1nRzp9Ykh2glPytmUmxhSF 7IoR8w+fjQmvdeJbxQR2YrLjtrRVL9GzwTziZyVe8D56S+ahYXG0jBI0D91FEmsNbLSh fHNQ== X-Gm-Message-State: AOAM533Gle/10zu5Vj/Qhj3gb8Q1xxCgfH1VELGJmK7Pq/w83SpDawuQ ZiHfapV57OEwAtQaoLjOhfs= X-Google-Smtp-Source: ABdhPJyfn6kwk08LIszMVNqroH7GBHYmCczbvibE0m91zIpovgImElk7BzTTyJZ3wFPGCqBrAG2gpQ== X-Received: by 2002:a05:622a:1d4:b0:2e1:b942:83dd with SMTP id t20-20020a05622a01d400b002e1b94283ddmr13969790qtw.321.1648308043130; Sat, 26 Mar 2022 08:20:43 -0700 (PDT) Received: from jackie (pool-108-20-201-137.bstnma.fios.verizon.net. [108.20.201.137]) by smtp.gmail.com with ESMTPSA id d2-20020ac85ac2000000b002e1cc2d363asm7613504qtd.24.2022.03.26.08.20.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Mar 2022 08:20:41 -0700 (PDT) Date: Sat, 26 Mar 2022 11:20:39 -0400 From: Andriy Gelman To: "Wang, Fei W" Message-ID: <20220326152039.r7jxctpzom2m7upj@jackie> References: <20220322141119.595627-1-fei.w.wang@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v4 1/2] lavc/vaapi_encode: add support for maxframesize X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "ffmpeg-devel@ffmpeg.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 23. Mar 08:51, Wang, Fei W wrote: > > -----Original Message----- > > From: Wang, Fei W > > Sent: Tuesday, March 22, 2022 10:11 PM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Linjie Fu ; Wang, Fei W > > Subject: [PATCH v4 1/2] lavc/vaapi_encode: add support for maxframesize > > > > From: Linjie Fu > > > > Add support for max frame size: > > - max_frame_size (bytes) to indicate the max allowed size for frame. > > > > If the frame size exceeds the limitation, encoder will to control the frame size by > > adjusting QP value. > > - MFS_NUM_PASSES to indicate number of passes for QP adjust. > > - MFS_DELTA_QP to indicate adjust qp value per pass. > > > > To simplify the usage, default QP adjust is set to delta_qp[4] = {1, 1, 1, 1}. > > Use new_qp for encoder if frame size exceeds the limitation: > > new_qp = base_qp + delta_qp[0] + delta_qp[1] + ... > > > > ffmpeg -hwaccel vaapi -vaapi_device /dev/dri/renderD128 -f rawvideo \ > > -v verbose -s:v 352x288 -i ./input.yuv -vf format=nv12,hwupload \ > > -c:v h264_vaapi -profile:v main -g 30 -bf 3 -max_frame_size 40000 \ > > -vframes 100 -y ./max_frame_size.h264 > > > > Max frame size was enabled since VA-API version (1, 3, 0), but query is available > > since (1, 5, 0). It will be passed as a parameter in picParam and should be set for > > each frame. > > > > Signed-off-by: Linjie Fu > > Signed-off-by: Fei Wang > > --- > > 1. re-send the 2 legacy patch: > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20190715105936.4860-1- > > linjie.fu@intel.com/ > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20190715110000.5069-1- > > linjie.fu@intel.com/ > > > > libavcodec/vaapi_encode.c | 67 > > +++++++++++++++++++++++++++++++++++++++ > > libavcodec/vaapi_encode.h | 19 +++++++++-- > > 2 files changed, 84 insertions(+), 2 deletions(-) Hi, > > Hi Andriy, > > Is there any way to know the details of failure for this patch? Like OS, configuration, > gcc version, etc. It looks good on my local Ubuntu with gcc 9.3, but show fails in patchwork checks: > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220322141119.595627-1-fei.w.wang@intel.com/ > I don't think it was a real issue. I was upgrading the x86 runner at the time. -- Andriy _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".