From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 4/8] lavc/snow: only allocate mconly_picture for decoding
Date: Fri, 25 Mar 2022 00:07:38 +0100
Message-ID: <20220324230738.GW2829255@pb2> (raw)
In-Reply-To: <20220323155720.20017-4-anton@khirnov.net>
[-- Attachment #1.1: Type: text/plain, Size: 1585 bytes --]
On Wed, Mar 23, 2022 at 04:57:16PM +0100, Anton Khirnov wrote:
> It is not used in the encoder.
> ---
> libavcodec/snow.c | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
this is segfaulting with some fuzzed file
==30657== Invalid read of size 8
==30657== at 0x1157660: ??? (libavcodec/x86/videodsp.asm:340)
==30657== by 0xE18591: emulated_edge_mc_avx2 (videodsp_init.c:268)
==30657== by 0x10D8973: ff_snow_pred_block (snow.c:370)
==30657== by 0xC0E7DA: add_yblock (snow.h:345)
==30657== by 0xC0FE62: predict_slice_buffered (snowdec.c:78)
==30657== by 0xC12CAD: decode_frame (snowdec.c:602)
==30657== by 0x8BF99F: decode_simple_internal (decode.c:306)
==30657== by 0x8C0650: decode_simple_receive_frame (decode.c:514)
==30657== by 0x8C0756: decode_receive_frame_internal (decode.c:535)
==30657== by 0x8C0A17: avcodec_send_packet (decode.c:603)
==30657== by 0x25D6A5: decode (ffmpeg.c:2275)
==30657== by 0x25DE2C: decode_video (ffmpeg.c:2400)
==30657== by 0x25EEBC: process_input_packet (ffmpeg.c:2640)
==30657== by 0x266A1E: process_input (ffmpeg.c:4494)
==30657== by 0x266F12: transcode_step (ffmpeg.c:4634)
==30657== by 0x26707A: transcode (ffmpeg.c:4688)
==30657== by 0x267AEF: main (ffmpeg.c:4904)
==30657== Address 0x0 is not stack'd, malloc'd or (recently) free'd
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Elect your leaders based on what they did after the last election, not
based on what they say before an election.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-03-24 23:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 15:57 [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking Anton Khirnov
2022-03-23 15:57 ` [FFmpeg-devel] [PATCH 2/8] lavc/avcodec: only allocate the encoding frame for encoders Anton Khirnov
2022-03-23 16:29 ` James Almer
2022-04-11 8:39 ` [FFmpeg-devel] [PATCH] lavc/encode: drop EncodeSimpleContext Anton Khirnov
2022-04-11 9:16 ` Paul B Mahol
2022-04-11 16:32 ` James Almer
2022-03-23 15:57 ` [FFmpeg-devel] [PATCH 3/8] lavc: move default get_buffer2() to its own file Anton Khirnov
2022-03-23 15:57 ` [FFmpeg-devel] [PATCH 4/8] lavc/snow: only allocate mconly_picture for decoding Anton Khirnov
2022-03-24 23:07 ` Michael Niedermayer [this message]
2022-04-11 8:49 ` [FFmpeg-devel] [PATCH] " Anton Khirnov
2022-04-11 19:28 ` Michael Niedermayer
2022-04-13 10:21 ` Anton Khirnov
2022-03-23 15:57 ` [FFmpeg-devel] [PATCH 5/8] lavc/encode: add an encoder-specific get_buffer() variant Anton Khirnov
2022-03-23 16:26 ` James Almer
2022-04-11 9:05 ` [FFmpeg-devel] [PATCH] " Anton Khirnov
2022-03-23 15:57 ` [FFmpeg-devel] [PATCH 6/8] lavc/avcodec: only allocate decoding packets for decoders Anton Khirnov
2022-04-13 14:51 ` Andreas Rheinhardt
2022-03-23 15:57 ` [FFmpeg-devel] [PATCH 7/8] lavc/pthread_frame: do not copy AVCodecInternal contents Anton Khirnov
2022-03-23 15:57 ` [FFmpeg-devel] [PATCH 8/8] lavc: drop a confusing message about "thread emulation" Anton Khirnov
2022-04-13 10:23 ` [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking Anton Khirnov
2022-06-05 5:23 ` Soft Works
2022-06-05 7:01 ` Anton Khirnov
2022-06-05 7:54 ` Soft Works
2022-06-05 7:59 ` Soft Works
2022-06-05 8:20 ` Anton Khirnov
2022-06-05 8:55 ` Paul B Mahol
2022-06-05 8:55 ` Soft Works
2022-06-05 9:15 ` Soft Works
2022-06-05 10:42 ` Anton Khirnov
2022-06-05 10:55 ` Soft Works
2022-06-05 11:10 ` Soft Works
2022-06-05 13:20 ` Anton Khirnov
2022-06-05 14:06 ` Soft Works
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220324230738.GW2829255@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git