* [FFmpeg-devel] [PATCH v2] avcodec/libsvtav1: pass color description info
@ 2022-03-22 21:54 Jan Ekström
2022-03-23 12:57 ` James Almer
0 siblings, 1 reply; 3+ messages in thread
From: Jan Ekström @ 2022-03-22 21:54 UTC (permalink / raw)
To: ffmpeg-devel
From: Christopher Degawa <ccom@randomderp.com>
Signed-off-by: Christopher Degawa <ccom@randomderp.com>
---
libavcodec/libsvtav1.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
index f02e410f69..6cf280377e 100644
--- a/libavcodec/libsvtav1.c
+++ b/libavcodec/libsvtav1.c
@@ -228,6 +228,16 @@ static int config_enc_params(EbSvtAv1EncConfiguration *param,
return AVERROR(EINVAL);
}
+ param->color_primaries = avctx->color_primaries;
+ param->matrix_coefficients = (desc->flags & AV_PIX_FMT_FLAG_RGB) ?
+ AVCOL_SPC_RGB : avctx->colorspace;
+ param->transfer_characteristics = avctx->color_trc;
+
+ if (avctx->color_range != AVCOL_RANGE_UNSPECIFIED)
+ param->color_range = avctx->color_range == AVCOL_RANGE_JPEG;
+ else
+ param->color_range = !!(desc->flags & AV_PIX_FMT_FLAG_RGB);
+
if (avctx->profile != FF_PROFILE_UNKNOWN)
param->profile = avctx->profile;
--
2.35.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH v2] avcodec/libsvtav1: pass color description info
2022-03-22 21:54 [FFmpeg-devel] [PATCH v2] avcodec/libsvtav1: pass color description info Jan Ekström
@ 2022-03-23 12:57 ` James Almer
2022-03-23 14:29 ` Jan Ekström
0 siblings, 1 reply; 3+ messages in thread
From: James Almer @ 2022-03-23 12:57 UTC (permalink / raw)
To: ffmpeg-devel
On 3/22/2022 6:54 PM, Jan Ekström wrote:
> From: Christopher Degawa <ccom@randomderp.com>
>
> Signed-off-by: Christopher Degawa <ccom@randomderp.com>
> ---
> libavcodec/libsvtav1.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
> index f02e410f69..6cf280377e 100644
> --- a/libavcodec/libsvtav1.c
> +++ b/libavcodec/libsvtav1.c
> @@ -228,6 +228,16 @@ static int config_enc_params(EbSvtAv1EncConfiguration *param,
> return AVERROR(EINVAL);
> }
>
> + param->color_primaries = avctx->color_primaries;
> + param->matrix_coefficients = (desc->flags & AV_PIX_FMT_FLAG_RGB) ?
> + AVCOL_SPC_RGB : avctx->colorspace;
> + param->transfer_characteristics = avctx->color_trc;
> +
> + if (avctx->color_range != AVCOL_RANGE_UNSPECIFIED)
> + param->color_range = avctx->color_range == AVCOL_RANGE_JPEG;
> + else
> + param->color_range = !!(desc->flags & AV_PIX_FMT_FLAG_RGB);
> +
> if (avctx->profile != FF_PROFILE_UNKNOWN)
> param->profile = avctx->profile;
>
LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2] avcodec/libsvtav1: pass color description info
2022-03-23 12:57 ` James Almer
@ 2022-03-23 14:29 ` Jan Ekström
0 siblings, 0 replies; 3+ messages in thread
From: Jan Ekström @ 2022-03-23 14:29 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Wed, Mar 23, 2022 at 2:57 PM James Almer <jamrial@gmail.com> wrote:
>
> On 3/22/2022 6:54 PM, Jan Ekström wrote:
> > From: Christopher Degawa <ccom@randomderp.com>
> >
> > Signed-off-by: Christopher Degawa <ccom@randomderp.com>
> > ---
> > libavcodec/libsvtav1.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
> > index f02e410f69..6cf280377e 100644
> > --- a/libavcodec/libsvtav1.c
> > +++ b/libavcodec/libsvtav1.c
> > @@ -228,6 +228,16 @@ static int config_enc_params(EbSvtAv1EncConfiguration *param,
> > return AVERROR(EINVAL);
> > }
> >
> > + param->color_primaries = avctx->color_primaries;
> > + param->matrix_coefficients = (desc->flags & AV_PIX_FMT_FLAG_RGB) ?
> > + AVCOL_SPC_RGB : avctx->colorspace;
> > + param->transfer_characteristics = avctx->color_trc;
> > +
> > + if (avctx->color_range != AVCOL_RANGE_UNSPECIFIED)
> > + param->color_range = avctx->color_range == AVCOL_RANGE_JPEG;
> > + else
> > + param->color_range = !!(desc->flags & AV_PIX_FMT_FLAG_RGB);
> > +
> > if (avctx->profile != FF_PROFILE_UNKNOWN)
> > param->profile = avctx->profile;
> >
>
> LGTM
Thanks, applied as 51c0b9e829be99093ae8d1e642a8cf99896529b8 .
Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-23 14:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-22 21:54 [FFmpeg-devel] [PATCH v2] avcodec/libsvtav1: pass color description info Jan Ekström
2022-03-23 12:57 ` James Almer
2022-03-23 14:29 ` Jan Ekström
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git