From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B90B3426F0 for ; Tue, 22 Mar 2022 18:25:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1EEF368B007; Tue, 22 Mar 2022 20:25:23 +0200 (EET) Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1A7506802AC for ; Tue, 22 Mar 2022 20:25:17 +0200 (EET) Received: by mail-qt1-f172.google.com with SMTP id d15so14037167qty.8 for ; Tue, 22 Mar 2022 11:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=muxable.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ByilBfBzeyT/LrdNiHKC/RlJIsHZ4003WaNzSmhszd8=; b=C4Rx5hnicpN5reb1FQSfDG4ct0LmQZQK+UQY3pB6igZ60pxdHUUEgFTuTXXZlX25wi PprEMtAScHj1tZXogsBNbrGPJsehbcTMYN05S7uIOJJlX4VWsvAD1VAqtB1fv55DR9Go HTAGPrek4w8VMp2kdCyFmtkGiV4CLjlPuCLOfgf8W5zqmNxd0P+Nj7UOoDxJg18U2Qoq II/ibKbD8Rdd34C5YNlRo+bJ86V7sao2sWwTUQT3elpDG2xR9l5BfQpmFQjDcPaXqfok 72BNswqNPqigYOUNgOwRw/YDJ1NjF28tLSf6c+xEYlxRChi6sEvsHgejQgBeKJMQkae5 7oYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ByilBfBzeyT/LrdNiHKC/RlJIsHZ4003WaNzSmhszd8=; b=CB7GTOP6wtQaRUycIebpZuywenZzZZvCGDw5VvUC39+3+fSG8c/M08HmlzSJnRR+/U Z25vusxN2zriV2F6HP2vNtYP9E5Pw2fk++T6Fj4DFLtSoZ4ly13As65A4FjyQCeyG+H6 Go/IuyKl7sZUTKBmc4kIwRfp/tlL7aQiIRUK8afhR3tBHXUglg+zh6L7Zzjw+Hkc7wD4 gSwT1hbzCqBwg43nAlqweudH7cxQFTOqCU21XfF0jJ34otoLN8N4My1MCMYK5trfhUfm kM0Nc83GXD3kjmBMSU+78ydQRHPLakoc/sd1oj86TB3wWOGu+wLNuJQjFabLSAiaIJUl qWGw== X-Gm-Message-State: AOAM532hg14cAxhYZDdHajBQK8hXmKWm2Q2RVNoB54N/ML1lwWKayfNB 1yxRZU3tPEjWpHcSFcRXO0BaIv04zZZoXA+7G/0= X-Google-Smtp-Source: ABdhPJxQLniunIUqn7pJg2TGdixYybUgHnpnjGcrEES/3mQZRHH0twKFxnUkR+cIP4msWX+ezevPAQ== X-Received: by 2002:a05:622a:196:b0:2e0:705c:35b2 with SMTP id s22-20020a05622a019600b002e0705c35b2mr21354890qtw.567.1647973515371; Tue, 22 Mar 2022 11:25:15 -0700 (PDT) Received: from Chicago.localdomain (pool-96-224-216-37.nycmny.fios.verizon.net. [96.224.216.37]) by smtp.gmail.com with ESMTPSA id a13-20020a05622a064d00b002e1b8d9d6cfsm13653963qtb.32.2022.03.22.11.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Mar 2022 11:25:14 -0700 (PDT) From: kevin@muxable.com To: ffmpeg-devel@ffmpeg.org Date: Tue, 22 Mar 2022 14:25:11 -0400 Message-Id: <20220322182511.7747-1-kevin@muxable.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] rtpenc_vp8: Use 15-bit PictureIDs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: martin@martin.st, Kevin Wang , Kevin Wang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Kevin Wang 7-bit PictureIDs are not supported by WebRTC: https://groups.google.com/g/discuss-webrtc/c/333-L02vuWA In practice, 15-bit PictureIDs offer better compatibility. Signed-off-by: Kevin Wang --- libavformat/rtpenc_vp8.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/rtpenc_vp8.c b/libavformat/rtpenc_vp8.c index 671d245758..655d44517e 100644 --- a/libavformat/rtpenc_vp8.c +++ b/libavformat/rtpenc_vp8.c @@ -35,7 +35,8 @@ void ff_rtp_send_vp8(AVFormatContext *s1, const uint8_t *buf, int size) // partition id 0 *s->buf_ptr++ = 0x90; *s->buf_ptr++ = 0x80; // Picture id present - *s->buf_ptr++ = s->frame_count++ & 0x7f; + *s->buf_ptr++ = ((s->frame_count & 0x7f00) >> 8) | 0x80; + *s->buf_ptr++ = s->frame_count++ & 0xff; // Calculate the number of remaining bytes header_size = s->buf_ptr - s->buf; max_packet_size = s->max_payload_size - header_size; -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".