Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: kevin@muxable.com
To: ffmpeg-devel@ffmpeg.org
Cc: martin@martin.st, Kevin Wang <kevmo314@gmail.com>,
	Kevin Wang <kevin@muxable.com>
Subject: [FFmpeg-devel] [PATCH] rtpenc_vp8: Use 15-bit PictureIDs
Date: Tue, 22 Mar 2022 14:25:11 -0400
Message-ID: <20220322182511.7747-1-kevin@muxable.com> (raw)

From: Kevin Wang <kevmo314@gmail.com>

7-bit PictureIDs are not supported by WebRTC:
https://groups.google.com/g/discuss-webrtc/c/333-L02vuWA

In practice, 15-bit PictureIDs offer better compatibility.

Signed-off-by: Kevin Wang <kevin@muxable.com>
---
 libavformat/rtpenc_vp8.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavformat/rtpenc_vp8.c b/libavformat/rtpenc_vp8.c
index 671d245758..655d44517e 100644
--- a/libavformat/rtpenc_vp8.c
+++ b/libavformat/rtpenc_vp8.c
@@ -35,7 +35,8 @@ void ff_rtp_send_vp8(AVFormatContext *s1, const uint8_t *buf, int size)
     // partition id 0
     *s->buf_ptr++ = 0x90;
     *s->buf_ptr++ = 0x80; // Picture id present
-    *s->buf_ptr++ = s->frame_count++ & 0x7f;
+    *s->buf_ptr++ = ((s->frame_count & 0x7f00) >> 8) | 0x80;
+    *s->buf_ptr++ = s->frame_count++ & 0xff;
     // Calculate the number of remaining bytes
     header_size     = s->buf_ptr - s->buf;
     max_packet_size = s->max_payload_size - header_size;
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2022-03-22 18:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 18:25 kevin [this message]
2022-03-25  9:13 ` Kevin Wang
2022-03-25 10:18   ` "zhilizhao(赵志立)"
2022-03-25 22:43 ` Martin Storsjö

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220322182511.7747-1-kevin@muxable.com \
    --to=kevin@muxable.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=kevmo314@gmail.com \
    --cc=martin@martin.st \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git