From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0F6CD426C3 for ; Tue, 22 Mar 2022 14:32:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 17FC368B120; Tue, 22 Mar 2022 16:32:26 +0200 (EET) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1D50068B0B9 for ; Tue, 22 Mar 2022 16:32:20 +0200 (EET) Received: by mail-pf1-f180.google.com with SMTP id u22so6915776pfg.6 for ; Tue, 22 Mar 2022 07:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=onh+UB13GwZ/SvV2UZQ+HDkYLTziCmVjSz4ihXEz7JY=; b=OMBUwXQ3yJ7FAklHSwCA5RkBGkfdWChVHLkp/GaNPLJG7BYmZzfOmJWVeEFoAUH71d BgG7lhqCKczJtMcA8wKa/T8JFKcOgsUDE5EZDl/a9OXK85h4pKjvtT2BOio/fcYlox3J vWfDhOGV2J6xy6dEFQb90X2oGsORVAFSfjnII/8Wt+5J1XI2XsxG2yvcaOQXUs1XC7Vo hXgW/zmmUv8o+1V2ffhVrH7lsSnFt/0F45bT/oiVpnW/ZMXV1CVQEPBX2qfaOXhQma+C dE3/pYGSIHaEfgJWsAYmWcT1n/L/rPuhzCQd8zddNyaSbSS3Bdok+LMUW2vqs5Fx0fEr 57SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=onh+UB13GwZ/SvV2UZQ+HDkYLTziCmVjSz4ihXEz7JY=; b=SzlXOoVPgG1ZJt0ac5XiA7pCfa248nXKAF/M1n2aQwGwkjbUpeT+8QTy+pmoqwzV9w Estex2xocf87j7JOJoRrBBZaVpowuEv6NrV79Y78xfv5eodIHBpLkZOlMBiEIRS6jUVL fbRpktJpQrXdiYGFV/if3DMEwvyjPSsO3PO/wE3zeJVuw4uPlOLkgIb1lsLLsm3apiAL nTsz3aVwQziJRGZDK/PzVI4d8bS5+v4KbgfT1iWXhznD9jU6Gxz1qLzgSQ2U7aa4pkqR 8E7MJfBuU9e/iEQM2DxNnvBTXqJC5/LjZmznGWK0yUmfOB34EmQ3c9mS1dMTirp8GJpZ R/7Q== X-Gm-Message-State: AOAM531L/GycmmD5uD2Frc6r/4+BjP1CgrO5BFKC/DHGRzpoWbForZtk mhK4dxgU5MO3fTm5kLwgv0xsH3O3YRrRmg== X-Google-Smtp-Source: ABdhPJyaNNNQOQ54WA7oLaC+0fJ4Hp5hp+r5qG8XD4e2iJbwFANgUVBKzu6hkTrkYY9vPU9J+nwtiQ== X-Received: by 2002:a05:6a00:c8a:b0:4f7:a02d:2706 with SMTP id a10-20020a056a000c8a00b004f7a02d2706mr29848687pfv.32.1647959538087; Tue, 22 Mar 2022 07:32:18 -0700 (PDT) Received: from gmail.com ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id b7-20020a056a00114700b004f7be3231d6sm22983143pfm.7.2022.03.22.07.32.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Mar 2022 07:32:17 -0700 (PDT) Date: Tue, 22 Mar 2022 22:32:14 +0800 From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Message-ID: <20220322143214.GA19469@gmail.com> Mail-Followup-To: ffmpeg-devel@ffmpeg.org References: <1646229512-12103-1-git-send-email-lance.lmwang@gmail.com> <20220311135854.GA24038@gmail.com> <20220311155851.GA9443@gmail.com> <20220322123756.GA12953@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: initialize pts/dts/duration of timecode packet X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Mar 22, 2022 at 02:28:10PM +0100, Andreas Rheinhardt wrote: > lance.lmwang@gmail.com: > > On Fri, Mar 11, 2022 at 05:16:09PM +0100, Andreas Rheinhardt wrote: > >> lance.lmwang@gmail.com: > >>> On Fri, Mar 11, 2022 at 03:04:32PM +0100, Andreas Rheinhardt wrote: > >>>> lance.lmwang@gmail.com: > >>>>> On Wed, Mar 02, 2022 at 09:58:31PM +0800, lance.lmwang@gmail.com wrote: > >>>>>> From: Limin Wang > >>>>>> > >>>>>> Fix below error message when timecode packet is written. > >>>>>> "Application provided duration: -9223372036854775808 / timestamp: -9223372036854775808 is out of range for mov/mp4 format" > >>>>>> > >>>>>> try to reproduce by: > >>>>>> ffmpeg -y -f lavfi -i color -metadata "timecode=00:00:00:00" -t 1 test.mov > >>>>>> > >>>>>> Note although error message is printed, the timecode packet will be written anyway. So > >>>>>> the patch 2/2 will try to change the log level to warning. > >>>>>> > >>>>>> The first two test case of fate-lavf-ismv have timecode setting, so the crc of ref data is different. > >>>>>> Fixes ticket #9488 > >>>>>> > >>>>>> Signed-off-by: Limin Wang > >>>>>> --- > >>>>>> libavformat/movenc.c | 2 ++ > >>>>>> tests/ref/lavf/ismv | 4 ++-- > >>>>>> 2 files changed, 4 insertions(+), 2 deletions(-) > >>>>>> > >>>>>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c > >>>>>> index 4c86891..74b94cd 100644 > >>>>>> --- a/libavformat/movenc.c > >>>>>> +++ b/libavformat/movenc.c > >>>>>> @@ -6383,6 +6383,8 @@ static int mov_create_timecode_track(AVFormatContext *s, int index, int src_inde > >>>>>> pkt->data = data; > >>>>>> pkt->stream_index = index; > >>>>>> pkt->flags = AV_PKT_FLAG_KEY; > >>>>>> + pkt->pts = pkt->dts = av_rescale_q(tc.start, av_inv_q(rate), (AVRational){1,mov->movie_timescale}); > >>>>>> + pkt->duration = av_rescale_q(1, av_inv_q(rate), (AVRational){1,mov->movie_timescale}); > >>>>>> pkt->size = 4; > >>>>>> AV_WB32(pkt->data, tc.start); > >>>>>> ret = ff_mov_write_packet(s, pkt); > >>>>>> diff --git a/tests/ref/lavf/ismv b/tests/ref/lavf/ismv > >>>>>> index ac7f72b..723b432 100644 > >>>>>> --- a/tests/ref/lavf/ismv > >>>>>> +++ b/tests/ref/lavf/ismv > >>>>>> @@ -1,7 +1,7 @@ > >>>>>> -48fb8d7a5d19bd60f3a49ccf4b7d6593 *tests/data/lavf/lavf.ismv > >>>>>> +7a24b73c096ec0f13f0f7a2d9101c4c1 *tests/data/lavf/lavf.ismv > >>>>>> 313169 tests/data/lavf/lavf.ismv > >>>>>> tests/data/lavf/lavf.ismv CRC=0x9d9a638a > >>>>>> -d19cd8e310a2e94fe0a0d11c5dc29217 *tests/data/lavf/lavf.ismv > >>>>>> +79646383fd099d45ad0d0c2791c601dd *tests/data/lavf/lavf.ismv > >>>>>> 322075 tests/data/lavf/lavf.ismv > >>>>>> tests/data/lavf/lavf.ismv CRC=0xe8130120 > >>>>>> 3b6023766845b51b075aed474c00f73c *tests/data/lavf/lavf.ismv > >>>>>> -- > >>>>>> 1.8.3.1 > >>>>>> > >>>>> > >>>>> will apply the patch set tomorrow unless there are any objections. > >>>>> > >>>> > >>>> You have not really answered whether the current files or the new files > >>>> are spec-incompliant; you have just reported that one byte is different. > >>> > >>> Sorry, I think I have said both current and new file is spec-compliant in the last > >>> email. > >>> > >> > >> You stated that you think that both files are valid, but you also said > >> that you don't even know what this byte that is different actually means. > >> > >>> By Quicktime file format specs: > >>> Section Timecode Sample Description, all tmcd field isn't used pts/dts. > >>> > >>> As for where is the different for one byte, it's caused by pkt->duration. The > >>> old is 0(uninitialized), after the patch it's 33(1 frame duration). > >>> > >> > >> The text about Timecode Sample Description reads as follows: "Frame > >> duration: A 32-bit integer that indicates how long each frame lasts in > >> real time." This implies that only one of the two files can be > >> spec-compliant. I am not a mov/ISOBMFF expert, but it seems to me that > >> the current way of doing things is wrong. But I wonder about whether > >> your patch is correct for vfr content. Doesn't the property of being vfr > >> need to be reflected in the timecodes somehow (with different durations > >> for different packets)? > > > > Andreas, I have updated the patch and remove the fate difference which is > > caused by duration, do you have any other comments for v2 patch? > > > > No. Thanks, then will apply the v2 patchsetet. > > - Andreas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".