From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 71FC04269E for ; Tue, 22 Mar 2022 12:38:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B20CD68B16B; Tue, 22 Mar 2022 14:38:09 +0200 (EET) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2E35868A351 for ; Tue, 22 Mar 2022 14:38:03 +0200 (EET) Received: by mail-pj1-f50.google.com with SMTP id bx24-20020a17090af49800b001c6872a9e4eso2030454pjb.5 for ; Tue, 22 Mar 2022 05:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=BIZTjgU5a5KP3pWP3DO4e6RJGgKp9Gg4ea6ons/e3u4=; b=V8JKr9fuqvpO3YWc3rFc8Prl98XASTNzWGvGKSIUh5Y5EeP0qdFB9vHJh/mmC2nyX5 UO36LHOWgQBZo7U28/5CoiPd+HCJ8qBYQ19gyGI1MzZflmBZRqvCAlVDDmZiX7IyUMvi udFCL6gsuD3te+TBMstbSOf90UC1H4Z5hW0Nw/yT6hWBTkB9KVDnIEoTS6FcgovppjFV /SOJwTinr4qxXFOl7p8mlCDmpZ0vy10uJniyE11Gkow8cMvPd+GtxTdtrL4CU4Y8qWSB zFa0pBq0ecEZAt7bUixgBJzWzss/ITGoCRnpzozU/d4KVvHpxI/xnUK/iYGurL94cFAO 9ykw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=BIZTjgU5a5KP3pWP3DO4e6RJGgKp9Gg4ea6ons/e3u4=; b=5owG1BPtolJv9Rm21+DrV+JIETQR6+H3Gv1NVEZskbEOK3sBgbmljEoh1yYjVlYzqr ZdE+QXJ3xqGl+3k7CulGfzJEEgqWGNn2hFas2f4qpRWsZ5/7kvFLRhx4WOjvevVOP6tg 5mD1CZA/22zL0LBKH3e785PG63j0k2tmFc4rT41vqxQmzeY+fOVDvaw52yaIbT40Jo12 cORk8ST/EdU8v+JuSS9CX1LYD3GqEKecCpanKPljkYRdJNVWt7MJwBQsgB8oMKEjCh5L 4d24/X7paz6jZerxcYQhGU4fqt6cWvjKsFPML4oKD3x9LYUhq3GWB661YOziczIKD9ek AFTA== X-Gm-Message-State: AOAM530lwdph3cUaz6agjRulzRVEDBESJckuh8H8aUJWuiwJDFGNlWth AJoTdBpjZHxEW50ZjfWC/7vrz0hkq6vhsg== X-Google-Smtp-Source: ABdhPJxUS25WemMvytSXQPdKtPD9Wu9QR4oACSYeknV/iwiQ35myEILDbFXieBjHpibYjnnGfaB93g== X-Received: by 2002:a17:903:32c7:b0:154:19dd:fd43 with SMTP id i7-20020a17090332c700b0015419ddfd43mr18561712plr.150.1647952680371; Tue, 22 Mar 2022 05:38:00 -0700 (PDT) Received: from gmail.com ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id f13-20020a056a001acd00b004f76d35c1dcsm22527197pfv.104.2022.03.22.05.37.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Mar 2022 05:37:59 -0700 (PDT) Date: Tue, 22 Mar 2022 20:37:56 +0800 From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Message-ID: <20220322123756.GA12953@gmail.com> Mail-Followup-To: ffmpeg-devel@ffmpeg.org References: <1646229512-12103-1-git-send-email-lance.lmwang@gmail.com> <20220311135854.GA24038@gmail.com> <20220311155851.GA9443@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: initialize pts/dts/duration of timecode packet X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, Mar 11, 2022 at 05:16:09PM +0100, Andreas Rheinhardt wrote: > lance.lmwang@gmail.com: > > On Fri, Mar 11, 2022 at 03:04:32PM +0100, Andreas Rheinhardt wrote: > >> lance.lmwang@gmail.com: > >>> On Wed, Mar 02, 2022 at 09:58:31PM +0800, lance.lmwang@gmail.com wrote: > >>>> From: Limin Wang > >>>> > >>>> Fix below error message when timecode packet is written. > >>>> "Application provided duration: -9223372036854775808 / timestamp: -9223372036854775808 is out of range for mov/mp4 format" > >>>> > >>>> try to reproduce by: > >>>> ffmpeg -y -f lavfi -i color -metadata "timecode=00:00:00:00" -t 1 test.mov > >>>> > >>>> Note although error message is printed, the timecode packet will be written anyway. So > >>>> the patch 2/2 will try to change the log level to warning. > >>>> > >>>> The first two test case of fate-lavf-ismv have timecode setting, so the crc of ref data is different. > >>>> Fixes ticket #9488 > >>>> > >>>> Signed-off-by: Limin Wang > >>>> --- > >>>> libavformat/movenc.c | 2 ++ > >>>> tests/ref/lavf/ismv | 4 ++-- > >>>> 2 files changed, 4 insertions(+), 2 deletions(-) > >>>> > >>>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c > >>>> index 4c86891..74b94cd 100644 > >>>> --- a/libavformat/movenc.c > >>>> +++ b/libavformat/movenc.c > >>>> @@ -6383,6 +6383,8 @@ static int mov_create_timecode_track(AVFormatContext *s, int index, int src_inde > >>>> pkt->data = data; > >>>> pkt->stream_index = index; > >>>> pkt->flags = AV_PKT_FLAG_KEY; > >>>> + pkt->pts = pkt->dts = av_rescale_q(tc.start, av_inv_q(rate), (AVRational){1,mov->movie_timescale}); > >>>> + pkt->duration = av_rescale_q(1, av_inv_q(rate), (AVRational){1,mov->movie_timescale}); > >>>> pkt->size = 4; > >>>> AV_WB32(pkt->data, tc.start); > >>>> ret = ff_mov_write_packet(s, pkt); > >>>> diff --git a/tests/ref/lavf/ismv b/tests/ref/lavf/ismv > >>>> index ac7f72b..723b432 100644 > >>>> --- a/tests/ref/lavf/ismv > >>>> +++ b/tests/ref/lavf/ismv > >>>> @@ -1,7 +1,7 @@ > >>>> -48fb8d7a5d19bd60f3a49ccf4b7d6593 *tests/data/lavf/lavf.ismv > >>>> +7a24b73c096ec0f13f0f7a2d9101c4c1 *tests/data/lavf/lavf.ismv > >>>> 313169 tests/data/lavf/lavf.ismv > >>>> tests/data/lavf/lavf.ismv CRC=0x9d9a638a > >>>> -d19cd8e310a2e94fe0a0d11c5dc29217 *tests/data/lavf/lavf.ismv > >>>> +79646383fd099d45ad0d0c2791c601dd *tests/data/lavf/lavf.ismv > >>>> 322075 tests/data/lavf/lavf.ismv > >>>> tests/data/lavf/lavf.ismv CRC=0xe8130120 > >>>> 3b6023766845b51b075aed474c00f73c *tests/data/lavf/lavf.ismv > >>>> -- > >>>> 1.8.3.1 > >>>> > >>> > >>> will apply the patch set tomorrow unless there are any objections. > >>> > >> > >> You have not really answered whether the current files or the new files > >> are spec-incompliant; you have just reported that one byte is different. > > > > Sorry, I think I have said both current and new file is spec-compliant in the last > > email. > > > > You stated that you think that both files are valid, but you also said > that you don't even know what this byte that is different actually means. > > > By Quicktime file format specs: > > Section Timecode Sample Description, all tmcd field isn't used pts/dts. > > > > As for where is the different for one byte, it's caused by pkt->duration. The > > old is 0(uninitialized), after the patch it's 33(1 frame duration). > > > > The text about Timecode Sample Description reads as follows: "Frame > duration: A 32-bit integer that indicates how long each frame lasts in > real time." This implies that only one of the two files can be > spec-compliant. I am not a mov/ISOBMFF expert, but it seems to me that > the current way of doing things is wrong. But I wonder about whether > your patch is correct for vfr content. Doesn't the property of being vfr > need to be reflected in the timecodes somehow (with different durations > for different packets)? Andreas, I have updated the patch and remove the fate difference which is caused by duration, do you have any other comments for v2 patch? > > - Andreas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".