From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E1DE142543 for ; Fri, 18 Mar 2022 13:32:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6145A68B11E; Fri, 18 Mar 2022 15:32:05 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ACE9068807F for ; Fri, 18 Mar 2022 15:31:58 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 0022C60014 for ; Fri, 18 Mar 2022 13:31:57 +0000 (UTC) Date: Fri, 18 Mar 2022 14:31:57 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220318133157.GV2829255@pb2> References: <20220318131316.GU2829255@pb2> MIME-Version: 1.0 In-Reply-To: <20220318131316.GU2829255@pb2> Subject: Re: [FFmpeg-devel] [PATCH 8/8] avcodec/codec_internal: Include codec_tags only when they are needed X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6679478113142766454==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6679478113142766454== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7t8rTQ7xfR7RQuTs" Content-Disposition: inline --7t8rTQ7xfR7RQuTs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 18, 2022 at 02:13:16PM +0100, Michael Niedermayer wrote: > On Fri, Mar 18, 2022 at 11:52:54AM +0100, Andreas Rheinhardt wrote: > > They are only needed for the fuzzer, so check for CONFIG_OSSFUZZ. > > This decreases sizeof(FFCodec), which is important given that > > FFCodecs reside in .data.rel.ro in case of ELF with > > position-independent code which is always loaded and can't be shared > > between processes. > >=20 >=20 > They are currently only used by the fuzzer, if there is no other > use, iam not sure. But i agree shareable memory would be better for them >=20 >=20 > [...] > > diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c > > index 288aa63313..77f4bb8dd8 100644 > > --- a/tools/target_dec_fuzzer.c > > +++ b/tools/target_dec_fuzzer.c > > @@ -279,12 +279,14 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, s= ize_t size) { > > ctx->sample_rate =3D bytestream2_get_le= 32(&gbc) & 0x7FFFFFFF; > > ctx->ch_layout.nb_channels =3D (unsigned)bytestre= am2_get_le32(&gbc) % FF_SANE_NB_CHANNELS; > > ctx->block_align =3D bytestream2_get_le= 32(&gbc) & 0x7FFFFFFF; > > +#if CONFIG_OSSFUZZ > > ctx->codec_tag =3D bytestream2_get_le= 32(&gbc); > > if (c->codec_tags) { > > int n; > > for (n =3D 0; c->codec_tags[n] !=3D FF_CODEC_TAGS_END; n++= ); > > ctx->codec_tag =3D c->codec_tags[ctx->codec_tag % n]; > > } > > +#endif > > keyframes =3D bytestream2_get_le= 64(&gbc); > > request_channel_layout =3D bytestream2_get_le= 64(&gbc); > > =20 >=20 > how does the fuzzer work without the fuzzer ? or is the idea to build test this even without oss-fuzz somehow? [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The greatest way to live with honor in this world is to be what we pretend to be. -- Socrates --7t8rTQ7xfR7RQuTs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYjSJyQAKCRBhHseHBAsP q1X1AKCQ002W4cYA+FaFTdtjFmY7dShPiACgi4uD5If6jQgatnIYmu2yPfMsZhM= =WtfV -----END PGP SIGNATURE----- --7t8rTQ7xfR7RQuTs-- --===============6679478113142766454== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6679478113142766454==--