From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4ED73424F8 for ; Thu, 17 Mar 2022 19:39:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ABA1168AF71; Thu, 17 Mar 2022 21:39:27 +0200 (EET) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 43C0668AB9D for ; Thu, 17 Mar 2022 21:39:21 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 616AD20002 for ; Thu, 17 Mar 2022 19:39:20 +0000 (UTC) Date: Thu, 17 Mar 2022 20:39:18 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220317193918.GQ2829255@pb2> References: <20220124204656.48625-1-jamrial@gmail.com> <20220316004108.GH2829255@pb2> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 001/293 v8] avutil/channel_layout: Add a new channel layout API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7935714210264548237==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7935714210264548237== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kiGXszhagpA7Usld" Content-Disposition: inline --kiGXszhagpA7Usld Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 15, 2022 at 11:00:02PM -0300, James Almer wrote: > On 3/15/2022 9:41 PM, Michael Niedermayer wrote: > > On Mon, Jan 24, 2022 at 05:46:56PM -0300, James Almer wrote: > > > From: Anton Khirnov > > >=20 > > > The new API is more extensible and allows for custom layouts. > > > More accurate information is exported, eg for decoders that do not > > > set a channel layout, lavc will not make one up for them. > > >=20 > > > Deprecate the old API working with just uint64_t bitmasks. > > >=20 > > > Expanded and completed by Vittorio Giovara > > > and James Almer . > > > Signed-off-by: Vittorio Giovara > > > Signed-off-by: James Almer > > > --- > > > Changes since last version: > > >=20 > > > *Both av_channel_layout_describe() and av_channel_layout_from_string(= ) now > > > support a "2 channels (FL+LFE)" syntax, to signal native (usually > > > non-standard) or custom order layouts. > > > *a single decimal value is now interpreted as a mask by > > > av_channel_layout_from_string(), same as a single hexadecimal value. > > > *De-duplicated code by simplifying av_channel_layout_channel_from_str= ing(). > > >=20 > > > The entire set can still be found in > > > https://github.com/jamrial/FFmpeg/commits/channel_layout4 > > >=20 > > > libavutil/channel_layout.c | 661 +++++++++++++++++++++++++++++++++-= --- > > > libavutil/channel_layout.h | 551 +++++++++++++++++++++++++++++-- > > > libavutil/version.h | 1 + > > > 3 files changed, 1110 insertions(+), 103 deletions(-) > >=20 > > didnt bisect but > >=20 > > this > > ./ffmpeg -i ~/tickets/3542/out.mov -channel_layout stereo -acodec pcm_s= 16be file.mov > > fails after the patchset but not before > >=20 > > [graph_0_in_0_0 @ 0x5642d659ec40] filter context - fmt: s16 r: 44100 la= yout: 3 ch: 2, incoming frame - fmt: s16 r: 44100 layout: 60000000 ch: 2 pt= s_time: 0 > > [graph_0_in_0_0 @ 0x5642d659ec40] Changing audio frame properties on th= e fly is not supported. > > Error while filtering: Invalid argument > > Failed to inject frame into filter network: Invalid argument > > Error while processing the decoded data for stream #0:0 > > Conversion failed! >=20 > Should be fixed. Heres another which broke around the channel change =2E/ffmpeg -i tickets//2064/mus_sympathy_for_the_devil_l.wav file.wav "tickets//2064/mus_sympathy_for_the_devil_l.wav: Function not implemented" file seems here: https://www.djxmmx.net/ffmpeg/2064/ [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in capitalist society always remains about the same as it was in ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin --kiGXszhagpA7Usld Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYjOOYwAKCRBhHseHBAsP q0YbAJ9UPcIc+W17UzzISEGVsed0HImw1ACfalU1OWbelJACkRqRYrOp7BeEl68= =5NV1 -----END PGP SIGNATURE----- --kiGXszhagpA7Usld-- --===============7935714210264548237== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7935714210264548237==--