From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1558342441 for ; Wed, 16 Mar 2022 00:44:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DCCF868B075; Wed, 16 Mar 2022 02:44:18 +0200 (EET) Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CF52968AEAE for ; Wed, 16 Mar 2022 02:44:12 +0200 (EET) Received: from relay6-d.mail.gandi.net (unknown [217.70.183.198]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 3CC06CB43D for ; Wed, 16 Mar 2022 00:41:16 +0000 (UTC) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 3DFBEC0005 for ; Wed, 16 Mar 2022 00:41:09 +0000 (UTC) Date: Wed, 16 Mar 2022 01:41:08 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220316004108.GH2829255@pb2> References: <20220124204656.48625-1-jamrial@gmail.com> MIME-Version: 1.0 In-Reply-To: <20220124204656.48625-1-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 001/293 v8] avutil/channel_layout: Add a new channel layout API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6230057869987589803==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6230057869987589803== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bkpCgR1SUWIWyUG3" Content-Disposition: inline --bkpCgR1SUWIWyUG3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 24, 2022 at 05:46:56PM -0300, James Almer wrote: > From: Anton Khirnov >=20 > The new API is more extensible and allows for custom layouts. > More accurate information is exported, eg for decoders that do not > set a channel layout, lavc will not make one up for them. >=20 > Deprecate the old API working with just uint64_t bitmasks. >=20 > Expanded and completed by Vittorio Giovara > and James Almer . > Signed-off-by: Vittorio Giovara > Signed-off-by: James Almer > --- > Changes since last version: >=20 > *Both av_channel_layout_describe() and av_channel_layout_from_string() now > support a "2 channels (FL+LFE)" syntax, to signal native (usually > non-standard) or custom order layouts. > *a single decimal value is now interpreted as a mask by > av_channel_layout_from_string(), same as a single hexadecimal value. > *De-duplicated code by simplifying av_channel_layout_channel_from_string(= ). >=20 > The entire set can still be found in > https://github.com/jamrial/FFmpeg/commits/channel_layout4 >=20 > libavutil/channel_layout.c | 661 +++++++++++++++++++++++++++++++++---- > libavutil/channel_layout.h | 551 +++++++++++++++++++++++++++++-- > libavutil/version.h | 1 + > 3 files changed, 1110 insertions(+), 103 deletions(-) didnt bisect but this =2E/ffmpeg -i ~/tickets/3542/out.mov -channel_layout stereo -acodec pcm_s16= be file.mov fails after the patchset but not before [graph_0_in_0_0 @ 0x5642d659ec40] filter context - fmt: s16 r: 44100 layout= : 3 ch: 2, incoming frame - fmt: s16 r: 44100 layout: 60000000 ch: 2 pts_ti= me: 0 [graph_0_in_0_0 @ 0x5642d659ec40] Changing audio frame properties on the fl= y is not supported. Error while filtering: Invalid argument Failed to inject frame into filter network: Invalid argument Error while processing the decoded data for stream #0:0 Conversion failed! [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstanding go out to meet it. -- Thucydides --bkpCgR1SUWIWyUG3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYjEyJAAKCRBhHseHBAsP qzKeAJ9shnahSoZXiLyO+KWtSb7utXDU5gCghctqqx2TDXbm3DwxqVHfgA3pnsg= =YZS2 -----END PGP SIGNATURE----- --bkpCgR1SUWIWyUG3-- --===============6230057869987589803== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6230057869987589803==--