From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 23CC540EF2 for ; Sat, 12 Mar 2022 18:09:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4899768B137; Sat, 12 Mar 2022 20:09:14 +0200 (EET) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 51B7E68A7ED for ; Sat, 12 Mar 2022 20:09:07 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 70354100002 for ; Sat, 12 Mar 2022 18:09:06 +0000 (UTC) Date: Sat, 12 Mar 2022 19:09:05 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220312180905.GV2829255@pb2> References: <20220309181819.22709-1-michael@niedermayer.cc> <9f977790-8d18-c4e7-18b9-b4ae2604e318@noa-archive.com> <68221FD8-0816-4971-808D-D54BCBDD35EC@dericed.com> MIME-Version: 1.0 In-Reply-To: <68221FD8-0816-4971-808D-D54BCBDD35EC@dericed.com> Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec: Add dv marker bsf X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7745026138273275673==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7745026138273275673== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LKoXG3iAimKZKCFl" Content-Disposition: inline --LKoXG3iAimKZKCFl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 12, 2022 at 10:11:52AM -0500, Dave Rice wrote: >=20 >=20 > > On Mar 10, 2022, at 4:41 AM, Tobias Rapp wrote: > >=20 > > On 09/03/2022 19:18, Michael Niedermayer wrote: > >> Signed-off-by: Michael Niedermayer > >> --- > >> doc/bitstream_filters.texi | 30 ++++++++ > >> libavcodec/Makefile | 1 + > >> libavcodec/bitstream_filters.c | 1 + > >> libavcodec/dv_error_marker_bsf.c | 127 +++++++++++++++++++++++++++++++ > >> 4 files changed, 159 insertions(+) > >> create mode 100644 libavcodec/dv_error_marker_bsf.c > >> diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi > >> index a0092878c8..8c5d84dceb 100644 > >> --- a/doc/bitstream_filters.texi > >> +++ b/doc/bitstream_filters.texi > >> @@ -132,6 +132,36 @@ the header stored in extradata to the key packets: > >> ffmpeg -i INPUT -map 0 -flags:v +global_header -c:v libx264 -bsf:v du= mp_extra out.ts > >> @end example > >> +@section dv_error_marker > >> + > >> +Blocks in DV which are marked as damaged are replaced by blocks of th= e specified color. > >> + > >> +@table @option > >> +@item color > >> +The color to replace damaged blocks by > >> +@item sta > >> +A 16 bit mask which specifies which of the 16 possible error status v= alues are > >> +to be replaced by colored blocks. 0xFFFE is the default which replace= s all non 0 > >> +error status values. > >> +@table @samp > >> +@item ok > >> +No error, no concealment > >> +@item err > >> +Error, No concealment > >> +@item res > >> +Reserved > >> +@item notok > >> +Error or concealment > >> +@item notres > >> +Not reserved > >> +@item Aa, Ba, Ca, Ab, Bb, Cb, A, B, C, a, b, erri, erru > >> +The specific error status code > >> +@end table > >> +see page 44-46 or section 5.5 of > >> +@url{http://web.archive.org/web/20060927044735/http://www.smpte.org/s= mpte_store/standards/pdf/s314m.pdf} > >> + > >> +@end table > >> + > >> @section eac3_core > >> [...] > > The filter options look nice to me now. Have not actually tested the bi= tstream filter on DV files, though. >=20 > I tested this and this works well for me. Here's a few samples that demon= strate the filter: >=20 > ./ffmpeg -i https://samples.ffmpeg.org/archive/audio/pcm_s16le/dv+dvvideo= +pcm_s16le++dropout.dv -bsf dv_error_marker=3Dsta=3Db -f rawvideo -c:v cop= y - | ffplay - > ./ffmpeg -i https://archive.org/download/DvAnalyzerSampleDvVideoErrorConc= ealment/DV_Analyzer_Sample_Video_Error_Concealment_original.dv -bsf dv_erro= r_marker=3Dsta=3Db -f rawvideo -c:v copy - | ffplay - I tested a bit more and it failed with dvcprohd, i have fixed it and will i= n a moment post a version that seems to work with both please retest PS: i used some artificially damaged files from fate/dv/ thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Good people do not need laws to tell them to act responsibly, while bad people will find a way around the laws. -- Plato --LKoXG3iAimKZKCFl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYizhvQAKCRBhHseHBAsP q8+9AJ9DybOJYILzFyXdpZ9VGka9xVyGpgCfX/BeLXcYz1xr4VfrqyC0lkDwkv0= =bz3D -----END PGP SIGNATURE----- --LKoXG3iAimKZKCFl-- --===============7745026138273275673== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7745026138273275673==--