From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C601E40D99 for ; Sat, 12 Mar 2022 00:07:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6587A68B155; Sat, 12 Mar 2022 02:07:36 +0200 (EET) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5440368A7B8 for ; Sat, 12 Mar 2022 02:07:28 +0200 (EET) Received: by mail-pg1-f182.google.com with SMTP id bc27so8736386pgb.4 for ; Fri, 11 Mar 2022 16:07:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=tXm73gnRRNeOfrJtQxclWbQBBvkCkRALnGy5WxKVGxU=; b=R7VCvmUV/FuYtNGAxUVx2wZVKj/41lSnwOPzhsccB8xPZmTrzD/Y/fKjSnhjGReZiF xhApCgQiAfwM8Fr0gWx0WXsdkVW/RSeWsAPVs6RGJO3Vrsy+q+19JYG9sRciGSw+d0Ah TiJ6tYhInsPFP3/IOjXiVFkkwRB0vvJdJhOoIxbnOTthvNmHxkpCfm8MyrRgrT8BfeVY nxK3OFmH+ubeKO84TQybcrR3jp8uMuGCLftncIz6tJPJMPUUvpRAgs1VYvb01yYGHqqA aA8Rmm6MAoh5KCI99+pOcSkijPPjMldDUBpbyy6yqel14WjXQ4Jq8YQfKnE9WPzkmK6z VHVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=tXm73gnRRNeOfrJtQxclWbQBBvkCkRALnGy5WxKVGxU=; b=mueFr1HNbO2qdlADO85OF9kD3CP/GFS5iV2fP4nJynIO6bZIFfdzok8jg6aWgoUU2Q rC7vHHNpN87APXbEjUg9uJ9F/p2Zyu/RC1X7MBUXzzrX3cLsc0Ut3ArqoFX7DADV+YVy s496XN8yCCYrsd3D0ch1WKiZc+GxOD8ZibNtgz4rtXd6L7tNMDmHHGFnbE5ha0Nv0b4e QItiObhh1U3MVKHaZoWHKL41huRUw6pb4UBZYQHrn3Qo7HgzNLPM5uDZBAYcDhIagt/n hzUEK5v5d9x9FLXpn/eigKVv0tMd0jLiGGihyncFS4mWLp3pEIeJvBkQQIfliyIUK/cT Cy1g== X-Gm-Message-State: AOAM533/dyWTv0b/GJphB4Iz5NW7ySw2huiyJ5LdU/Gad/BGzDFkkdrl Wi9hUye7lJ9T136rB/1uUbFBm8JlYNYn3w== X-Google-Smtp-Source: ABdhPJwwdL5BGtwhuXqpWQtFvP3PqaVH7KR/r860U2xPdM4dcyeymzfRhRfAlXEZFjxzlBS5q+6cvw== X-Received: by 2002:a05:6a00:130e:b0:4f3:9654:266d with SMTP id j14-20020a056a00130e00b004f39654266dmr12586439pfu.59.1647043645614; Fri, 11 Mar 2022 16:07:25 -0800 (PST) Received: from gmail.com ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id z23-20020a056a001d9700b004f6d2974269sm10383418pfw.113.2022.03.11.16.07.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Mar 2022 16:07:25 -0800 (PST) Date: Sat, 12 Mar 2022 08:07:22 +0800 From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Message-ID: <20220312000722.GA15048@gmail.com> Mail-Followup-To: ffmpeg-devel@ffmpeg.org References: <1646229512-12103-1-git-send-email-lance.lmwang@gmail.com> <20220311135854.GA24038@gmail.com> <20220311155851.GA9443@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: initialize pts/dts/duration of timecode packet X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, Mar 11, 2022 at 05:16:09PM +0100, Andreas Rheinhardt wrote: > lance.lmwang@gmail.com: > > On Fri, Mar 11, 2022 at 03:04:32PM +0100, Andreas Rheinhardt wrote: > >> lance.lmwang@gmail.com: > >>> On Wed, Mar 02, 2022 at 09:58:31PM +0800, lance.lmwang@gmail.com wrote: > >>>> From: Limin Wang > >>>> > >>>> Fix below error message when timecode packet is written. > >>>> "Application provided duration: -9223372036854775808 / timestamp: -9223372036854775808 is out of range for mov/mp4 format" > >>>> > >>>> try to reproduce by: > >>>> ffmpeg -y -f lavfi -i color -metadata "timecode=00:00:00:00" -t 1 test.mov > >>>> > >>>> Note although error message is printed, the timecode packet will be written anyway. So > >>>> the patch 2/2 will try to change the log level to warning. > >>>> > >>>> The first two test case of fate-lavf-ismv have timecode setting, so the crc of ref data is different. > >>>> Fixes ticket #9488 > >>>> > >>>> Signed-off-by: Limin Wang > >>>> --- > >>>> libavformat/movenc.c | 2 ++ > >>>> tests/ref/lavf/ismv | 4 ++-- > >>>> 2 files changed, 4 insertions(+), 2 deletions(-) > >>>> > >>>> diff --git a/libavformat/movenc.c b/libavformat/movenc.c > >>>> index 4c86891..74b94cd 100644 > >>>> --- a/libavformat/movenc.c > >>>> +++ b/libavformat/movenc.c > >>>> @@ -6383,6 +6383,8 @@ static int mov_create_timecode_track(AVFormatContext *s, int index, int src_inde > >>>> pkt->data = data; > >>>> pkt->stream_index = index; > >>>> pkt->flags = AV_PKT_FLAG_KEY; > >>>> + pkt->pts = pkt->dts = av_rescale_q(tc.start, av_inv_q(rate), (AVRational){1,mov->movie_timescale}); > >>>> + pkt->duration = av_rescale_q(1, av_inv_q(rate), (AVRational){1,mov->movie_timescale}); > >>>> pkt->size = 4; > >>>> AV_WB32(pkt->data, tc.start); > >>>> ret = ff_mov_write_packet(s, pkt); > >>>> diff --git a/tests/ref/lavf/ismv b/tests/ref/lavf/ismv > >>>> index ac7f72b..723b432 100644 > >>>> --- a/tests/ref/lavf/ismv > >>>> +++ b/tests/ref/lavf/ismv > >>>> @@ -1,7 +1,7 @@ > >>>> -48fb8d7a5d19bd60f3a49ccf4b7d6593 *tests/data/lavf/lavf.ismv > >>>> +7a24b73c096ec0f13f0f7a2d9101c4c1 *tests/data/lavf/lavf.ismv > >>>> 313169 tests/data/lavf/lavf.ismv > >>>> tests/data/lavf/lavf.ismv CRC=0x9d9a638a > >>>> -d19cd8e310a2e94fe0a0d11c5dc29217 *tests/data/lavf/lavf.ismv > >>>> +79646383fd099d45ad0d0c2791c601dd *tests/data/lavf/lavf.ismv > >>>> 322075 tests/data/lavf/lavf.ismv > >>>> tests/data/lavf/lavf.ismv CRC=0xe8130120 > >>>> 3b6023766845b51b075aed474c00f73c *tests/data/lavf/lavf.ismv > >>>> -- > >>>> 1.8.3.1 > >>>> > >>> > >>> will apply the patch set tomorrow unless there are any objections. > >>> > >> > >> You have not really answered whether the current files or the new files > >> are spec-incompliant; you have just reported that one byte is different. > > > > Sorry, I think I have said both current and new file is spec-compliant in the last > > email. > > > > You stated that you think that both files are valid, but you also said > that you don't even know what this byte that is different actually means. > > > By Quicktime file format specs: > > Section Timecode Sample Description, all tmcd field isn't used pts/dts. > > > > As for where is the different for one byte, it's caused by pkt->duration. The > > old is 0(uninitialized), after the patch it's 33(1 frame duration). > > > > The text about Timecode Sample Description reads as follows: "Frame > duration: A 32-bit integer that indicates how long each frame lasts in > real time." This implies that only one of the two files can be > spec-compliant. I am not a mov/ISOBMFF expert, but it seems to me that > the current way of doing things is wrong. But I wonder about whether > your patch is correct for vfr content. Doesn't the property of being vfr > need to be reflected in the timecodes somehow (with different durations > for different packets)? No, it's packet duration, not tmcd frame duration, my patch have do nothing for that.(see movenc.c:2348). In addition, for timecode, I don't think vfr is supported. The tmcd track just contains one packet with the frame number(4byte), so the packet data is used by start of timecode. So I set the dts/pts is avoid the following code think it's invalid packet. If you wonder the patch will change something, I can update the patch keep packet duration to default zero, then we can the fate data untouched, for the following track_duration will use it and make the crc of output is different. > > - Andreas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".