From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BA1CE40E51 for ; Fri, 11 Mar 2022 13:11:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D7C3968B165; Fri, 11 Mar 2022 15:11:22 +0200 (EET) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 52E6368A5BE for ; Fri, 11 Mar 2022 15:11:17 +0200 (EET) Received: from haasn.dev (unknown [10.30.0.2]) by haasn.dev (Postfix) with ESMTP id 01C8949658 for ; Fri, 11 Mar 2022 14:11:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1647004277; bh=YbSnqHoQEqgEsP0nzGrmRA75jH79ex3mW8NtCA3zsY0=; h=Date:From:To:Subject:In-Reply-To:References:From; b=nYmBXMBH8SkAxDvElV/IfdR+B6B1kpVw7VkPSuH1dK15t27lFd+0hvV53FnmwDloH snGic7j5pMuHXSqjwD9xWOsqxU6pLLjEWZ6G03L72Eoq5mvYbtRJ8iRY9fqzke4cM1 3ful3onK5aLwLYeCR80y6AAOHRYXuZXG4sdpb8yU= Date: Fri, 11 Mar 2022 14:11:16 +0100 Message-ID: <20220311141116.GB81480@haasn.xyz> From: Niklas Haas Haas To: ffmpeg-devel@ffmpeg.org In-Reply-To: References: <20220311101413.92878-1-ffmpeg@haasn.xyz> <20220311101741.104545-1-ffmpeg@haasn.xyz> <20220311112137.GB109703@haasn.xyz> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/pngenc: support writing iCCP chunks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 11 Mar 2022 12:05:13 +0100 Andreas Rheinhardt wrote: > Niklas Haas: > > On Fri, 11 Mar 2022 11:17:42 +0100 Niklas Haas wrote: > >> Oops. `-c copy` doesn't actually test the PNG writing code. Need to use > >> `-c png` instead. Fixed in v2. > > > > Hmm, actually, even this doesn't work. I can comment out the iCCP > > writing code and the iCCP chunk still gets written, somehow. Even though > > the file hash is different from the `-c copy` case! > > > > Any idea how to force a re-encode? > > What makes you believe that an iCCP chunk gets written? Is it the size > of the framecrc output? The reason for this is that this is the output > of the decoded png frame and not the hash of the demuxed packet or the > output file. The latter is included in the > +7e412f6a9e2c7fcb674336e5c104518d *tests/data/fate/png-icc.image2. > Comparing +49398 tests/data/fate/png-icc.image2 and the relevant line > from V1 shows that there is indeed more output. > You could use -c copy on the encoded file; and you can also use ffprobe > to directly inspect the side data. > > - Andreas I was running the ffmpeg command (as printed by `make fate-png-icc V=1`) directly and using `exiftool` to look at the png-icc.image2 file it wrote. But it looks as though I accidentally ran the `-c copy` command twice during testing. With the `-c png`, the iCCP chunk is written by the new code, as intended. So never mind this comment. V2 appears to be testing correctly. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".