From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/g729_parser: Check channels
Date: Tue, 8 Mar 2022 00:30:48 +0100
Message-ID: <20220307233048.GP2829255@pb2> (raw)
In-Reply-To: <CAPYw7P5ksyzwT3043PdXaQwDSVLCOYb95m55-oW3Z7DrhsEH-w@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 672 bytes --]
On Sun, Feb 27, 2022 at 03:02:46PM +0100, Paul B Mahol wrote:
> On Sun, Feb 27, 2022 at 2:51 PM Michael Niedermayer <michael@niedermayer.cc>
> wrote:
>
> > Fixes: signed integer overflow: 10 * 808464428 cannot be represented in
> > type 'int'
> > Fixes: assertion failure
> > Fixes: ticket9651
> >
>
>
> LGTM
will apply
>
> Is it possible for parser get 0 channels as input, so it could
> theoretically loop forever?
there is a check for block_size == 0 a few lines later
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Democracy is the form of government in which you can choose your dictator
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-03-07 23:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 13:50 Michael Niedermayer
2022-02-27 14:02 ` Paul B Mahol
2022-03-07 23:30 ` Michael Niedermayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220307233048.GP2829255@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git