* [FFmpeg-devel] [PATCH] avfilter/vf_colorlevels: Fix build failure on ARM
@ 2022-03-06 16:16 Michael Niedermayer
2022-03-06 18:07 ` Paul B Mahol
2022-03-06 18:12 ` Martin Storsjö
0 siblings, 2 replies; 4+ messages in thread
From: Michael Niedermayer @ 2022-03-06 16:16 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavfilter/vf_colorlevels.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/libavfilter/vf_colorlevels.c b/libavfilter/vf_colorlevels.c
index a8859795dd..76adfbd8c8 100644
--- a/libavfilter/vf_colorlevels.c
+++ b/libavfilter/vf_colorlevels.c
@@ -219,7 +219,7 @@ static int colorlevels_slice_8_planar(AVFilterContext *ctx, void *arg, int jobnr
static int colorlevels_slice_9_planar(AVFilterContext *ctx, void *arg, int jobnr, int nb_jobs)
{
ColorLevelsContext *s = ctx->priv;
- const int depth = s->depth;
+ const int depth = 9;
DO_COMMON(uint16_t, av_clip_uintp2, 0, 1)
return 0;
}
@@ -227,7 +227,7 @@ static int colorlevels_slice_9_planar(AVFilterContext *ctx, void *arg, int jobnr
static int colorlevels_slice_10_planar(AVFilterContext *ctx, void *arg, int jobnr, int nb_jobs)
{
ColorLevelsContext *s = ctx->priv;
- const int depth = s->depth;
+ const int depth = 10;
DO_COMMON(uint16_t, av_clip_uintp2, 0, 1)
return 0;
}
@@ -235,7 +235,7 @@ static int colorlevels_slice_10_planar(AVFilterContext *ctx, void *arg, int jobn
static int colorlevels_slice_12_planar(AVFilterContext *ctx, void *arg, int jobnr, int nb_jobs)
{
ColorLevelsContext *s = ctx->priv;
- const int depth = s->depth;
+ const int depth = 12;
DO_COMMON(uint16_t, av_clip_uintp2, 0, 1)
return 0;
}
@@ -243,7 +243,7 @@ static int colorlevels_slice_12_planar(AVFilterContext *ctx, void *arg, int jobn
static int colorlevels_slice_14_planar(AVFilterContext *ctx, void *arg, int jobnr, int nb_jobs)
{
ColorLevelsContext *s = ctx->priv;
- const int depth = s->depth;
+ const int depth = 14;
DO_COMMON(uint16_t, av_clip_uintp2, 0, 1)
return 0;
}
@@ -265,7 +265,7 @@ static int colorlevels_preserve_slice_8_planar(AVFilterContext *ctx, void *arg,
static int colorlevels_preserve_slice_9_planar(AVFilterContext *ctx, void *arg, int jobnr, int nb_jobs)
{
ColorLevelsContext *s = ctx->priv;
- const int depth = s->depth;
+ const int depth = 9;
DO_COMMON(uint16_t, av_clip_uintp2, 1, 1)
return 0;
}
@@ -273,7 +273,7 @@ static int colorlevels_preserve_slice_9_planar(AVFilterContext *ctx, void *arg,
static int colorlevels_preserve_slice_10_planar(AVFilterContext *ctx, void *arg, int jobnr, int nb_jobs)
{
ColorLevelsContext *s = ctx->priv;
- const int depth = s->depth;
+ const int depth = 10;
DO_COMMON(uint16_t, av_clip_uintp2, 1, 1)
return 0;
}
@@ -281,7 +281,7 @@ static int colorlevels_preserve_slice_10_planar(AVFilterContext *ctx, void *arg,
static int colorlevels_preserve_slice_12_planar(AVFilterContext *ctx, void *arg, int jobnr, int nb_jobs)
{
ColorLevelsContext *s = ctx->priv;
- const int depth = s->depth;
+ const int depth = 12;
DO_COMMON(uint16_t, av_clip_uintp2, 1, 1)
return 0;
}
@@ -289,7 +289,7 @@ static int colorlevels_preserve_slice_12_planar(AVFilterContext *ctx, void *arg,
static int colorlevels_preserve_slice_14_planar(AVFilterContext *ctx, void *arg, int jobnr, int nb_jobs)
{
ColorLevelsContext *s = ctx->priv;
- const int depth = s->depth;
+ const int depth = 14;
DO_COMMON(uint16_t, av_clip_uintp2, 1, 1)
return 0;
}
--
2.17.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH] avfilter/vf_colorlevels: Fix build failure on ARM
2022-03-06 16:16 [FFmpeg-devel] [PATCH] avfilter/vf_colorlevels: Fix build failure on ARM Michael Niedermayer
@ 2022-03-06 18:07 ` Paul B Mahol
2022-03-06 18:12 ` Martin Storsjö
1 sibling, 0 replies; 4+ messages in thread
From: Paul B Mahol @ 2022-03-06 18:07 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On 3/6/22, Michael Niedermayer <michael@niedermayer.cc> wrote:
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavfilter/vf_colorlevels.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/libavfilter/vf_colorlevels.c b/libavfilter/vf_colorlevels.c
> index a8859795dd..76adfbd8c8 100644
> --- a/libavfilter/vf_colorlevels.c
> +++ b/libavfilter/vf_colorlevels.c
> @@ -219,7 +219,7 @@ static int colorlevels_slice_8_planar(AVFilterContext
> *ctx, void *arg, int jobnr
> static int colorlevels_slice_9_planar(AVFilterContext *ctx, void *arg, int
> jobnr, int nb_jobs)
> {
> ColorLevelsContext *s = ctx->priv;
> - const int depth = s->depth;
> + const int depth = 9;
> DO_COMMON(uint16_t, av_clip_uintp2, 0, 1)
> return 0;
> }
> @@ -227,7 +227,7 @@ static int colorlevels_slice_9_planar(AVFilterContext
> *ctx, void *arg, int jobnr
> static int colorlevels_slice_10_planar(AVFilterContext *ctx, void *arg, int
> jobnr, int nb_jobs)
> {
> ColorLevelsContext *s = ctx->priv;
> - const int depth = s->depth;
> + const int depth = 10;
> DO_COMMON(uint16_t, av_clip_uintp2, 0, 1)
> return 0;
> }
> @@ -235,7 +235,7 @@ static int colorlevels_slice_10_planar(AVFilterContext
> *ctx, void *arg, int jobn
> static int colorlevels_slice_12_planar(AVFilterContext *ctx, void *arg, int
> jobnr, int nb_jobs)
> {
> ColorLevelsContext *s = ctx->priv;
> - const int depth = s->depth;
> + const int depth = 12;
> DO_COMMON(uint16_t, av_clip_uintp2, 0, 1)
> return 0;
> }
> @@ -243,7 +243,7 @@ static int colorlevels_slice_12_planar(AVFilterContext
> *ctx, void *arg, int jobn
> static int colorlevels_slice_14_planar(AVFilterContext *ctx, void *arg, int
> jobnr, int nb_jobs)
> {
> ColorLevelsContext *s = ctx->priv;
> - const int depth = s->depth;
> + const int depth = 14;
> DO_COMMON(uint16_t, av_clip_uintp2, 0, 1)
> return 0;
> }
> @@ -265,7 +265,7 @@ static int
> colorlevels_preserve_slice_8_planar(AVFilterContext *ctx, void *arg,
> static int colorlevels_preserve_slice_9_planar(AVFilterContext *ctx, void
> *arg, int jobnr, int nb_jobs)
> {
> ColorLevelsContext *s = ctx->priv;
> - const int depth = s->depth;
> + const int depth = 9;
> DO_COMMON(uint16_t, av_clip_uintp2, 1, 1)
> return 0;
> }
> @@ -273,7 +273,7 @@ static int
> colorlevels_preserve_slice_9_planar(AVFilterContext *ctx, void *arg,
> static int colorlevels_preserve_slice_10_planar(AVFilterContext *ctx, void
> *arg, int jobnr, int nb_jobs)
> {
> ColorLevelsContext *s = ctx->priv;
> - const int depth = s->depth;
> + const int depth = 10;
> DO_COMMON(uint16_t, av_clip_uintp2, 1, 1)
> return 0;
> }
> @@ -281,7 +281,7 @@ static int
> colorlevels_preserve_slice_10_planar(AVFilterContext *ctx, void *arg,
> static int colorlevels_preserve_slice_12_planar(AVFilterContext *ctx, void
> *arg, int jobnr, int nb_jobs)
> {
> ColorLevelsContext *s = ctx->priv;
> - const int depth = s->depth;
> + const int depth = 12;
> DO_COMMON(uint16_t, av_clip_uintp2, 1, 1)
> return 0;
> }
> @@ -289,7 +289,7 @@ static int
> colorlevels_preserve_slice_12_planar(AVFilterContext *ctx, void *arg,
> static int colorlevels_preserve_slice_14_planar(AVFilterContext *ctx, void
> *arg, int jobnr, int nb_jobs)
> {
> ColorLevelsContext *s = ctx->priv;
> - const int depth = s->depth;
> + const int depth = 14;
> DO_COMMON(uint16_t, av_clip_uintp2, 1, 1)
> return 0;
> }
> --
> 2.17.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH] avfilter/vf_colorlevels: Fix build failure on ARM
2022-03-06 16:16 [FFmpeg-devel] [PATCH] avfilter/vf_colorlevels: Fix build failure on ARM Michael Niedermayer
2022-03-06 18:07 ` Paul B Mahol
@ 2022-03-06 18:12 ` Martin Storsjö
2022-03-06 19:18 ` Michael Niedermayer
1 sibling, 1 reply; 4+ messages in thread
From: Martin Storsjö @ 2022-03-06 18:12 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Sun, 6 Mar 2022, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavfilter/vf_colorlevels.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
LGTM
(Sorry I didn't check the ML before sending my patch. Maybe mention the
commit that introduced the regression and the reason, about immediate
constants, too.)
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avfilter/vf_colorlevels: Fix build failure on ARM
2022-03-06 18:12 ` Martin Storsjö
@ 2022-03-06 19:18 ` Michael Niedermayer
0 siblings, 0 replies; 4+ messages in thread
From: Michael Niedermayer @ 2022-03-06 19:18 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 768 bytes --]
On Sun, Mar 06, 2022 at 08:12:26PM +0200, Martin Storsjö wrote:
> On Sun, 6 Mar 2022, Michael Niedermayer wrote:
>
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> > libavfilter/vf_colorlevels.c | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
>
> LGTM
>
> (Sorry I didn't check the ML before sending my patch. Maybe mention the
> commit that introduced the regression and the reason, about immediate
> constants, too.)
I will steal your commit message then
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-06 19:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-06 16:16 [FFmpeg-devel] [PATCH] avfilter/vf_colorlevels: Fix build failure on ARM Michael Niedermayer
2022-03-06 18:07 ` Paul B Mahol
2022-03-06 18:12 ` Martin Storsjö
2022-03-06 19:18 ` Michael Niedermayer
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git