* Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_colorlevels: add planar rgb formats support
[not found] <20220306125902.3340241048E@natalya.videolan.org>
@ 2022-03-06 15:59 ` Michael Niedermayer
0 siblings, 0 replies; only message in thread
From: Michael Niedermayer @ 2022-03-06 15:59 UTC (permalink / raw)
To: ffmpeg-devel
[-- Attachment #1.1: Type: text/plain, Size: 4550 bytes --]
On Sun, Mar 06, 2022 at 12:59:01PM +0000, Paul B Mahol wrote:
> ffmpeg | branch: master | Paul B Mahol <onemda@gmail.com> | Sun Mar 6 13:57:34 2022 +0100| [10c2ef1ca41dbe7811f0588f4163c8cf7b8fda66] | committer: Paul B Mahol
>
> avfilter/vf_colorlevels: add planar rgb formats support
>
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=10c2ef1ca41dbe7811f0588f4163c8cf7b8fda66
> ---
>
> libavfilter/vf_colorlevels.c | 232 +++++++++++++++++++++++++++++++++++--------
> 1 file changed, 189 insertions(+), 43 deletions(-)
[...]
> @@ -182,31 +178,126 @@ typedef struct ThreadData {
> dst_a += dst_linesize; \
> }
>
> +#define CLIP8(x, depth) av_clip_uint8(x)
> +#define CLIP16(x, depth) av_clip_uint16(x)
[...]
> +static int colorlevels_slice_9_planar(AVFilterContext *ctx, void *arg, int jobnr, int nb_jobs)
> +{
> + ColorLevelsContext *s = ctx->priv;
> + const int depth = s->depth;
> + DO_COMMON(uint16_t, av_clip_uintp2, 0, 1)
> + return 0;
These things break build on ARM
Is there any particular reason why you dont post patches for some changes?
These breakages could be avoided if you posted this 1-2 days before applying
In file included from src/libavutil/intmath.h:30:0,
from src/libavutil/common.h:88,
from src/libavutil/avutil.h:296,
from src/libavutil/opt.h:31,
from src/libavfilter/vf_colorlevels.c:22:
src/libavutil/arm/intmath.h: In function ‘colorlevels_slice_9_planar’:
src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn’t match constraints
__asm__ ("usat %0, %2, %1" : "=r"(x) : "r"(a), "i"(p));
^~~~~~~
src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn’t match constraints
__asm__ ("usat %0, %2, %1" : "=r"(x) : "r"(a), "i"(p));
^~~~~~~
src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn’t match constraints
__asm__ ("usat %0, %2, %1" : "=r"(x) : "r"(a), "i"(p));
^~~~~~~
src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn’t match constraints
__asm__ ("usat %0, %2, %1" : "=r"(x) : "r"(a), "i"(p));
^~~~~~~
src/libavutil/arm/intmath.h:77:5: error: impossible constraint in ‘asm’
__asm__ ("usat %0, %2, %1" : "=r"(x) : "r"(a), "i"(p));
^~~~~~~
src/libavutil/arm/intmath.h:77:5: error: impossible constraint in ‘asm’
__asm__ ("usat %0, %2, %1" : "=r"(x) : "r"(a), "i"(p));
^~~~~~~
src/libavutil/arm/intmath.h:77:5: error: impossible constraint in ‘asm’
__asm__ ("usat %0, %2, %1" : "=r"(x) : "r"(a), "i"(p));
^~~~~~~
src/libavutil/arm/intmath.h:77:5: error: impossible constraint in ‘asm’
__asm__ ("usat %0, %2, %1" : "=r"(x) : "r"(a), "i"(p));
^~~~~~~
src/libavutil/arm/intmath.h: In function ‘colorlevels_preserve_slice_9_planar’:
src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn’t match constraints
__asm__ ("usat %0, %2, %1" : "=r"(x) : "r"(a), "i"(p));
^~~~~~~
src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn’t match constraints
__asm__ ("usat %0, %2, %1" : "=r"(x) : "r"(a), "i"(p));
^~~~~~~
src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn’t match constraints
__asm__ ("usat %0, %2, %1" : "=r"(x) : "r"(a), "i"(p));
^~~~~~~
src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn’t match constraints
__asm__ ("usat %0, %2, %1" : "=r"(x) : "r"(a), "i"(p));
^~~~~~~
src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn’t match constraints
__asm__ ("usat %0, %2, %1" : "=r"(x) : "r"(a), "i"(p));
^~~~~~~
src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn’t match constraints
__asm__ ("usat %0, %2, %1" : "=r"(x) : "r"(a), "i"(p));
^~~~~~~
src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn’t match constraints
__asm__ ("usat %0, %2, %1" : "=r"(x) : "r"(a), "i"(p));
^~~~~~~
src/ffbuild/common.mak:78: recipe for target 'libavfilter/vf_colorlevels.o' failed
make: *** [libavfilter/vf_colorlevels.o] Error 1
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] only message in thread