From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 717B840AB9 for ; Sun, 6 Mar 2022 16:00:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EE95868B08A; Sun, 6 Mar 2022 18:00:06 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2194E68A921 for ; Sun, 6 Mar 2022 18:00:00 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 2071460002 for ; Sun, 6 Mar 2022 15:59:59 +0000 (UTC) Date: Sun, 6 Mar 2022 16:59:59 +0100 From: Michael Niedermayer To: ffmpeg-devel@ffmpeg.org Message-ID: <20220306155959.GF2978559@pb2> References: <20220306125902.3340241048E@natalya.videolan.org> MIME-Version: 1.0 In-Reply-To: <20220306125902.3340241048E@natalya.videolan.org> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_colorlevels: add planar rgb formats support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7622767667699356293==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7622767667699356293== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XRI2XbIfl/05pQwm" Content-Disposition: inline --XRI2XbIfl/05pQwm Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 06, 2022 at 12:59:01PM +0000, Paul B Mahol wrote: > ffmpeg | branch: master | Paul B Mahol | Sun Mar 6 13= :57:34 2022 +0100| [10c2ef1ca41dbe7811f0588f4163c8cf7b8fda66] | committer: = Paul B Mahol >=20 > avfilter/vf_colorlevels: add planar rgb formats support >=20 > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=3Dcommit;h=3D10c2ef1ca= 41dbe7811f0588f4163c8cf7b8fda66 > --- >=20 > libavfilter/vf_colorlevels.c | 232 +++++++++++++++++++++++++++++++++++--= ------ > 1 file changed, 189 insertions(+), 43 deletions(-) [...] > @@ -182,31 +178,126 @@ typedef struct ThreadData { > dst_a +=3D dst_linesize; = \ > } > =20 > +#define CLIP8(x, depth) av_clip_uint8(x) > +#define CLIP16(x, depth) av_clip_uint16(x) [...] > +static int colorlevels_slice_9_planar(AVFilterContext *ctx, void *arg, i= nt jobnr, int nb_jobs) > +{ > + ColorLevelsContext *s =3D ctx->priv; > + const int depth =3D s->depth; > + DO_COMMON(uint16_t, av_clip_uintp2, 0, 1) > + return 0; These things break build on ARM Is there any particular reason why you dont post patches for some changes? These breakages could be avoided if you posted this 1-2 days before applying In file included from src/libavutil/intmath.h:30:0, from src/libavutil/common.h:88, from src/libavutil/avutil.h:296, from src/libavutil/opt.h:31, from src/libavfilter/vf_colorlevels.c:22: src/libavutil/arm/intmath.h: In function =E2=80=98colorlevels_slice_9_plana= r=E2=80=99: src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn=E2= =80=99t match constraints __asm__ ("usat %0, %2, %1" : "=3Dr"(x) : "r"(a), "i"(p)); ^~~~~~~ src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn=E2= =80=99t match constraints __asm__ ("usat %0, %2, %1" : "=3Dr"(x) : "r"(a), "i"(p)); ^~~~~~~ src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn=E2= =80=99t match constraints __asm__ ("usat %0, %2, %1" : "=3Dr"(x) : "r"(a), "i"(p)); ^~~~~~~ src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn=E2= =80=99t match constraints __asm__ ("usat %0, %2, %1" : "=3Dr"(x) : "r"(a), "i"(p)); ^~~~~~~ src/libavutil/arm/intmath.h:77:5: error: impossible constraint in =E2=80=98= asm=E2=80=99 __asm__ ("usat %0, %2, %1" : "=3Dr"(x) : "r"(a), "i"(p)); ^~~~~~~ src/libavutil/arm/intmath.h:77:5: error: impossible constraint in =E2=80=98= asm=E2=80=99 __asm__ ("usat %0, %2, %1" : "=3Dr"(x) : "r"(a), "i"(p)); ^~~~~~~ src/libavutil/arm/intmath.h:77:5: error: impossible constraint in =E2=80=98= asm=E2=80=99 __asm__ ("usat %0, %2, %1" : "=3Dr"(x) : "r"(a), "i"(p)); ^~~~~~~ src/libavutil/arm/intmath.h:77:5: error: impossible constraint in =E2=80=98= asm=E2=80=99 __asm__ ("usat %0, %2, %1" : "=3Dr"(x) : "r"(a), "i"(p)); ^~~~~~~ src/libavutil/arm/intmath.h: In function =E2=80=98colorlevels_preserve_slic= e_9_planar=E2=80=99: src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn=E2= =80=99t match constraints __asm__ ("usat %0, %2, %1" : "=3Dr"(x) : "r"(a), "i"(p)); ^~~~~~~ src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn=E2= =80=99t match constraints __asm__ ("usat %0, %2, %1" : "=3Dr"(x) : "r"(a), "i"(p)); ^~~~~~~ src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn=E2= =80=99t match constraints __asm__ ("usat %0, %2, %1" : "=3Dr"(x) : "r"(a), "i"(p)); ^~~~~~~ src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn=E2= =80=99t match constraints __asm__ ("usat %0, %2, %1" : "=3Dr"(x) : "r"(a), "i"(p)); ^~~~~~~ src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn=E2= =80=99t match constraints __asm__ ("usat %0, %2, %1" : "=3Dr"(x) : "r"(a), "i"(p)); ^~~~~~~ src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn=E2= =80=99t match constraints __asm__ ("usat %0, %2, %1" : "=3Dr"(x) : "r"(a), "i"(p)); ^~~~~~~ src/libavutil/arm/intmath.h:77:5: warning: asm operand 2 probably doesn=E2= =80=99t match constraints __asm__ ("usat %0, %2, %1" : "=3Dr"(x) : "r"(a), "i"(p)); ^~~~~~~ src/ffbuild/common.mak:78: recipe for target 'libavfilter/vf_colorlevels.o'= failed make: *** [libavfilter/vf_colorlevels.o] Error 1 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship naturally arises out of democracy, and the most aggravated form of tyranny and slavery out of the most extreme liberty. -- Plato --XRI2XbIfl/05pQwm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYiTaewAKCRBhHseHBAsP qw06AJ9zAdTDi6/GuGSb382DsQZm2LtmJgCdHN6JTt0GJniUWXeT1k0S8+9K7qw= =iWoz -----END PGP SIGNATURE----- --XRI2XbIfl/05pQwm-- --===============7622767667699356293== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7622767667699356293==--