From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C0AD140A24 for ; Fri, 4 Mar 2022 18:16:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 22AA668B17E; Fri, 4 Mar 2022 20:16:51 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E22A068A6F6 for ; Fri, 4 Mar 2022 20:16:43 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 0EF0860003 for ; Fri, 4 Mar 2022 18:16:42 +0000 (UTC) Date: Fri, 4 Mar 2022 19:16:42 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220304181642.GE2829255@pb2> References: <20161103103050.31714-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/ac3dec: Check expacc X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7756586070589722359==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7756586070589722359== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Etc01/v/9OUuxWVu" Content-Disposition: inline --Etc01/v/9OUuxWVu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 03, 2022 at 06:36:29PM +0100, Paul B Mahol wrote: > On 11/3/16, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/ac3dec.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c > > index a95c204..499971a 100644 > > --- a/libavcodec/ac3dec.c > > +++ b/libavcodec/ac3dec.c > > @@ -426,6 +426,10 @@ static int decode_exponents(AC3DecodeContext *s, > > group_size =3D exp_strategy + (exp_strategy =3D=3D EXP_D45); > > for (grp =3D 0, i =3D 0; grp < ngrps; grp++) { > > expacc =3D get_bits(gbc, 7); > > + if (expacc >=3D 125) { > > + av_log(s->avctx, AV_LOG_ERROR, "expacc %d is out-of-range\= n", > > expacc); > > + return AVERROR_INVALIDDATA; > > + } > > dexp[i++] =3D ungroup_3_in_7_bits_tab[expacc][0]; > > dexp[i++] =3D ungroup_3_in_7_bits_tab[expacc][1]; > > dexp[i++] =3D ungroup_3_in_7_bits_tab[expacc][2]; > > -- >=20 > Please revert this ASAP. It breaks decoding valid files. please provide an affected file / link to one thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "You are 36 times more likely to die in a bathtub than at the hands of a terrorist. Also, you are 2.5 times more likely to become a president and 2 times more likely to become an astronaut, than to die in a terrorist attack." -- Thoughty2 --Etc01/v/9OUuxWVu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYiJXiQAKCRBhHseHBAsP q1TWAJwNWL/fjLmDxCBpM3qXM0ccf3pGTgCghMWndaZOXXfs4qT+9nCKXnrctlU= =7eeC -----END PGP SIGNATURE----- --Etc01/v/9OUuxWVu-- --===============7756586070589722359== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7756586070589722359==--