From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1024E421FD for ; Mon, 28 Feb 2022 14:17:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EA48368AE71; Mon, 28 Feb 2022 16:17:12 +0200 (EET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7A61E68A9AD for ; Mon, 28 Feb 2022 16:17:06 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id C775CC000E for ; Mon, 28 Feb 2022 14:17:05 +0000 (UTC) Date: Mon, 28 Feb 2022 15:17:05 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220228141705.GT2829255@pb2> References: <20220217111151.28498-1-chenhao@loongson.cn> <20220217111151.28498-2-chenhao@loongson.cn> <20220221150035.GZ2829255@pb2> <6BAA644D-040A-48DC-BE3B-6BB9F5427820@loongson.cn> MIME-Version: 1.0 In-Reply-To: <6BAA644D-040A-48DC-BE3B-6BB9F5427820@loongson.cn> Subject: Re: [FFmpeg-devel] [PATCH v2 1/5] avutil: [loongarch] Update loongson_intrinsics.h to v1.1.0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2742087891787497377==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2742087891787497377== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="v7ESM9JXKzN5XEm1" Content-Disposition: inline --v7ESM9JXKzN5XEm1 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 28, 2022 at 04:19:55PM +0800, =E6=AE=B7=E6=97=B6=E5=8F=8B wrote: >=20 >=20 > > 2022=E5=B9=B42=E6=9C=8821=E6=97=A5 =E4=B8=8B=E5=8D=8811:00=EF=BC=8CMich= ael Niedermayer =E5=86=99=E9=81=93=EF=BC=9A > >=20 > > On Thu, Feb 17, 2022 at 07:11:47PM +0800, Hao Chen wrote: > >> The loongson_intrinsics.h file is updated from v1.0.3 version > >> to v1.1.0. Some spelling mistakes are fixed and new functions are adde= d. > >>=20 > >> Signed-off-by: Hao Chen > >> --- > >> libavutil/loongarch/loongson_intrinsics.h | 1697 +++++++++++---------- > >> 1 file changed, 884 insertions(+), 813 deletions(-) > >>=20 > >> diff --git a/libavutil/loongarch/loongson_intrinsics.h b/libavutil/loo= ngarch/loongson_intrinsics.h > >> index 6e0439f829..eb256863c8 100644 > >> --- a/libavutil/loongarch/loongson_intrinsics.h > >> +++ b/libavutil/loongarch/loongson_intrinsics.h > >> @@ -33,7 +33,7 @@ > >> * Xiwei Gu > >> * Lu Wang > >> * > >> - * This file is a header file for loongarch builtin extention. > >> + * This file is a header file for loongarch builtin extension. > >> * > >> */ > >>=20 > >> @@ -42,50 +42,50 @@ > >>=20 > >> /** > >> * MAJOR version: Macro usage changes. > >> - * MINOR version: Add new functions, or bug fix. > >> + * MINOR version: Add new functions, or bug fixes. > >> * MICRO version: Comment changes or implementation changes. > >> */ > >> #define LSOM_VERSION_MAJOR 1 > >> -#define LSOM_VERSION_MINOR 0 > >> -#define LSOM_VERSION_MICRO 3 > >> +#define LSOM_VERSION_MINOR 1 > >> +#define LSOM_VERSION_MICRO 0 > >>=20 > >> #define DUP2_ARG1(_INS, _IN0, _IN1, _OUT0, _OUT1) \ > >> -{ \ > >> - _OUT0 =3D _INS(_IN0); \ > >> - _OUT1 =3D _INS(_IN1); \ > >> -} > >> + { \ > >> + _OUT0 =3D _INS(_IN0); \ > >> + _OUT1 =3D _INS(_IN1); \ > >> + } > >>=20 > >> #define DUP2_ARG2(_INS, _IN0, _IN1, _IN2, _IN3, _OUT0, _OUT1) \ > >> -{ \ > >> - _OUT0 =3D _INS(_IN0, _IN1); \ > >> - _OUT1 =3D _INS(_IN2, _IN3); \ > >> -} > >> + { \ > >> + _OUT0 =3D _INS(_IN0, _IN1); \ > >> + _OUT1 =3D _INS(_IN2, _IN3); \ > >> + } > >=20 > > These style changes differ from the recommandition in doc/developer.texi > > is that intentional ? > >=20 > > thx >=20 >=20 > Can we keep this style in here, it=E2=80=99s helpful for us to maintain t= his header file > which used for some other projects too. Thanks very much. yes, it makes sense to keep the style under these circumstances thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich man's house there is no place to spit but his face. -- Diogenes of Sinope --v7ESM9JXKzN5XEm1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYhzZYQAKCRBhHseHBAsP q03sAJ0UT0FAPLA1/MfwM39e6X8fsl8ZCACdFEuWvod2ungIFKr8gjQbBYkDm+Q= =1N3o -----END PGP SIGNATURE----- --v7ESM9JXKzN5XEm1-- --===============2742087891787497377== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2742087891787497377==--