From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1CBA1405BE for ; Fri, 25 Feb 2022 14:34:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C6F2D68B347; Fri, 25 Feb 2022 16:34:56 +0200 (EET) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 87C0B68B2AE for ; Fri, 25 Feb 2022 16:34:50 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 89709240019 for ; Fri, 25 Feb 2022 14:34:49 +0000 (UTC) Date: Fri, 25 Feb 2022 15:34:48 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220225143448.GG2829255@pb2> References: <20220223142951.40366-1-martin@martin.st> <20220223142951.40366-6-martin@martin.st> MIME-Version: 1.0 In-Reply-To: <20220223142951.40366-6-martin@martin.st> Subject: Re: [FFmpeg-devel] [PATCH 05/13] libavcodec: Split version.h X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8415368168657998677==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8415368168657998677== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2IhqvEN0hUYZHFO6" Content-Disposition: inline --2IhqvEN0hUYZHFO6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 23, 2022 at 04:29:43PM +0200, Martin Storsj=C3=B6 wrote: > This avoids including version.h in all source files, avoiding > unnecessary rebuilds when the version number is bumped. Only > version_major.h is included by the main header, which defines > availability of e.g. FF_API_* macros, and which is bumped much > less often. > --- > fftools/cmdutils.c | 1 + > fftools/ffmpeg.c | 1 + > fftools/ffprobe.c | 1 + > libavcodec/Makefile | 1 + > libavcodec/aacenc.c | 1 + > libavcodec/avcodec.c | 1 + > libavcodec/avcodec.h | 2 +- > libavcodec/codec.h | 2 +- > libavcodec/dpxenc.c | 1 + > libavcodec/j2kenc.c | 1 + > libavcodec/libvorbisenc.c | 1 + > libavcodec/mjpegenc_common.c | 1 + > libavcodec/mpeg4videoenc.c | 1 + > libavcodec/options_table.h | 2 +- > libavcodec/packet.h | 2 +- > libavcodec/pthread_frame.c | 2 +- > libavcodec/tiffenc.c | 1 + > libavcodec/vaapi_encode_h264.c | 1 + > libavcodec/version.h | 28 ++--------------- > libavcodec/version_major.h | 55 ++++++++++++++++++++++++++++++++++ > libavformat/movenc.c | 1 + > 21 files changed, 76 insertions(+), 31 deletions(-) > create mode 100644 libavcodec/version_major.h not sure i missed some patch but this seems not to build CC libavcodec/vc2enc.o libavcodec/vc2enc.c: In function =E2=80=98vc2_encode_frame=E2=80=99: libavcodec/vc2enc.c:957:48: error: =E2=80=98LIBAVCODEC_IDENT=E2=80=99 undec= lared (first use in this function); did you mean =E2=80=98LIBAVUTIL_IDENT= =E2=80=99? const char *aux_data =3D bitexact ? "Lavc" : LIBAVCODEC_IDENT; ^~~~~~~~~~~~~~~~ LIBAVUTIL_IDENT libavcodec/vc2enc.c:957:48: note: each undeclared identifier is reported on= ly once for each function it appears in ffbuild/common.mak:78: recipe for target 'libavcodec/vc2enc.o' failed make: *** [libavcodec/vc2enc.o] Error 1 make: Target 'all' not remade because of errors. [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The misfortune of the wise is better than the prosperity of the fool. -- Epicurus --2IhqvEN0hUYZHFO6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYhjpAQAKCRBhHseHBAsP q0u4AJ4rVvuw9Y3uGbK0Phw3Iy2g0/OaQQCfQU1411c/GdbTck5yT+06A44EBjw= =4ya3 -----END PGP SIGNATURE----- --2IhqvEN0hUYZHFO6-- --===============8415368168657998677== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8415368168657998677==--