From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] swscale: Take the destination range into account for yuv->rgb->yuv conversions
Date: Thu, 24 Feb 2022 23:50:17 +0100
Message-ID: <20220224225017.GF2829255@pb2> (raw)
In-Reply-To: <20220223194553.59514-1-martin@martin.st>
[-- Attachment #1.1: Type: text/plain, Size: 1307 bytes --]
On Wed, Feb 23, 2022 at 09:45:53PM +0200, Martin Storsjö wrote:
> The range parameters need to be set up before calling
> sws_init_context (which selects which fastpaths can be used;
> this gets called by sws_getContext); solely passing them via
> sws_setColorspaceDetails isn't enough.
>
> This fixes producing full range YUV range output when doing
> YUV->YUV conversions between different YUV color spaces.
>
> Signed-off-by: Martin Storsjö <martin@martin.st>
> ---
> libswscale/utils.c | 11 ++++++++---
> tests/fate/libswscale.mak | 16 ++++++++++++++++
> tests/ref/fate/sws-yuv-colorspace | 6 ++++++
> tests/ref/fate/sws-yuv-range | 6 ++++++
> 4 files changed, 36 insertions(+), 3 deletions(-)
> create mode 100644 tests/ref/fate/sws-yuv-colorspace
> create mode 100644 tests/ref/fate/sws-yuv-range
LGTM
tested on mingw32/64 + wine / linux x86 32/64bit, arm/mips qemu
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-24 22:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 14:45 [FFmpeg-devel] [PATCH] " Martin Storsjö
2022-02-19 15:48 ` Michael Niedermayer
2022-02-19 21:43 ` Martin Storsjö
2022-02-23 19:45 ` [FFmpeg-devel] [PATCH v2] " Martin Storsjö
2022-02-24 22:50 ` Michael Niedermayer [this message]
2022-02-25 9:13 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224225017.GF2829255@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git